mirror of
https://github.com/BookStackApp/BookStack.git
synced 2024-10-01 01:36:00 -04:00
Pages: Fixed unused changelog on first page publish
Included test to cover. For #5056
This commit is contained in:
parent
c77e8730d6
commit
a8ce199e0d
@ -77,7 +77,8 @@ class PageRepo
|
||||
$this->updateTemplateStatusAndContentFromInput($draft, $input);
|
||||
$this->baseRepo->update($draft, $input);
|
||||
|
||||
$this->revisionRepo->storeNewForPage($draft, trans('entities.pages_initial_revision'));
|
||||
$summary = trim($input['summary'] ?? '') ?: trans('entities.pages_initial_revision');
|
||||
$this->revisionRepo->storeNewForPage($draft, $summary);
|
||||
$draft->refresh();
|
||||
|
||||
Activity::add(ActivityType::PAGE_CREATE, $draft);
|
||||
|
@ -86,6 +86,32 @@ class PageTest extends TestCase
|
||||
$resp->assertSee('# a title');
|
||||
}
|
||||
|
||||
public function test_page_creation_allows_summary_to_be_set()
|
||||
{
|
||||
$book = $this->entities->book();
|
||||
|
||||
$this->asEditor()->get($book->getUrl('/create-page'));
|
||||
$draft = Page::query()->where('book_id', '=', $book->id)
|
||||
->where('draft', '=', true)->first();
|
||||
|
||||
$details = [
|
||||
'html' => '<h1>a title</h1>',
|
||||
'name' => 'My page with summary',
|
||||
'summary' => 'Here is my changelog message for a new page!',
|
||||
];
|
||||
$resp = $this->post($book->getUrl("/draft/{$draft->id}"), $details);
|
||||
$resp->assertRedirect();
|
||||
|
||||
$this->assertDatabaseHas('page_revisions', [
|
||||
'page_id' => $draft->id,
|
||||
'summary' => 'Here is my changelog message for a new page!',
|
||||
]);
|
||||
|
||||
$draft->refresh();
|
||||
$resp = $this->get($draft->getUrl('/revisions'));
|
||||
$resp->assertSee('Here is my changelog message for a new page!');
|
||||
}
|
||||
|
||||
public function test_page_delete()
|
||||
{
|
||||
$page = $this->entities->page();
|
||||
|
Loading…
Reference in New Issue
Block a user