From 9b83c573163cd7f60b3a82d6b8c0f89c86d1aab7 Mon Sep 17 00:00:00 2001 From: Dan Brown Date: Mon, 8 Feb 2016 20:41:40 +0000 Subject: [PATCH] Fixed some design issues and improved page export styling Fixed alignment on export options dropdown. Fixed bullet list items sitting too close next to floated content. Fixes #34. Fixed text overlaying images in PDF exports (Floats removed for now). Fixes #53. Fixed spaced table cells on html & PDF exports. --- resources/assets/sass/_lists.scss | 4 ++-- resources/assets/sass/_text.scss | 8 ++++---- resources/assets/sass/export-styles.scss | 7 ++++++- resources/views/pages/pdf.blade.php | 6 ++++++ resources/views/pages/show.blade.php | 6 +++--- 5 files changed, 21 insertions(+), 10 deletions(-) diff --git a/resources/assets/sass/_lists.scss b/resources/assets/sass/_lists.scss index fa609ee33..748694635 100644 --- a/resources/assets/sass/_lists.scss +++ b/resources/assets/sass/_lists.scss @@ -105,8 +105,8 @@ } .book-tree .sidebar-page-list { list-style: none; - margin: 0; - margin-top: $-xs; + margin: $-xs 0 0; + padding-left: 0; border-left: 5px solid $color-book; li a { display: block; diff --git a/resources/assets/sass/_text.scss b/resources/assets/sass/_text.scss index d3663dee3..499896631 100644 --- a/resources/assets/sass/_text.scss +++ b/resources/assets/sass/_text.scss @@ -223,13 +223,13 @@ span.highlight { * Lists */ ul { - list-style: disc; - margin-left: $-m*1.5; + padding-left: $-m * 1.5; + list-style: disc inside; } ol { - list-style: decimal; - margin-left: $-m*1.5; + list-style: decimal inside; + padding-left: $-m * 1.5; } /* diff --git a/resources/assets/sass/export-styles.scss b/resources/assets/sass/export-styles.scss index 90fdb196c..60450f3e2 100644 --- a/resources/assets/sass/export-styles.scss +++ b/resources/assets/sass/export-styles.scss @@ -9,4 +9,9 @@ @import "tables"; @import "header"; @import "lists"; -@import "pages"; \ No newline at end of file +@import "pages"; + +table { + border-spacing: 0; + border-collapse: collapse; +} \ No newline at end of file diff --git a/resources/views/pages/pdf.blade.php b/resources/views/pages/pdf.blade.php index 1077c0931..3a376334d 100644 --- a/resources/views/pages/pdf.blade.php +++ b/resources/views/pages/pdf.blade.php @@ -20,5 +20,11 @@ table td { width: auto !important; } + + .page-content img.align-left, .page-content img.align-right { + float: none !important; + clear: both; + display: block; + } @stop \ No newline at end of file diff --git a/resources/views/pages/show.blade.php b/resources/views/pages/show.blade.php index a2c82fd9d..8a5bffca4 100644 --- a/resources/views/pages/show.blade.php +++ b/resources/views/pages/show.blade.php @@ -22,9 +22,9 @@
Export
@if($currentUser->can('page-update'))