diff --git a/app/Auth/Permissions/PermissionService.php b/app/Auth/Permissions/PermissionService.php index 1e1ee3946..7e710edaf 100644 --- a/app/Auth/Permissions/PermissionService.php +++ b/app/Auth/Permissions/PermissionService.php @@ -577,7 +577,7 @@ class PermissionService $query2->where('has_permission_own', '=', 1) ->where('created_by', '=', $userId); }); - }) ; + }); if (!is_null($entityClass)) { $entityInstance = app()->make($entityClass); diff --git a/app/Entities/Bookshelf.php b/app/Entities/Bookshelf.php index 08ce8d8cb..1de767fec 100644 --- a/app/Entities/Bookshelf.php +++ b/app/Entities/Bookshelf.php @@ -26,7 +26,9 @@ class Bookshelf extends Entity */ public function books() { - return $this->belongsToMany(Book::class, 'bookshelves_books', 'bookshelf_id', 'book_id')->orderBy('order', 'asc'); + return $this->belongsToMany(Book::class, 'bookshelves_books', 'bookshelf_id', 'book_id') + ->withPivot('order') + ->orderBy('order', 'asc'); } /** diff --git a/app/Entities/Repos/EntityRepo.php b/app/Entities/Repos/EntityRepo.php index 6fc2689a5..3bf70c327 100644 --- a/app/Entities/Repos/EntityRepo.php +++ b/app/Entities/Repos/EntityRepo.php @@ -577,6 +577,21 @@ class EntityRepo $shelf->books()->sync($syncData); } + /** + * Append a Book to a BookShelf. + * @param Bookshelf $shelf + * @param Book $book + */ + public function appendBookToShelf(Bookshelf $shelf, Book $book) + { + if ($shelf->contains($book)) { + return; + } + + $maxOrder = $shelf->books()->max('order'); + $shelf->books()->attach($book->id, ['order' => $maxOrder + 1]); + } + /** * Change the book that an entity belongs to. * @param string $type diff --git a/app/Http/Controllers/BookController.php b/app/Http/Controllers/BookController.php index 9eb19ce65..24e0d784d 100644 --- a/app/Http/Controllers/BookController.php +++ b/app/Http/Controllers/BookController.php @@ -75,30 +75,55 @@ class BookController extends Controller /** * Show the form for creating a new book. + * @param string $shelfSlug * @return Response + * @throws \BookStack\Exceptions\NotFoundException */ - public function create() + public function create(string $shelfSlug = null) { + $bookshelf = null; + if ($shelfSlug !== null) { + $bookshelf = $this->entityRepo->getBySlug('bookshelf', $shelfSlug); + $this->checkOwnablePermission('bookshelf-update', $bookshelf); + } + $this->checkPermission('book-create-all'); $this->setPageTitle(trans('entities.books_create')); - return view('books.create'); + return view('books.create', [ + 'bookshelf' => $bookshelf + ]); } /** * Store a newly created book in storage. * - * @param Request $request + * @param Request $request + * @param string $shelfSlug * @return Response + * @throws \BookStack\Exceptions\NotFoundException */ - public function store(Request $request) + public function store(Request $request, string $shelfSlug = null) { $this->checkPermission('book-create-all'); $this->validate($request, [ 'name' => 'required|string|max:255', 'description' => 'string|max:1000' ]); + + $bookshelf = null; + if ($shelfSlug !== null) { + $bookshelf = $this->entityRepo->getBySlug('bookshelf', $shelfSlug); + $this->checkOwnablePermission('bookshelf-update', $bookshelf); + } + $book = $this->entityRepo->createFromInput('book', $request->all()); Activity::add($book, 'book_create', $book->id); + + if ($bookshelf) { + $this->entityRepo->appendBookToShelf($bookshelf, $book); + Activity::add($bookshelf, 'bookshelf_update'); + } + return redirect($book->getUrl()); } diff --git a/resources/lang/en/entities.php b/resources/lang/en/entities.php index c2c15d72f..8a3aeb022 100644 --- a/resources/lang/en/entities.php +++ b/resources/lang/en/entities.php @@ -74,6 +74,7 @@ return [ 'shelves_create' => 'Create New Shelf', 'shelves_popular' => 'Popular Shelves', 'shelves_new' => 'New Shelves', + 'shelves_new_action' => 'New Shelf', 'shelves_popular_empty' => 'The most popular shelves will appear here.', 'shelves_new_empty' => 'The most recently created shelves will appear here.', 'shelves_save' => 'Save Shelf', @@ -104,6 +105,7 @@ return [ 'books_popular' => 'Popular Books', 'books_recent' => 'Recent Books', 'books_new' => 'New Books', + 'books_new_action' => 'New Book', 'books_popular_empty' => 'The most popular books will appear here.', 'books_new_empty' => 'The most recently created books will appear here.', 'books_create' => 'Create New Book', diff --git a/resources/views/books/create.blade.php b/resources/views/books/create.blade.php index 9079a3bf9..882ce556a 100644 --- a/resources/views/books/create.blade.php +++ b/resources/views/books/create.blade.php @@ -3,21 +3,31 @@ @section('body')
- @include('partials.breadcrumbs', ['crumbs' => [ - '/books' => [ - 'text' => trans('entities.books'), - 'icon' => 'book' - ], - '/create-book' => [ - 'text' => trans('entities.books_create'), - 'icon' => 'add' - ] - ]]) + @if (isset($bookshelf)) + @include('partials.breadcrumbs', ['crumbs' => [ + $bookshelf, + $bookshelf->getUrl('/create-book') => [ + 'text' => trans('entities.books_create'), + 'icon' => 'add' + ] + ]]) + @else + @include('partials.breadcrumbs', ['crumbs' => [ + '/books' => [ + 'text' => trans('entities.books'), + 'icon' => 'book' + ], + '/create-book' => [ + 'text' => trans('entities.books_create'), + 'icon' => 'add' + ] + ]]) + @endif

{{ trans('entities.books_create') }}

-
+ @include('books.form')
diff --git a/resources/views/shelves/index.blade.php b/resources/views/shelves/index.blade.php index 76f26c694..8cf959b1e 100644 --- a/resources/views/shelves/index.blade.php +++ b/resources/views/shelves/index.blade.php @@ -12,7 +12,7 @@ @if($currentUser->can('bookshelf-create-all')) @icon('add') - {{ trans('entities.shelves_create') }} + {{ trans('entities.shelves_new_action') }} @endif @include('partials.view-toggle', ['view' => $view, 'type' => 'shelf']) diff --git a/resources/views/shelves/show.blade.php b/resources/views/shelves/show.blade.php index 0cfaebbd7..3a9d59951 100644 --- a/resources/views/shelves/show.blade.php +++ b/resources/views/shelves/show.blade.php @@ -23,6 +23,12 @@

{{ trans('entities.shelves_empty_contents') }}

+ @if(userCan('book-create-all') && userCan('bookshelf-update', $shelf)) + + @icon('add') + {{ trans('entities.books_create') }} + + @endif @if(userCan('bookshelf-update', $shelf)) @icon('edit') @@ -74,6 +80,15 @@
{{ trans('common.actions') }}
+ @if(userCan('book-create-all') && userCan('bookshelf-update', $shelf)) + + @icon('add') + {{ trans('entities.books_new_action') }} + + @endif + +
+ @if(userCan('bookshelf-update', $shelf)) @icon('edit') diff --git a/routes/web.php b/routes/web.php index 7c2c5917e..d1a8b7969 100644 --- a/routes/web.php +++ b/routes/web.php @@ -26,6 +26,9 @@ Route::group(['middleware' => 'auth'], function () { Route::get('/{slug}/permissions', 'BookshelfController@showPermissions'); Route::put('/{slug}/permissions', 'BookshelfController@permissions'); Route::post('/{slug}/copy-permissions', 'BookshelfController@copyPermissions'); + + Route::get('/{shelfSlug}/create-book', 'BookController@create'); + Route::post('/{shelfSlug}/create-book', 'BookController@store'); }); Route::get('/create-book', 'BookController@create'); diff --git a/tests/Entity/BookShelfTest.php b/tests/Entity/BookShelfTest.php index 0707fc5ff..158fb5ca1 100644 --- a/tests/Entity/BookShelfTest.php +++ b/tests/Entity/BookShelfTest.php @@ -48,7 +48,7 @@ class BookShelfTest extends TestCase public function test_shelves_page_contains_create_link() { $resp = $this->asEditor()->get('/shelves'); - $resp->assertElementContains('a', 'Create New Shelf'); + $resp->assertElementContains('a', 'New Shelf'); } public function test_shelves_create() @@ -99,9 +99,11 @@ class BookShelfTest extends TestCase { $shelf = Bookshelf::first(); $resp = $this->asAdmin()->get($shelf->getUrl()); + $resp->assertSee($shelf->getUrl('/create-book')); $resp->assertSee($shelf->getUrl('/edit')); $resp->assertSee($shelf->getUrl('/permissions')); $resp->assertSee($shelf->getUrl('/delete')); + $resp->assertElementContains('a', 'New Book'); $resp->assertElementContains('a', 'Edit'); $resp->assertElementContains('a', 'Permissions'); $resp->assertElementContains('a', 'Delete'); @@ -148,6 +150,32 @@ class BookShelfTest extends TestCase $this->assertDatabaseHas('bookshelves_books', ['bookshelf_id' => $shelf->id, 'book_id' => $booksToInclude[1]->id]); } + public function test_shelf_create_new_book() + { + $shelf = Bookshelf::first(); + $resp = $this->asEditor()->get($shelf->getUrl('/create-book')); + + $resp->assertSee('Create New Book'); + $resp->assertSee($shelf->getShortName()); + + $testName = 'Test Book in Shelf Name'; + + $createBookResp = $this->asEditor()->post($shelf->getUrl('/create-book'), [ + 'name' => $testName, + 'description' => 'Book in shelf description' + ]); + $createBookResp->assertRedirect(); + + $newBook = Book::query()->orderBy('id', 'desc')->first(); + $this->assertDatabaseHas('bookshelves_books', [ + 'bookshelf_id' => $shelf->id, + 'book_id' => $newBook->id, + ]); + + $resp = $this->asEditor()->get($shelf->getUrl()); + $resp->assertSee($testName); + } + public function test_shelf_delete() { $shelf = Bookshelf::first(); diff --git a/tests/Permissions/RolesTest.php b/tests/Permissions/RolesTest.php index 423db1bf0..5bbdcf0bb 100644 --- a/tests/Permissions/RolesTest.php +++ b/tests/Permissions/RolesTest.php @@ -215,7 +215,7 @@ class RolesTest extends BrowserKitTest $this->checkAccessPermission('bookshelf-create-all', [ '/create-shelf' ], [ - '/shelves' => 'Create New Shelf' + '/shelves' => 'New Shelf' ]); $this->visit('/create-shelf')