Infra-Mirrors/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2024-10-01 01:36:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

OIDC Userinfo: Labelled changes to be made during review

Browse Source
This commit is contained in:
Dan Brown 2024-04-16 15:52:55 +01:00
parent d640411adb
commit 9183e7f2fe
No known key found for this signature in database
GPG Key ID: 46D9F943C24A2EF9
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/Access/Oidc/OidcService.php
View File

@ -241,14 +241,23 @@ class OidcService
session()->put("oidc_id_token", $idTokenText); session()->put("oidc_id_token", $idTokenText);
// TODO - This should not affect id token validation
// TODO - Should only call if we're missing properties
if (!empty($settings->userinfoEndpoint)) { if (!empty($settings->userinfoEndpoint)) {
$provider = $this->getProvider($settings); $provider = $this->getProvider($settings);
$request = $provider->getAuthenticatedRequest('GET', $settings->userinfoEndpoint, $accessToken->getToken()); $request = $provider->getAuthenticatedRequest('GET', $settings->userinfoEndpoint, $accessToken->getToken());
$response = $provider->getParsedResponse($request); $response = $provider->getParsedResponse($request);
// TODO - Ensure response content-type is "application/json" before using in this way (5.3.2)
// TODO - The sub Claim in the UserInfo Response MUST be verified to exactly match the sub Claim in the ID Token; if they do not match, the UserInfo Response values MUST NOT be used. (5.3.2)
// TODO - Response validation (5.3.4)
// TODO - Verify that the OP that responded was the intended OP through a TLS server certificate check, per RFC 6125 [RFC6125].
// TODO - If the Client has provided a userinfo_encrypted_response_alg parameter during Registration, decrypt the UserInfo Response using the keys specified during Registration.
// TODO - If the response was signed, the Client SHOULD validate the signature according to JWS [JWS].
$claims = $idToken->getAllClaims(); $claims = $idToken->getAllClaims();
foreach ($response as $key => $value) { foreach ($response as $key => $value) {
$claims[$key] = $value; $claims[$key] = $value;
} }
// TODO - Should maybe remain separate from IdToken completely
$idToken->replaceClaims($claims); $idToken->replaceClaims($claims);
} }