From 70be28d22cb0067f70a53a74aa3a89722a3ebbd9 Mon Sep 17 00:00:00 2001 From: Dan Brown Date: Mon, 19 Apr 2021 22:00:33 +0100 Subject: [PATCH] Updated tinymce code block handling to help prevent breaking history states Only used an undo transaction on startup and added a small delay to codeMirror parsing on SetContent's to help avoid the rendering activities getting caught in undoManager states. Seemed to improve things a lot in Firefox & chrome on my dev machine. For #2602 --- resources/js/components/wysiwyg-editor.js | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/resources/js/components/wysiwyg-editor.js b/resources/js/components/wysiwyg-editor.js index a6ab54218..a44ab1c62 100644 --- a/resources/js/components/wysiwyg-editor.js +++ b/resources/js/components/wysiwyg-editor.js @@ -152,8 +152,8 @@ function codePlugin() { return; } - let lang = selectedNode.hasAttribute('data-lang') ? selectedNode.getAttribute('data-lang') : ''; - let currentCode = selectedNode.querySelector('textarea').textContent; + const lang = selectedNode.hasAttribute('data-lang') ? selectedNode.getAttribute('data-lang') : ''; + const currentCode = selectedNode.querySelector('textarea').textContent; window.components.first('code-editor').open(currentCode, lang, (code, lang) => { const editorElem = selectedNode.querySelector('.CodeMirror'); @@ -225,22 +225,23 @@ function codePlugin() { return elem.contentEditable !== "false"; }); - if (!codeSamples.length) return; - editor.undoManager.transact(function () { - codeSamples.each((index, elem) => { - Code.wysiwygView(elem); - }); + codeSamples.each((index, elem) => { + Code.wysiwygView(elem); }); } editor.on('init', function() { // Parse code mirror instances on init, but delay a little so this runs after // initial styles are fetched into the editor. - parseCodeMirrorInstances(); + editor.undoManager.transact(function () { + parseCodeMirrorInstances(); + }); // Parsed code mirror blocks when content is set but wait before setting this handler // to avoid any init 'SetContent' events. setTimeout(() => { - editor.on('SetContent', parseCodeMirrorInstances); + editor.on('SetContent', () => { + setTimeout(parseCodeMirrorInstances, 100); + }); }, 200); });