diff --git a/app/Http/Controllers/AttachmentController.php b/app/Http/Controllers/AttachmentController.php index 74eae641b..be20cda93 100644 --- a/app/Http/Controllers/AttachmentController.php +++ b/app/Http/Controllers/AttachmentController.php @@ -102,8 +102,8 @@ class AttachmentController extends Controller */ public function update(Request $request, string $attachmentId) { - $attachment = $this->attachment->newQuery()->findOrFail($attachmentId); - + /** @var Attachment $attachment */ + $attachment = Attachment::query()->findOrFail($attachmentId); try { $this->validate($request, [ 'attachment_edit_name' => 'required|string|min:1|max:255', @@ -158,7 +158,7 @@ class AttachmentController extends Controller $attachmentName = $request->get('attachment_link_name'); $link = $request->get('attachment_link_url'); - $attachment = $this->attachmentService->saveNewFromLink($attachmentName, $link, intval($pageId)); + $this->attachmentService->saveNewFromLink($attachmentName, $link, intval($pageId)); return view('attachments.manager-link-form', [ 'pageId' => $pageId, @@ -231,6 +231,7 @@ class AttachmentController extends Controller */ public function delete(string $attachmentId) { + /** @var Attachment $attachment */ $attachment = Attachment::query()->findOrFail($attachmentId); $this->checkOwnablePermission('attachment-delete', $attachment); $this->attachmentService->deleteFile($attachment); diff --git a/app/Uploads/Attachment.php b/app/Uploads/Attachment.php index 474d68998..383af9537 100644 --- a/app/Uploads/Attachment.php +++ b/app/Uploads/Attachment.php @@ -3,12 +3,14 @@ use BookStack\Entities\Models\Page; use BookStack\Model; use BookStack\Traits\HasCreatorAndUpdater; +use Illuminate\Database\Eloquent\Relations\BelongsTo; /** * @property int id * @property string name * @property string path * @property string extension + * @property ?Page page * @property bool external */ class Attachment extends Model @@ -31,9 +33,8 @@ class Attachment extends Model /** * Get the page this file was uploaded to. - * @return \Illuminate\Database\Eloquent\Relations\BelongsTo */ - public function page() + public function page(): BelongsTo { return $this->belongsTo(Page::class, 'uploaded_to'); }