2020-04-04 00:16:05 +00:00
|
|
|
<?php namespace Tests\Entity;
|
2016-04-15 18:51:27 +00:00
|
|
|
|
2020-11-22 00:17:45 +00:00
|
|
|
use BookStack\Entities\Models\Book;
|
|
|
|
use BookStack\Entities\Models\Chapter;
|
|
|
|
use BookStack\Entities\Models\Page;
|
2018-10-13 10:27:55 +00:00
|
|
|
use BookStack\Entities\Repos\PageRepo;
|
2020-04-04 00:16:05 +00:00
|
|
|
use Tests\TestCase;
|
2017-02-05 14:20:59 +00:00
|
|
|
|
|
|
|
class SortTest extends TestCase
|
2016-04-15 18:51:27 +00:00
|
|
|
{
|
|
|
|
protected $book;
|
|
|
|
|
2019-09-13 22:58:40 +00:00
|
|
|
public function setUp(): void
|
2016-04-15 18:51:27 +00:00
|
|
|
{
|
|
|
|
parent::setUp();
|
2018-04-14 17:00:16 +00:00
|
|
|
$this->book = Book::first();
|
2016-04-15 18:51:27 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
public function test_drafts_do_not_show_up()
|
|
|
|
{
|
|
|
|
$this->asAdmin();
|
2018-10-13 10:27:55 +00:00
|
|
|
$pageRepo = app(PageRepo::class);
|
2019-10-05 11:55:01 +00:00
|
|
|
$draft = $pageRepo->getNewDraftPage($this->book);
|
2016-04-15 18:51:27 +00:00
|
|
|
|
2017-02-05 14:20:59 +00:00
|
|
|
$resp = $this->get($this->book->getUrl());
|
|
|
|
$resp->assertSee($draft->name);
|
|
|
|
|
|
|
|
$resp = $this->get($this->book->getUrl() . '/sort');
|
|
|
|
$resp->assertDontSee($draft->name);
|
2016-04-15 18:51:27 +00:00
|
|
|
}
|
|
|
|
|
2019-10-29 22:25:53 +00:00
|
|
|
public function test_page_move_into_book()
|
2016-06-12 11:48:06 +00:00
|
|
|
{
|
2018-04-14 17:00:16 +00:00
|
|
|
$page = Page::first();
|
2016-06-12 11:48:06 +00:00
|
|
|
$currentBook = $page->book;
|
2018-04-14 17:00:16 +00:00
|
|
|
$newBook = Book::where('id', '!=', $currentBook->id)->first();
|
2016-06-12 11:48:06 +00:00
|
|
|
|
2018-04-14 17:47:13 +00:00
|
|
|
$resp = $this->asEditor()->get($page->getUrl('/move'));
|
2017-02-05 14:20:59 +00:00
|
|
|
$resp->assertSee('Move Page');
|
|
|
|
|
2018-04-14 17:47:13 +00:00
|
|
|
$movePageResp = $this->put($page->getUrl('/move'), [
|
2017-02-05 14:20:59 +00:00
|
|
|
'entity_selection' => 'book:' . $newBook->id
|
|
|
|
]);
|
2018-04-14 17:00:16 +00:00
|
|
|
$page = Page::find($page->id);
|
2017-02-05 14:20:59 +00:00
|
|
|
|
|
|
|
$movePageResp->assertRedirect($page->getUrl());
|
2016-06-12 11:48:06 +00:00
|
|
|
$this->assertTrue($page->book->id == $newBook->id, 'Page book is now the new book');
|
|
|
|
|
2017-02-05 14:20:59 +00:00
|
|
|
$newBookResp = $this->get($newBook->getUrl());
|
|
|
|
$newBookResp->assertSee('moved page');
|
|
|
|
$newBookResp->assertSee($page->name);
|
2016-06-12 11:48:06 +00:00
|
|
|
}
|
|
|
|
|
2019-10-29 22:25:53 +00:00
|
|
|
public function test_page_move_into_chapter()
|
|
|
|
{
|
|
|
|
$page = Page::first();
|
|
|
|
$currentBook = $page->book;
|
|
|
|
$newBook = Book::where('id', '!=', $currentBook->id)->first();
|
|
|
|
$newChapter = $newBook->chapters()->first();
|
|
|
|
|
|
|
|
$movePageResp = $this->actingAs($this->getEditor())->put($page->getUrl('/move'), [
|
|
|
|
'entity_selection' => 'chapter:' . $newChapter->id
|
|
|
|
]);
|
|
|
|
$page = Page::find($page->id);
|
|
|
|
|
|
|
|
$movePageResp->assertRedirect($page->getUrl());
|
|
|
|
$this->assertTrue($page->book->id == $newBook->id, 'Page parent is now the new chapter');
|
|
|
|
|
|
|
|
$newChapterResp = $this->get($newChapter->getUrl());
|
|
|
|
$newChapterResp->assertSee($page->name);
|
|
|
|
}
|
|
|
|
|
2019-10-29 22:33:09 +00:00
|
|
|
public function test_page_move_from_chapter_to_book()
|
|
|
|
{
|
|
|
|
$oldChapter = Chapter::first();
|
|
|
|
$page = $oldChapter->pages()->first();
|
|
|
|
$newBook = Book::where('id', '!=', $oldChapter->book_id)->first();
|
|
|
|
|
|
|
|
$movePageResp = $this->actingAs($this->getEditor())->put($page->getUrl('/move'), [
|
|
|
|
'entity_selection' => 'book:' . $newBook->id
|
|
|
|
]);
|
2020-11-08 00:03:19 +00:00
|
|
|
$page->refresh();
|
2019-10-29 22:33:09 +00:00
|
|
|
|
|
|
|
$movePageResp->assertRedirect($page->getUrl());
|
|
|
|
$this->assertTrue($page->book->id == $newBook->id, 'Page parent is now the new book');
|
|
|
|
$this->assertTrue($page->chapter === null, 'Page has no parent chapter');
|
|
|
|
|
|
|
|
$newBookResp = $this->get($newBook->getUrl());
|
|
|
|
$newBookResp->assertSee($page->name);
|
|
|
|
}
|
|
|
|
|
2018-04-14 17:47:13 +00:00
|
|
|
public function test_page_move_requires_create_permissions_on_parent()
|
|
|
|
{
|
|
|
|
$page = Page::first();
|
|
|
|
$currentBook = $page->book;
|
|
|
|
$newBook = Book::where('id', '!=', $currentBook->id)->first();
|
|
|
|
$editor = $this->getEditor();
|
|
|
|
|
2019-01-05 14:39:40 +00:00
|
|
|
$this->setEntityRestrictions($newBook, ['view', 'update', 'delete'], $editor->roles);
|
2018-04-14 17:47:13 +00:00
|
|
|
|
|
|
|
$movePageResp = $this->actingAs($editor)->put($page->getUrl('/move'), [
|
|
|
|
'entity_selection' => 'book:' . $newBook->id
|
|
|
|
]);
|
|
|
|
$this->assertPermissionError($movePageResp);
|
|
|
|
|
2019-01-05 14:39:40 +00:00
|
|
|
$this->setEntityRestrictions($newBook, ['view', 'update', 'delete', 'create'], $editor->roles);
|
2018-04-14 17:47:13 +00:00
|
|
|
$movePageResp = $this->put($page->getUrl('/move'), [
|
|
|
|
'entity_selection' => 'book:' . $newBook->id
|
|
|
|
]);
|
|
|
|
|
|
|
|
$page = Page::find($page->id);
|
|
|
|
$movePageResp->assertRedirect($page->getUrl());
|
|
|
|
|
|
|
|
$this->assertTrue($page->book->id == $newBook->id, 'Page book is now the new book');
|
|
|
|
}
|
|
|
|
|
2019-01-05 14:39:40 +00:00
|
|
|
public function test_page_move_requires_delete_permissions()
|
|
|
|
{
|
|
|
|
$page = Page::first();
|
|
|
|
$currentBook = $page->book;
|
|
|
|
$newBook = Book::where('id', '!=', $currentBook->id)->first();
|
|
|
|
$editor = $this->getEditor();
|
|
|
|
|
|
|
|
$this->setEntityRestrictions($newBook, ['view', 'update', 'create', 'delete'], $editor->roles);
|
|
|
|
$this->setEntityRestrictions($page, ['view', 'update', 'create'], $editor->roles);
|
|
|
|
|
|
|
|
$movePageResp = $this->actingAs($editor)->put($page->getUrl('/move'), [
|
|
|
|
'entity_selection' => 'book:' . $newBook->id
|
|
|
|
]);
|
|
|
|
$this->assertPermissionError($movePageResp);
|
|
|
|
$pageView = $this->get($page->getUrl());
|
|
|
|
$pageView->assertDontSee($page->getUrl('/move'));
|
|
|
|
|
|
|
|
$this->setEntityRestrictions($page, ['view', 'update', 'create', 'delete'], $editor->roles);
|
|
|
|
$movePageResp = $this->put($page->getUrl('/move'), [
|
|
|
|
'entity_selection' => 'book:' . $newBook->id
|
|
|
|
]);
|
|
|
|
|
|
|
|
$page = Page::find($page->id);
|
|
|
|
$movePageResp->assertRedirect($page->getUrl());
|
|
|
|
$this->assertTrue($page->book->id == $newBook->id, 'Page book is now the new book');
|
|
|
|
}
|
|
|
|
|
2016-06-25 14:31:38 +00:00
|
|
|
public function test_chapter_move()
|
|
|
|
{
|
2018-04-14 17:00:16 +00:00
|
|
|
$chapter = Chapter::first();
|
2016-06-25 14:31:38 +00:00
|
|
|
$currentBook = $chapter->book;
|
|
|
|
$pageToCheck = $chapter->pages->first();
|
2018-04-14 17:00:16 +00:00
|
|
|
$newBook = Book::where('id', '!=', $currentBook->id)->first();
|
2016-06-25 14:31:38 +00:00
|
|
|
|
2018-04-14 17:47:13 +00:00
|
|
|
$chapterMoveResp = $this->asEditor()->get($chapter->getUrl('/move'));
|
2017-02-05 14:20:59 +00:00
|
|
|
$chapterMoveResp->assertSee('Move Chapter');
|
|
|
|
|
2018-04-14 17:47:13 +00:00
|
|
|
$moveChapterResp = $this->put($chapter->getUrl('/move'), [
|
2017-02-05 14:20:59 +00:00
|
|
|
'entity_selection' => 'book:' . $newBook->id
|
|
|
|
]);
|
2016-06-25 14:31:38 +00:00
|
|
|
|
2018-04-14 17:00:16 +00:00
|
|
|
$chapter = Chapter::find($chapter->id);
|
2017-02-05 14:20:59 +00:00
|
|
|
$moveChapterResp->assertRedirect($chapter->getUrl());
|
2016-06-25 14:31:38 +00:00
|
|
|
$this->assertTrue($chapter->book->id === $newBook->id, 'Chapter Book is now the new book');
|
|
|
|
|
2017-02-05 14:20:59 +00:00
|
|
|
$newBookResp = $this->get($newBook->getUrl());
|
|
|
|
$newBookResp->assertSee('moved chapter');
|
|
|
|
$newBookResp->assertSee($chapter->name);
|
2016-06-25 14:31:38 +00:00
|
|
|
|
2018-04-14 17:00:16 +00:00
|
|
|
$pageToCheck = Page::find($pageToCheck->id);
|
2016-06-25 14:31:38 +00:00
|
|
|
$this->assertTrue($pageToCheck->book_id === $newBook->id, 'Chapter child page\'s book id has changed to the new book');
|
2017-02-05 14:20:59 +00:00
|
|
|
$pageCheckResp = $this->get($pageToCheck->getUrl());
|
|
|
|
$pageCheckResp->assertSee($newBook->name);
|
|
|
|
}
|
|
|
|
|
2019-01-05 14:39:40 +00:00
|
|
|
public function test_chapter_move_requires_delete_permissions()
|
|
|
|
{
|
|
|
|
$chapter = Chapter::first();
|
|
|
|
$currentBook = $chapter->book;
|
|
|
|
$newBook = Book::where('id', '!=', $currentBook->id)->first();
|
|
|
|
$editor = $this->getEditor();
|
|
|
|
|
|
|
|
$this->setEntityRestrictions($newBook, ['view', 'update', 'create', 'delete'], $editor->roles);
|
|
|
|
$this->setEntityRestrictions($chapter, ['view', 'update', 'create'], $editor->roles);
|
|
|
|
|
|
|
|
$moveChapterResp = $this->actingAs($editor)->put($chapter->getUrl('/move'), [
|
|
|
|
'entity_selection' => 'book:' . $newBook->id
|
|
|
|
]);
|
|
|
|
$this->assertPermissionError($moveChapterResp);
|
|
|
|
$pageView = $this->get($chapter->getUrl());
|
|
|
|
$pageView->assertDontSee($chapter->getUrl('/move'));
|
|
|
|
|
|
|
|
$this->setEntityRestrictions($chapter, ['view', 'update', 'create', 'delete'], $editor->roles);
|
|
|
|
$moveChapterResp = $this->put($chapter->getUrl('/move'), [
|
|
|
|
'entity_selection' => 'book:' . $newBook->id
|
|
|
|
]);
|
|
|
|
|
|
|
|
$chapter = Chapter::find($chapter->id);
|
|
|
|
$moveChapterResp->assertRedirect($chapter->getUrl());
|
|
|
|
$this->assertTrue($chapter->book->id == $newBook->id, 'Page book is now the new book');
|
|
|
|
}
|
|
|
|
|
2017-02-05 14:20:59 +00:00
|
|
|
public function test_book_sort()
|
|
|
|
{
|
|
|
|
$oldBook = Book::query()->first();
|
|
|
|
$chapterToMove = $this->newChapter(['name' => 'chapter to move'], $oldBook);
|
|
|
|
$newBook = $this->newBook(['name' => 'New sort book']);
|
|
|
|
$pagesToMove = Page::query()->take(5)->get();
|
|
|
|
|
|
|
|
// Create request data
|
|
|
|
$reqData = [
|
|
|
|
[
|
|
|
|
'id' => $chapterToMove->id,
|
|
|
|
'sort' => 0,
|
|
|
|
'parentChapter' => false,
|
|
|
|
'type' => 'chapter',
|
|
|
|
'book' => $newBook->id
|
|
|
|
]
|
|
|
|
];
|
|
|
|
foreach ($pagesToMove as $index => $page) {
|
|
|
|
$reqData[] = [
|
|
|
|
'id' => $page->id,
|
|
|
|
'sort' => $index,
|
|
|
|
'parentChapter' => $index === count($pagesToMove) - 1 ? $chapterToMove->id : false,
|
|
|
|
'type' => 'page',
|
|
|
|
'book' => $newBook->id
|
|
|
|
];
|
|
|
|
}
|
|
|
|
|
2018-04-14 17:47:13 +00:00
|
|
|
$sortResp = $this->asEditor()->put($newBook->getUrl() . '/sort', ['sort-tree' => json_encode($reqData)]);
|
2017-02-05 14:20:59 +00:00
|
|
|
$sortResp->assertRedirect($newBook->getUrl());
|
|
|
|
$sortResp->assertStatus(302);
|
|
|
|
$this->assertDatabaseHas('chapters', [
|
|
|
|
'id' => $chapterToMove->id,
|
|
|
|
'book_id' => $newBook->id,
|
|
|
|
'priority' => 0
|
|
|
|
]);
|
|
|
|
$this->assertTrue($newBook->chapters()->count() === 1);
|
|
|
|
$this->assertTrue($newBook->chapters()->first()->pages()->count() === 1);
|
|
|
|
|
|
|
|
$checkPage = $pagesToMove[1];
|
|
|
|
$checkResp = $this->get(Page::find($checkPage->id)->getUrl());
|
|
|
|
$checkResp->assertSee($newBook->name);
|
2016-06-25 14:31:38 +00:00
|
|
|
}
|
|
|
|
|
2018-04-14 17:00:16 +00:00
|
|
|
public function test_page_copy()
|
|
|
|
{
|
|
|
|
$page = Page::first();
|
|
|
|
$currentBook = $page->book;
|
|
|
|
$newBook = Book::where('id', '!=', $currentBook->id)->first();
|
|
|
|
|
|
|
|
$resp = $this->asEditor()->get($page->getUrl('/copy'));
|
|
|
|
$resp->assertSee('Copy Page');
|
|
|
|
|
|
|
|
$movePageResp = $this->post($page->getUrl('/copy'), [
|
|
|
|
'entity_selection' => 'book:' . $newBook->id,
|
|
|
|
'name' => 'My copied test page'
|
|
|
|
]);
|
|
|
|
$pageCopy = Page::where('name', '=', 'My copied test page')->first();
|
|
|
|
|
|
|
|
$movePageResp->assertRedirect($pageCopy->getUrl());
|
|
|
|
$this->assertTrue($pageCopy->book->id == $newBook->id, 'Page was copied to correct book');
|
|
|
|
}
|
|
|
|
|
|
|
|
public function test_page_copy_with_no_destination()
|
|
|
|
{
|
|
|
|
$page = Page::first();
|
|
|
|
$currentBook = $page->book;
|
|
|
|
|
|
|
|
$resp = $this->asEditor()->get($page->getUrl('/copy'));
|
|
|
|
$resp->assertSee('Copy Page');
|
|
|
|
|
|
|
|
$movePageResp = $this->post($page->getUrl('/copy'), [
|
|
|
|
'name' => 'My copied test page'
|
|
|
|
]);
|
|
|
|
|
|
|
|
$pageCopy = Page::where('name', '=', 'My copied test page')->first();
|
|
|
|
|
|
|
|
$movePageResp->assertRedirect($pageCopy->getUrl());
|
|
|
|
$this->assertTrue($pageCopy->book->id == $currentBook->id, 'Page was copied to correct book');
|
|
|
|
$this->assertTrue($pageCopy->id !== $page->id, 'Page copy is not the same instance');
|
|
|
|
}
|
|
|
|
|
2019-03-09 16:50:22 +00:00
|
|
|
public function test_page_can_be_copied_without_edit_permission()
|
|
|
|
{
|
|
|
|
$page = Page::first();
|
|
|
|
$currentBook = $page->book;
|
|
|
|
$newBook = Book::where('id', '!=', $currentBook->id)->first();
|
|
|
|
$viewer = $this->getViewer();
|
|
|
|
|
|
|
|
$resp = $this->actingAs($viewer)->get($page->getUrl());
|
|
|
|
$resp->assertDontSee($page->getUrl('/copy'));
|
|
|
|
|
|
|
|
$newBook->created_by = $viewer->id;
|
|
|
|
$newBook->save();
|
|
|
|
$this->giveUserPermissions($viewer, ['page-create-own']);
|
|
|
|
$this->regenEntityPermissions($newBook);
|
|
|
|
|
|
|
|
$resp = $this->actingAs($viewer)->get($page->getUrl());
|
|
|
|
$resp->assertSee($page->getUrl('/copy'));
|
|
|
|
|
|
|
|
$movePageResp = $this->post($page->getUrl('/copy'), [
|
|
|
|
'entity_selection' => 'book:' . $newBook->id,
|
|
|
|
'name' => 'My copied test page'
|
|
|
|
]);
|
|
|
|
$movePageResp->assertRedirect();
|
|
|
|
|
|
|
|
$this->assertDatabaseHas('pages', [
|
|
|
|
'name' => 'My copied test page',
|
|
|
|
'created_by' => $viewer->id,
|
|
|
|
'book_id' => $newBook->id,
|
|
|
|
]);
|
|
|
|
}
|
|
|
|
|
2016-04-15 18:51:27 +00:00
|
|
|
}
|