mirror of
https://github.com/comit-network/xmr-btc-swap.git
synced 2024-10-01 01:45:40 -04:00
4344554730
894: Reduce `bitcoin_finality_confirmations` from 2 to 1 r=binarybaron a=binarybaron Reduces `bitcoin_finality_confirmations` from 2 to 1. This lowers the total time needed for a swap by an average of 10 minutes I'm aware that this has been proposed before (https://github.com/comit-network/xmr-btc-swap/pull/800) and was rejected. > On the ASB, the bitcoin finality confirmations can be set to 1 using the config file. This will get you the swap reduction time you desire. I believe this is not correct. There is no way for ASB operators to configure the `bitcoin_finality_confirmations` setting. Only the `target_block` can be configured manually, but this is only used for estimating the fee rate when a btc transaction is published and not for deciding when it is safe to assume that the transaction is finalized. E.g the `config.toml` file of my (testate) asb ``` [data] dir = "/root/.local/share/xmr-btc-swap/asb/testnet" [network] listen = ["/ip4/0.0.0.0/tcp/9939", "/ip4/0.0.0.0/tcp/9940/ws"] external_addresses = ["/dnsaddr/unstoppableswap.net"] rendezvous_point = "/dnsaddr/discover.unstoppableswap.net/p2p/12D3KooWA6cnqJpVnreBVnoro8midDL9Lpzmg8oJPoAGi7YYaamE" [bitcoin] electrum_rpc_url = "ssl://electrum.blockstream.info:60002" target_block = 1 # My asb still waits for 2 confirmations on the btc lock tx network = "Testnet" [monero] wallet_rpc_url = "http://127.0.0.1:38083/json_rpc" network = "Stagenet" [tor] control_port = 9051 socks5_port = 9050 [maker] min_buy_btc = 0.0001 max_buy_btc = 0.1 ask_spread = 0.00 price_ticker_ws_url = "wss://ws.kraken.com" ``` Co-authored-by: binarybaron <you@domain.com> |
||
|---|---|---|
| .. | ||
| migrations | ||
| proptest-regressions/bitcoin | ||
| src | ||
| tests | ||
| build.rs | ||
| Cargo.toml | ||
| sqlite_dev_setup.sh | ||
| sqlx-data.json | ||