Git-Mirrors/xmr-btc-swap
1
0
Fork 0
mirror of https://github.com/comit-network/xmr-btc-swap.git synced 2025-12-16 17:14:13 -05:00
Code Issues Projects Releases Packages Wiki Activity

fix(CI): request libwebkit2gtk=2.44.0-2 to fix AppImages on Fedora ~43 (#674)

Browse source 
The CI builds the GUI on ubuntu noble, which contains
  2.44.0-2
in universe and
  2.48.7-0ubuntu0.24.04.2
in security. Naturally, the bigger version is picked by default.

The same thing happens when building on bookworm (2.48.1-2~deb12u1).

This version causes the GUI to crash just after creating a blank window,
yielding no logs and stderr of
  Could not create default EGL display: EGL_BAD_PARAMETER. Aborting...

This is a known issue in the Tauri/AppImage world,
and downgrading to 2.44 is likewise a known fix, cf.
  https://github.com/gitbutlerapp/gitbutler/issues/5282
and all the referencing issues.

On bookworm this can be fixed by installing 2.44.3-1
off snapshot.d.o at 20240909T145608Z.

On noble, we can just ask for the older version, since both are visible.

Only pin on noble: we only ever request noble,
but some third-party workflows are on jammy.
The version doesn't matter there.

Closes #594
Closes #582
This commit is contained in:
наб 2025-11-04 20:08:14 +01:00 • committed by GitHub
parent c2dff5c07f
commit a056ae3a47
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
.github/actions/set-monero-env/action.yml vendored
View file

@ -8,7 +8,8 @@ runs:
run: | run: |
# GUI-specific Ubuntu dependencies # GUI-specific Ubuntu dependencies
echo "DEPS_GUI_UBUNTU_SPECIFIC=libgtk-3-dev libappindicator3-dev librsvg2-dev libwebkit2gtk-4.1-0 libwebkit2gtk-4.1-dev libjavascriptcoregtk-4.1-0 libjavascriptcoregtk-4.1-dev gir1.2-javascriptcoregtk-4.1 gir1.2-webkit2-4.1" >> $GITHUB_ENV grep -q noble /etc/os-release && pin==2.44.0-2 || pin=
echo "DEPS_GUI_UBUNTU_SPECIFIC=libgtk-3-dev libappindicator3-dev librsvg2-dev" {libwebkit2gtk-4.1-0,libwebkit2gtk-4.1-dev,libjavascriptcoregtk-4.1-0,libjavascriptcoregtk-4.1-dev,gir1.2-javascriptcoregtk-4.1,gir1.2-webkit2-4.1}"$pin" >> $GITHUB_ENV
# Build tooling (Linux) # Build tooling (Linux)
echo "DEPS_BUILD_LINUX=autoconf nsis mingw-w64 build-essential pkg-config libtool ccache make cmake gcc g++ git curl lbzip2 gperf g++-mingw-w64-x86-64" >> $GITHUB_ENV echo "DEPS_BUILD_LINUX=autoconf nsis mingw-w64 build-essential pkg-config libtool ccache make cmake gcc g++ git curl lbzip2 gperf g++-mingw-w64-x86-64" >> $GITHUB_ENV
@ -28,4 +29,4 @@ runs:
- name: Crabnebula identifier - name: Crabnebula identifier
shell: bash shell: bash
run: | run: |
echo "CN_APPLICATION=unstoppableswap/unstoppableswap-gui-rs" >> $GITHUB_ENV echo "CN_APPLICATION=unstoppableswap/unstoppableswap-gui-rs" >> $GITHUB_ENV