From 799eb15411a0ee27a9ee4c14db7b00690332e7ef Mon Sep 17 00:00:00 2001
From: Einliterflasche <81313171+Einliterflasche@users.noreply.github.com>
Date: Tue, 7 Jan 2025 12:15:43 +0100
Subject: [PATCH] GUI: warn against replace-by-fee for deposit transactions
 (#243)

* add alert in deposit page to warn against replace-by-fee
---
 .../modal/swap/DepositAddressInfoBox.tsx      |  1 +
 .../init/WaitingForBitcoinDepositPage.tsx     | 31 ++++++++++++-------
 2 files changed, 21 insertions(+), 11 deletions(-)

diff --git a/src-gui/src/renderer/components/modal/swap/DepositAddressInfoBox.tsx b/src-gui/src/renderer/components/modal/swap/DepositAddressInfoBox.tsx
index c228e33f..76959a4b 100644
--- a/src-gui/src/renderer/components/modal/swap/DepositAddressInfoBox.tsx
+++ b/src-gui/src/renderer/components/modal/swap/DepositAddressInfoBox.tsx
@@ -2,6 +2,7 @@ import { Box } from "@material-ui/core";
 import { ReactNode } from "react";
 import ActionableMonospaceTextBox from "renderer/components/other/ActionableMonospaceTextBox";
 import InfoBox from "./InfoBox";
+import { Alert } from "@material-ui/lab";
 
 type Props = {
   title: string;
diff --git a/src-gui/src/renderer/components/modal/swap/pages/init/WaitingForBitcoinDepositPage.tsx b/src-gui/src/renderer/components/modal/swap/pages/init/WaitingForBitcoinDepositPage.tsx
index d7146bf9..f6bc169e 100644
--- a/src-gui/src/renderer/components/modal/swap/pages/init/WaitingForBitcoinDepositPage.tsx
+++ b/src-gui/src/renderer/components/modal/swap/pages/init/WaitingForBitcoinDepositPage.tsx
@@ -5,6 +5,7 @@ import BitcoinIcon from "../../../../icons/BitcoinIcon";
 import { MoneroSatsExchangeRate, SatsAmount } from "../../../../other/Units";
 import DepositAddressInfoBox from "../../DepositAddressInfoBox";
 import DepositAmountHelper from "./DepositAmountHelper";
+import { Alert } from "@material-ui/lab";
 
 const useStyles = makeStyles((theme) => ({
   amountHelper: {
@@ -67,20 +68,28 @@ export default function WaitingForBtcDepositPage({
                 </li>
                 <li>
                   The swap will start automatically as soon as the minimum
-                  amount is deposited
+                  amount is deposited.
+                </li>
+                <li>
+                  <DepositAmountHelper
+                    min_deposit_until_swap_will_start={
+                      min_deposit_until_swap_will_start
+                    }
+                    max_deposit_until_maximum_amount_is_reached={
+                      max_deposit_until_maximum_amount_is_reached
+                    }
+                    min_bitcoin_lock_tx_fee={min_bitcoin_lock_tx_fee}
+                    quote={quote}
+                  />
                 </li>
               </ul>
             </Typography>
-            <DepositAmountHelper
-              min_deposit_until_swap_will_start={
-                min_deposit_until_swap_will_start
-              }
-              max_deposit_until_maximum_amount_is_reached={
-                max_deposit_until_maximum_amount_is_reached
-              }
-              min_bitcoin_lock_tx_fee={min_bitcoin_lock_tx_fee}
-              quote={quote}
-            />
+
+            <Alert severity="info">
+              Please do not use replace-by-fee on your deposit transaction.
+              You'll need to start a new swap if you do.
+              The funds will be available for future swaps.
+            </Alert>
           </Box>
         }
         icon={<BitcoinIcon />}