From e957cbd9092009c78724efe6d7703c0bbc680f01 Mon Sep 17 00:00:00 2001 From: Thomas Eizinger Date: Thu, 15 Apr 2021 10:15:11 +1000 Subject: [PATCH 1/3] Rewrite changelog entry as fix rather than a change --- CHANGELOG.md | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ad64451d..7892bbe7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,11 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] -### Changed +### Fixed -- Allow multiple concurrent swaps with the same peer on the ASB. - This is a breaking change because the swap ID is now agreed upon between CLI and ASB during swap setup. - Resuming swaps started prior to this change can result in unexpected behaviour. +- An issue where concurrent swaps with the same peer would cause the ASB to handle network communication incorrectly. + To fix this, all messages are now tagged with a unique identifier that is agreed upon at the start of the swap. + This is a breaking change in the network layer and hence old versions are not compatible with this version. + We advise to also not resume any swaps that have been created with an older version. + It is recommended to reset / delete the database after upgrading. - Quote protocol returns JSON encoded data instead of CBOR. This is a breaking change in the protocol handling, old CLI versions will not be able to process quote requests of ASBs running this version. From d1bc7e8fc25a61447826d6f6d40f8ef9e3c9a310 Mon Sep 17 00:00:00 2001 From: Thomas Eizinger Date: Thu, 15 Apr 2021 10:16:34 +1000 Subject: [PATCH 2/3] Add changelog entry for redial fix --- CHANGELOG.md | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7892bbe7..91f1c934 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Changed + +- Quote protocol returns JSON encoded data instead of CBOR. + This is a breaking change in the protocol handling, old CLI versions will not be able to process quote requests of ASBs running this version. + ### Fixed - An issue where concurrent swaps with the same peer would cause the ASB to handle network communication incorrectly. @@ -14,8 +19,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 This is a breaking change in the network layer and hence old versions are not compatible with this version. We advise to also not resume any swaps that have been created with an older version. It is recommended to reset / delete the database after upgrading. -- Quote protocol returns JSON encoded data instead of CBOR. - This is a breaking change in the protocol handling, old CLI versions will not be able to process quote requests of ASBs running this version. +- An issue where the CLI would not reconnect to the ASB in case the network connection dropped. + We now attempt to re-establish the connection using an exponential backoff but will give up eventually after 5 minutes. ### Added From a1144605204c9106d3e66d3376b30b39651290e3 Mon Sep 17 00:00:00 2001 From: Daniel Karzel Date: Sat, 17 Apr 2021 16:51:41 +1000 Subject: [PATCH 3/3] Better wording --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 91f1c934..a70149d7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed -- Quote protocol returns JSON encoded data instead of CBOR. +- The quote protocol returns JSON encoded data instead of CBOR. This is a breaking change in the protocol handling, old CLI versions will not be able to process quote requests of ASBs running this version. ### Fixed