Replace get_swap_start_date, get_seller, get_expired_timelock with one get_swap_info rpc method

swap/src/api/request.rs

@@ -5,6 +5,7 @@ use crate::libp2p_ext::MultiAddrExt;
 use crate::network::quote::{BidQuote, ZeroQuoteReceived};
 use crate::network::swarm;
 use crate::protocol::bob;
+use crate::protocol::bob::swap::is_complete;
 use crate::protocol::bob::{BobState, Swap};
 use crate::{bitcoin, cli, monero, rpc};
 use anyhow::{bail, Context as AnyContext, Result};
@@ -16,13 +17,13 @@ use std::cmp::min;
 use std::convert::TryInto;
 use std::future::Future;
 use std::net::SocketAddr;
-use std::sync::{Arc};
+use std::sync::Arc;
 use std::time::Duration;
 use structopt::lazy_static::lazy_static;
 use tokio::sync::broadcast::Receiver;
+use tokio::sync::RwLock;
 use tracing::{debug_span, Instrument};
 use uuid::Uuid;
-use tokio::sync::RwLock;
 
 lazy_static! {
     static ref SWAP_LOCK: RwLock<Option<Uuid>> = RwLock::new(None);
@@ -92,12 +93,6 @@ pub enum Method {
         address: bitcoin::Address,
     },
     Balance,
-    GetSeller {
-        swap_id: Uuid,
-    },
-    SwapStartDate {
-        swap_id: Uuid,
-    },
     Resume {
         swap_id: Uuid,
     },
@@ -115,7 +110,7 @@ pub enum Method {
         server_address: Option<SocketAddr>,
     },
     GetCurrentSwap,
-    GetSwapExpiredTimelock {
+    GetSwapInfo {
         swap_id: Uuid,
     },
 }
@@ -139,7 +134,73 @@ impl Request {
 
     async fn handle_cmd(mut self, context: Arc<Context>) -> Result<serde_json::Value> {
         match self.cmd {
-            Method::BuyXmr { seller, bitcoin_change_address, monero_receive_address, swap_id } => {
+            Method::GetSwapInfo { swap_id } => {
+                let bitcoin_wallet = context
+                    .bitcoin_wallet
+                    .as_ref()
+                    .context("Could not get Bitcoin wallet")?;
+
+                let swap_state: BobState = context.db.get_state(swap_id).await?.try_into()?;
+
+                let peerId = context
+                    .db
+                    .get_peer_id(swap_id)
+                    .await
+                    .with_context(|| "Could not get PeerID")?;
+
+                let addresses = context
+                    .db
+                    .get_addresses(peerId)
+                    .await
+                    .with_context(|| "Could not get addressess")?;
+
+                let is_completed = is_complete(&swap_state);
+
+                let start_date = context.db.get_swap_start_date(swap_id).await?;
+
+                let state_name = format!("{:?}", swap_state);
+
+                // variable timelock: Option<Result<ExpiredTimelocks>>
+                let timelock = match swap_state {
+                    BobState::Started { .. }
+                    | BobState::SafelyAborted
+                    | BobState::SwapSetupCompleted(_) => None,
+                    BobState::BtcLocked { state3: state, .. }
+                    | BobState::XmrLockProofReceived { state, .. } => {
+                        Some(state.expired_timelock(bitcoin_wallet).await)
+                    }
+                    BobState::XmrLocked(state) | BobState::EncSigSent(state) => {
+                        Some(state.expired_timelock(bitcoin_wallet).await)
+                    }
+                    BobState::CancelTimelockExpired(state) | BobState::BtcCancelled(state) => {
+                        Some(state.expired_timelock(bitcoin_wallet).await)
+                    }
+                    BobState::BtcPunished { .. } => Some(Ok(ExpiredTimelocks::Punish)),
+                    // swap is already finished
+                    BobState::BtcRefunded(_)
+                    | BobState::BtcRedeemed(_)
+                    | BobState::XmrRedeemed { .. } => None,
+                };
+
+                // Add txids
+                Ok(json!({
+                    "seller": {
+                        "peerId": peerId.to_string(),
+                        "addresses": addresses
+                    },
+                    "completed": is_completed,
+                    "startDate": start_date,
+                    // If none return null, if some unwrap and return as json
+                    "timelock": timelock.map(|tl| tl.map(|tl| json!(tl)).unwrap_or(json!(null))).unwrap_or(json!(null)),
+                    "stateName": state_name,
+                }))
+            }
+            Method::BuyXmr {
+                seller,
+                bitcoin_change_address,
+                monero_receive_address,
+                swap_id,
+            } => {
                 let seed = context.config.seed.as_ref().context("Could not get seed")?;
                 let env_config = context.config.env_config;
                 let btc = context
@@ -255,31 +316,6 @@ impl Request {
                 let raw_history = context.db.raw_all().await?;
                 Ok(json!({ "raw_history": raw_history }))
             }
-            Method::GetSeller { swap_id }  => {
-                let peerId = context
-                    .db
-                    .get_peer_id(swap_id)
-                    .await
-                    .with_context(|| "Could not get PeerID")?;
-
-                let addresses = context
-                    .db
-                    .get_addresses(peerId)
-                    .await
-                    .with_context(|| "Could not get addressess")?;
-
-                Ok(json!({
-                    "peerId": peerId.to_base58(),
-                    "addresses": addresses
-                }))
-            }
-            Method::SwapStartDate { swap_id } => {
-                let start_date = context.db.get_swap_start_date(swap_id).await?;
-
-                Ok(json!({
-                    "start_date": start_date,
-                }))
-            }
             Method::Config => {
                 let data_dir_display = context.config.data_dir.display();
                 tracing::info!(path=%data_dir_display, "Data directory");
@@ -297,7 +333,7 @@ impl Request {
                     "bitcoin_wallet": format!("{}/wallet", data_dir_display),
                 }))
             }
-            Method::WithdrawBtc {address, amount} => {
+            Method::WithdrawBtc { address, amount } => {
                 let bitcoin_wallet = context
                     .bitcoin_wallet
                     .as_ref()
@@ -326,7 +362,7 @@ impl Request {
                     "txid": signed_tx.txid(),
                 }))
             }
-            Method::StartDaemon {server_address} => {
+            Method::StartDaemon { server_address } => {
                 // Default to 127.0.0.1:1234
                 let server_address = server_address.unwrap_or("127.0.0.1:1234".parse().unwrap());
 
@@ -361,7 +397,7 @@ impl Request {
                     "balance": bitcoin_balance.to_sat()
                 }))
             }
-            Method::Resume {swap_id} => {
+            Method::Resume { swap_id } => {
                 let seller_peer_id = context.db.get_peer_id(swap_id).await?;
                 let seller_addresses = context.db.get_addresses(seller_peer_id).await?;
 
@@ -440,7 +476,7 @@ impl Request {
                     "result": []
                 }))
             }
-            Method::CancelAndRefund {swap_id} => {
+            Method::CancelAndRefund { swap_id } => {
                 let bitcoin_wallet = context
                     .bitcoin_wallet
                     .as_ref()
@@ -457,7 +493,7 @@ impl Request {
                     "result": state,
                 }))
             }
-            Method::ListSellers {rendezvous_point} => {
+            Method::ListSellers { rendezvous_point } => {
                 let rendezvous_node_peer_id = rendezvous_point
                     .extract_peer_id()
                     .context("Rendezvous node address must contain peer ID")?;
@@ -517,14 +553,8 @@ impl Request {
                     "descriptor": wallet_export.to_string(),
                 }))
             }
-            Method::MoneroRecovery {swap_id} => {
+            Method::MoneroRecovery { swap_id } => {
-                let swap_state: BobState = context
+                let swap_state: BobState = context.db.get_state(swap_id).await?.try_into()?;
-                    .db
-                    .get_state(
-                        swap_id,
-                    )
-                    .await?
-                    .try_into()?;
 
                 match swap_state {
                     BobState::Started { .. }
@@ -560,44 +590,10 @@ impl Request {
                 Ok(json!({
                     "result": []
                 }))
-            },
+            }
-            Method::GetCurrentSwap => {
+            Method::GetCurrentSwap => Ok(json!({
-                Ok(json!({
                 "swap_id": SWAP_LOCK.read().await.clone()
-                }))
+            })),
-            },
-            Method::GetSwapExpiredTimelock { swap_id } => {
-                let swap_state: BobState = context
-                    .db
-                    .get_state(
-                        swap_id,
-                    )
-                    .await?
-                    .try_into()?;
-
-                let bitcoin_wallet = context.bitcoin_wallet.as_ref().context("Could not get Bitcoin wallet")?;
-
-                let timelock = match swap_state {
-                    BobState::Started { .. }
-                    | BobState::SafelyAborted
-                    | BobState::SwapSetupCompleted(_) => bail!("Bitcoin lock transaction has not been published yet"),
-                    BobState::BtcLocked { state3: state, .. }
-                    | BobState::XmrLockProofReceived { state, .. } => state.expired_timelock(bitcoin_wallet).await,
-                    BobState::XmrLocked(state)
-                    | BobState::EncSigSent(state) => state.expired_timelock(bitcoin_wallet).await,
-                    BobState::CancelTimelockExpired(state)
-                    | BobState::BtcCancelled(state) => state.expired_timelock(bitcoin_wallet).await,
-                    BobState::BtcPunished { .. } => Ok(ExpiredTimelocks::Punish),
-                    // swap is already finished
-                    BobState::BtcRefunded(_)
-                    | BobState::BtcRedeemed(_)
-                    | BobState::XmrRedeemed { .. } => bail!("Bitcoin have already been redeemed or refunded")
-                }?;
-
-                Ok(json!({
-                    "timelock": timelock,
-                }))
-            },
         }
     }
 
@@ -647,7 +643,7 @@ pub async fn determine_btc_to_swap<FB, TB, FMG, TMG, FS, TS, FFE, TFE>(
     sync: FS,
     estimate_fee: FFE,
 ) -> Result<(bitcoin::Amount, bitcoin::Amount)>
-    where
+where
     TB: Future<Output = Result<bitcoin::Amount>>,
     FB: Fn() -> TB,
     TMG: Future<Output = Result<bitcoin::Amount>>,
@@ -730,4 +726,3 @@ pub async fn determine_btc_to_swap<FB, TB, FMG, TMG, FS, TS, FFE, TFE>(
 
     Ok((btc_swap_amount, fees))
 }
-

swap/src/rpc/methods.rs

@@ -14,6 +14,18 @@ use uuid::Uuid;
 pub fn register_modules(context: Arc<Context>) -> RpcModule<Arc<Context>> {
     let mut module = RpcModule::new(context);
 
+    module
+        .register_async_method("get_swap_info", |params, context| async move {
+            let params: HashMap<String, Uuid> = params.parse()?;
+
+            let swap_id = params.get("swap_id").ok_or_else(|| {
+                jsonrpsee_core::Error::Custom("Does not contain swap_id".to_string())
+            })?;
+
+            get_swap_info(*swap_id, &context).await
+        })
+        .unwrap();
+
     module
         .register_async_method("get_bitcoin_balance", |_, context| async move {
             get_bitcoin_balance(&context).await
@@ -32,30 +44,6 @@ pub fn register_modules(context: Arc<Context>) -> RpcModule<Arc<Context>> {
         })
         .unwrap();
 
-    module
-        .register_async_method("get_seller", |params, context| async move {
-            let params: HashMap<String, Uuid> = params.parse()?;
-
-            let swap_id = params.get("swap_id").ok_or_else(|| {
-                jsonrpsee_core::Error::Custom("Does not contain swap_id".to_string())
-            })?;
-
-            get_seller(*swap_id, &context).await
-        })
-        .unwrap();
-
-    module
-        .register_async_method("get_swap_start_date", |params, context| async move {
-            let params: HashMap<String, Uuid> = params.parse()?;
-
-            let swap_id = params.get("swap_id").ok_or_else(|| {
-                jsonrpsee_core::Error::Custom("Does not contain swap_id".to_string())
-            })?;
-
-            get_swap_start_date(*swap_id, &context).await
-        })
-        .unwrap();
-
     module
         .register_async_method("resume_swap", |params, context| async move {
             let params: HashMap<String, Uuid> = params.parse()?;
@@ -68,16 +56,6 @@ pub fn register_modules(context: Arc<Context>) -> RpcModule<Arc<Context>> {
         })
         .unwrap();
 
-    module.register_async_method("get_swap_expired_timelock", |params, context| async move {
-        let params: HashMap<String, Uuid> = params.parse()?;
-
-        let swap_id = params.get("swap_id").ok_or_else(|| {
-            jsonrpsee_core::Error::Custom("Does not contain swap_id".to_string())
-        })?;
-
-        get_swap_timelock(*swap_id, &context).await
-    }).unwrap();
-
     module
         .register_async_method("cancel_refund_swap", |params, context| async move {
             let params: HashMap<String, Uuid> = params.parse()?;
@@ -167,9 +145,12 @@ pub fn register_modules(context: Arc<Context>) -> RpcModule<Arc<Context>> {
             list_sellers(rendezvous_point.clone(), &context).await
         })
         .unwrap();
-    module.register_async_method("get_current_swap", |_, context| async move {
+
+    module
+        .register_async_method("get_current_swap", |_, context| async move {
             get_current_swap(&context).await
-    }).unwrap();
+        })
+        .unwrap();
 
     module
 }
@@ -185,7 +166,9 @@ async fn execute_request(
         .map_err(|err| jsonrpsee_core::Error::Custom(err.to_string()))
 }
 
-async fn get_current_swap(context: &Arc<Context>) -> Result<serde_json::Value, jsonrpsee_core::Error> {
+async fn get_current_swap(
+    context: &Arc<Context>,
+) -> Result<serde_json::Value, jsonrpsee_core::Error> {
     execute_request(Method::GetCurrentSwap, context).await
 }
 
@@ -205,49 +188,25 @@ async fn get_raw_history(
     execute_request(Method::RawHistory, context).await
 }
 
-async fn get_seller(
+async fn get_swap_info(
     swap_id: Uuid,
     context: &Arc<Context>,
 ) -> Result<serde_json::Value, jsonrpsee_core::Error> {
-    execute_request(Method::GetSeller {
+    execute_request(Method::GetSwapInfo { swap_id }, context).await
-        swap_id
-    }, context).await
-}
-
-async fn get_swap_start_date(
-    swap_id: Uuid,
-    context: &Arc<Context>,
-) -> Result<serde_json::Value, jsonrpsee_core::Error> {
-    execute_request(Method::SwapStartDate {
-        swap_id
-    }, context).await
 }
 
 async fn resume_swap(
     swap_id: Uuid,
     context: &Arc<Context>,
 ) -> Result<serde_json::Value, jsonrpsee_core::Error> {
-    execute_request(Method::Resume {
+    execute_request(Method::Resume { swap_id }, context).await
-        swap_id
-    }, context).await
-}
-
-async fn get_swap_timelock(
-    swap_id: Uuid,
-    context: &Arc<Context>,
-) -> Result<serde_json::Value, jsonrpsee_core::Error> {
-    execute_request(Method::GetSwapExpiredTimelock {
-        swap_id
-    }, context).await
 }
 
 async fn cancel_and_refund_swap(
     swap_id: Uuid,
     context: &Arc<Context>,
 ) -> Result<serde_json::Value, jsonrpsee_core::Error> {
-    execute_request(Method::CancelAndRefund {
+    execute_request(Method::CancelAndRefund { swap_id }, context).await
-        swap_id
-    }, context).await
 }
 
 async fn withdraw_btc(
@@ -255,10 +214,7 @@ async fn withdraw_btc(
     amount: Option<bitcoin::Amount>,
     context: &Arc<Context>,
 ) -> Result<serde_json::Value, jsonrpsee_core::Error> {
-    execute_request(Method::WithdrawBtc {
+    execute_request(Method::WithdrawBtc { amount, address }, context).await
-        amount,
-        address,
-    }, context).await
 }
 
 async fn buy_xmr(
@@ -267,19 +223,21 @@ async fn buy_xmr(
     seller: Multiaddr,
     context: &Arc<Context>,
 ) -> Result<serde_json::Value, jsonrpsee_core::Error> {
-    execute_request(Method::BuyXmr {
+    execute_request(
+        Method::BuyXmr {
             seller,
             swap_id: Uuid::new_v4(),
             bitcoin_change_address,
-        monero_receive_address
+            monero_receive_address,
-    }, context).await
+        },
+        context,
+    )
+    .await
 }
 
 async fn list_sellers(
     rendezvous_point: Multiaddr,
     context: &Arc<Context>,
 ) -> Result<serde_json::Value, jsonrpsee_core::Error> {
-    execute_request(Method::ListSellers {
+    execute_request(Method::ListSellers { rendezvous_point }, context).await
-        rendezvous_point
-    }, context).await
 }