Git-Mirrors/xmr-btc-swap
1
0
Fork 0
mirror of https://github.com/comit-network/xmr-btc-swap.git synced 2024-10-01 01:45:40 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: Do not acknowledge transfer proof when we are currently running a different swap

Browse Source
This commit is contained in:
binarybaron 2024-06-01 15:57:41 +02:00
parent 1930540c1f
commit 4a084c9e94
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
swap/src/cli/event_loop.rs
View File

@ -118,12 +118,13 @@ impl EventLoop {
}
if swap_id != self.swap_id {
// TODO: Save unexpected transfer proofs in the database and check for messages in the database when handling swaps
tracing::warn!("Received unexpected transfer proof for swap {} while running swap {}. This transfer proof will be ignored", swap_id, self.swap_id);
// When receiving a transfer proof that is unexpected we still have to acknowledge that it was received
let _ = self.swarm.behaviour_mut().transfer_proof.send_response(channel, ());
// When receiving a transfer proof that is unexpected we do not want to acknowledge it.
// If we acknowledge it, Alice will think we have received the transfer proof and will not send it again.
// But we haven't processed the transfer proof yet, so we need to wait for Alice to send it again.
// Ideally we would save the transfer proof in the database and check for messages in the database when handling swaps.
continue;
}