Git-Mirrors/xmr-btc-swap
1
0
Fork 0
mirror of https://github.com/comit-network/xmr-btc-swap.git synced 2025-12-16 17:14:13 -05:00
Code Issues Projects Releases Packages Wiki Activity

feat: assume xmr double spend safety after 6 confirmations

Browse source
This commit is contained in:
Binarybaron 2025-11-09 02:18:41 +01:00
parent 111a5a3271
commit 294b9985cf
2 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
CHANGELOG.md
View file

@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased] ## [Unreleased]
- GUI + SWAP: Assume double spend safety of Monero transactions after 6 confirmations. This means we are assuming that there won't be any re-orgs deeper than 5 blocks. We believe this is a safe assumption given that there were almost no orphaned blocks over the last two weeks. Qubic (which was behind the re-orgs) has mined less than 1% of the last 1000 blocks.
## [3.2.10] - 2025-11-08 ## [3.2.10] - 2025-11-08
- GUI + SWAP + ASB: Reduce the confirmations required to spend a Monero transaction from 22 to 15. We believe the risks of re-orgs is low again and this is safe to do. This may increase the chances of swap being successful and will reduce the time a swap takes. - GUI + SWAP + ASB: Reduce the confirmations required to spend a Monero transaction from 22 to 15. We believe the risks of re-orgs is low again and this is safe to do. This may increase the chances of swap being successful and will reduce the time a swap takes.

12
swap-env/src/env.rs
View file

@ -66,8 +66,8 @@ impl GetConfig for Mainnet {
// If Alice cannot lock her Monero within this timeout, // If Alice cannot lock her Monero within this timeout,
// she will initiate an early refund of Bobs Bitcoin // she will initiate an early refund of Bobs Bitcoin
monero_lock_retry_timeout: 10.std_minutes(), monero_lock_retry_timeout: 10.std_minutes(),
monero_finality_confirmations: 15, monero_finality_confirmations: 10,
monero_double_spend_safe_confirmations: 15, monero_double_spend_safe_confirmations: 6,
monero_network: monero::Network::Mainnet, monero_network: monero::Network::Mainnet,
} }
} }
@ -86,8 +86,8 @@ impl GetConfig for Testnet {
bitcoin_network: bitcoin::Network::Testnet, bitcoin_network: bitcoin::Network::Testnet,
monero_avg_block_time: 2.std_minutes(), monero_avg_block_time: 2.std_minutes(),
monero_lock_retry_timeout: 10.std_minutes(), monero_lock_retry_timeout: 10.std_minutes(),
monero_finality_confirmations: 15, monero_finality_confirmations: 10,
monero_double_spend_safe_confirmations: 15, monero_double_spend_safe_confirmations: 6,
monero_network: monero::Network::Stagenet, monero_network: monero::Network::Stagenet,
} }
} }
@ -106,8 +106,8 @@ impl GetConfig for Regtest {
bitcoin_network: bitcoin::Network::Regtest, bitcoin_network: bitcoin::Network::Regtest,
monero_avg_block_time: 1.std_seconds(), monero_avg_block_time: 1.std_seconds(),
monero_lock_retry_timeout: 1.std_minutes(), monero_lock_retry_timeout: 1.std_minutes(),
monero_finality_confirmations: 12, monero_finality_confirmations: 10,
monero_double_spend_safe_confirmations: 12, monero_double_spend_safe_confirmations: 6,
monero_network: monero::Network::Mainnet, // yes this is strange monero_network: monero::Network::Mainnet, // yes this is strange
} }
} }