Merge #717

717: Fetch all utxo r=rishflab a=rishflab



Co-authored-by: devbordecraft <devbordecraft>

CHANGELOG.md

@@ -25,6 +25,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   We were not handling the error when TxCancel submission fails.
   We also configured the electrum client to retry 5 times in order to help with this problem.
   See issues: https://github.com/comit-network/xmr-btc-swap/issues/709 https://github.com/comit-network/xmr-btc-swap/issues/688, https://github.com/comit-network/xmr-btc-swap/issues/701.
+- Add the ability to view the swap-cli bitcoin balance and withdraw
+  See issue https://github.com/comit-network/xmr-btc-swap/issues/694
+- An issue where the ASB withdraw one bitcoin UTXO at a time instead of the whole balance.
+  See issue https://github.com/comit-network/xmr-btc-swap/issues/662
 
 ## [0.8.1] - 2021-08-16
 

swap/src/bitcoin/wallet.rs

@@ -400,6 +400,7 @@ where
         let dummy_script = Script::from(vec![0u8; locking_script_size]);
         tx_builder.drain_to(dummy_script);
         tx_builder.fee_rate(fee_rate);
+        tx_builder.drain_wallet();
 
         let response = tx_builder.finish();
         match response {

swap/src/cli/command.rs

@@ -3,7 +3,7 @@ use crate::env::GetConfig;
 use crate::fs::system_data_dir;
 use crate::network::rendezvous::XmrBtcNamespace;
 use crate::{env, monero};
-use anyhow::{Context, Result};
+use anyhow::{bail, Context, Result};
 use bitcoin::{Address, AddressType};
 use libp2p::core::Multiaddr;
 use serde::Serialize;
@@ -141,7 +141,7 @@ where
                     bitcoin_electrum_rpc_url,
                     bitcoin_target_block,
                     amount,
-                    address: validate_bitcoin_address(address, is_testnet)?,
+                    address: bitcoin_address(address, is_testnet)?,
                 },
             }
         }
@@ -529,6 +529,23 @@ fn env_config_from(testnet: bool) -> env::Config {
     }
 }
 
+fn bitcoin_address(address: Address, is_testnet: bool) -> Result<Address> {
+    let network = if is_testnet {
+        bitcoin::Network::Testnet
+    } else {
+        bitcoin::Network::Bitcoin
+    };
+
+    if address.network != network {
+        bail!(BitcoinAddressNetworkMismatch {
+            expected: network,
+            actual: address.network
+        });
+    }
+
+    Ok(address)
+}
+
 fn validate_monero_address(
     address: monero::Address,
     testnet: bool,