Git-Mirrors/xmr-btc-swap
1
0
Fork 0
mirror of https://github.com/comit-network/xmr-btc-swap.git synced 2024-10-01 01:45:40 -04:00
Code Issues Packages Projects Releases Wiki Activity

Bitcoin network check when building PSBT

Browse Source 
This ensures that funds are not sent to an address on the wrong network.
This commit is contained in:
Daniel Karzel 2021-05-25 11:36:24 +10:00
parent ca6cb0a76a
commit 102cec437e
No known key found for this signature in database
GPG Key ID: 30C3FC2E438ADB6E
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
CHANGELOG.md
View File

@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]
### Fixed
- An issue where ASB Bitcoin withdrawal can be done to an address on the wrong network.
A network check was added that compares the wallet's network against the network of the given address when building the transaction.
## [0.6.0] - 2021-05-24
### Added

4
swap/src/bitcoin/wallet.rs
View File

@ -303,6 +303,10 @@ where
address: Address,
amount: Amount,
) -> Result<PartiallySignedTransaction> {
if self.network != address.network {
bail!("Cannot build PSBT because network of given address is {} but wallet is on network {}", address.network, self.network);
}
let wallet = self.wallet.lock().await;
let client = self.client.lock().await;
let fee_rate = client.estimate_feerate(self.target_block)?;