From fcf032e13e49378730f7f506d7d25ef3818d4409 Mon Sep 17 00:00:00 2001 From: Christien Rioux Date: Sat, 29 Jun 2024 18:19:27 +0000 Subject: [PATCH 1/2] fix memory leak in windows ptr_lookup --- veilid-core/src/intf/native/system.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/veilid-core/src/intf/native/system.rs b/veilid-core/src/intf/native/system.rs index 0b1dca5c..7336deeb 100644 --- a/veilid-core/src/intf/native/system.rs +++ b/veilid-core/src/intf/native/system.rs @@ -169,6 +169,7 @@ pub async fn ptr_lookup(ip_addr: IpAddr) -> EyreResult { let c_str: &CStr = CStr::from_ptr(p_name_host.0 as *const i8); if let Ok(str_slice) = c_str.to_str() { let str_buf: String = str_slice.to_owned(); + DnsFree(Some(p_query_results as *const c_void), DnsFreeRecordList); return Ok(str_buf); } } From b94a89d212a7ba6c490319f5a53a95bfbf1ebed8 Mon Sep 17 00:00:00 2001 From: John Smith Date: Sat, 29 Jun 2024 23:00:29 -0400 Subject: [PATCH 2/2] some clippy fixes --- veilid-core/Cargo.toml | 2 +- veilid-flutter/example/pubspec.lock | 14 +++++++------- veilid-wasm/Cargo.toml | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/veilid-core/Cargo.toml b/veilid-core/Cargo.toml index b7ee1c79..ae11c84d 100644 --- a/veilid-core/Cargo.toml +++ b/veilid-core/Cargo.toml @@ -197,7 +197,7 @@ wasm-bindgen = "0.2.89" js-sys = "0.3.66" wasm-bindgen-futures = "0.4.39" send_wrapper = { version = "0.6.0", features = ["futures"] } -serde_bytes = { version = "0.11", default_features = false, features = [ +serde_bytes = { version = "0.11", default-features = false, features = [ "alloc", ] } tsify = { version = "0.4.5", features = ["js"] } diff --git a/veilid-flutter/example/pubspec.lock b/veilid-flutter/example/pubspec.lock index 82dc91da..3ed06495 100644 --- a/veilid-flutter/example/pubspec.lock +++ b/veilid-flutter/example/pubspec.lock @@ -37,10 +37,10 @@ packages: dependency: transitive description: name: change_case - sha256: "47c48c36f95f20c6d0ba03efabceff261d05026cca322cc2c4c01c343371b5bb" + sha256: "99cfdf2018c627c8a3af5a23ea4c414eb69c75c31322d23b9660ebc3cf30b514" url: "https://pub.dev" source: hosted - version: "2.0.1" + version: "2.1.0" characters: dependency: transitive description: @@ -138,10 +138,10 @@ packages: dependency: "direct main" description: name: flutter_acrylic - sha256: a9a1fdf91ff1fb47858fd82507f57e255a132a5d355056694fdb9fd303633b18 + sha256: b3996dbde5abf5823cc9ead4cf2e5267c3181f15585fe47ce4dc4472e7ec827a url: "https://pub.dev" source: hosted - version: "1.1.3" + version: "1.1.4" flutter_driver: dependency: transitive description: flutter @@ -283,10 +283,10 @@ packages: dependency: transitive description: name: path_provider_android - sha256: a248d8146ee5983446bf03ed5ea8f6533129a12b11f12057ad1b4a67a2b3b41d + sha256: bca87b0165ffd7cdb9cad8edd22d18d2201e886d9a9f19b4fb3452ea7df3a72a url: "https://pub.dev" source: hosted - version: "2.2.4" + version: "2.2.6" path_provider_foundation: dependency: transitive description: @@ -508,4 +508,4 @@ packages: version: "0.0.6" sdks: dart: ">=3.4.0 <4.0.0" - flutter: ">=3.19.1" + flutter: ">=3.22.0" diff --git a/veilid-wasm/Cargo.toml b/veilid-wasm/Cargo.toml index aa06b27a..a77eca4e 100644 --- a/veilid-wasm/Cargo.toml +++ b/veilid-wasm/Cargo.toml @@ -29,7 +29,7 @@ cfg-if = "^1" wasm-bindgen-futures = "^0" js-sys = "^0" serde_json = "^1" -serde_bytes = { version = "0.11", default_features = false, features = [ +serde_bytes = { version = "0.11", default-features = false, features = [ "alloc", ] } serde = "^1"