From bb17e7cee6b3158b196f7e4dd3336c8368c35009 Mon Sep 17 00:00:00 2001
From: Christien Rioux <chris@veilid.org>
Date: Fri, 28 Mar 2025 12:23:36 -0400
Subject: [PATCH] [ci skip] add convenience script for clippy

---
 scripts/clippy_all.sh                          | 11 +++++++++++
 veilid-tools/src/ipc/ipc_async_std/unix.rs     |  6 +++---
 veilid-tools/src/ipc/ipc_tokio/windows.rs      |  2 +-
 veilid-tools/src/network_interfaces/windows.rs |  2 +-
 veilid-tools/src/socket_tools.rs               |  2 ++
 veilid-wasm/src/veilid_routing_context_js.rs   |  2 +-
 6 files changed, 19 insertions(+), 6 deletions(-)
 create mode 100755 scripts/clippy_all.sh

diff --git a/scripts/clippy_all.sh b/scripts/clippy_all.sh
new file mode 100755
index 00000000..f0c48e98
--- /dev/null
+++ b/scripts/clippy_all.sh
@@ -0,0 +1,11 @@
+#!/bin/bash
+SCRIPTDIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
+pushd $SCRIPTDIR/.. >/dev/null
+
+cargo-zigbuild clippy --target x86_64-unknown-linux-gnu
+cargo-zigbuild clippy --target x86_64-unknown-linux-gnu  --manifest-path=veilid-server/Cargo.toml --no-default-features --features=default-async-std
+cargo-zigbuild clippy --target x86_64-pc-windows-gnu
+cargo-zigbuild clippy --target aarch64-apple-darwin
+cargo clippy --manifest-path=veilid-wasm/Cargo.toml --target wasm32-unknown-unknown
+
+popd >/dev/null
\ No newline at end of file
diff --git a/veilid-tools/src/ipc/ipc_async_std/unix.rs b/veilid-tools/src/ipc/ipc_async_std/unix.rs
index cbc13b21..5bc74950 100644
--- a/veilid-tools/src/ipc/ipc_async_std/unix.rs
+++ b/veilid-tools/src/ipc/ipc_async_std/unix.rs
@@ -63,7 +63,7 @@ pub struct IpcIncoming<'a> {
     internal: Incoming<'a>,
 }
 
-impl<'a> Drop for IpcIncoming<'a> {
+impl Drop for IpcIncoming<'_> {
     fn drop(&mut self) {
         // Clean up IPC path
         if let Err(e) = std::fs::remove_file(&self.path) {
@@ -72,7 +72,7 @@ impl<'a> Drop for IpcIncoming<'a> {
     }
 }
 
-impl<'a> Stream for IpcIncoming<'a> {
+impl Stream for IpcIncoming<'_> {
     type Item = io::Result<IpcStream>;
 
     fn poll_next(
@@ -124,7 +124,7 @@ impl IpcListener {
     }
 
     /// Returns a stream of incoming connections.
-    pub fn incoming<'a>(&'a mut self) -> io::Result<IpcIncoming<'a>> {
+    pub fn incoming(&mut self) -> io::Result<IpcIncoming<'_>> {
         if self.path.is_none() {
             return Err(io::Error::from(io::ErrorKind::NotConnected));
         }
diff --git a/veilid-tools/src/ipc/ipc_tokio/windows.rs b/veilid-tools/src/ipc/ipc_tokio/windows.rs
index 3d157db1..1afc175c 100644
--- a/veilid-tools/src/ipc/ipc_tokio/windows.rs
+++ b/veilid-tools/src/ipc/ipc_tokio/windows.rs
@@ -121,7 +121,7 @@ pub struct IpcIncoming<'a> {
     phantom: std::marker::PhantomData<&'a ()>,
 }
 
-impl<'t> Stream for IpcIncoming<'t> {
+impl Stream for IpcIncoming<'_> {
     type Item = io::Result<IpcStream>;
 
     fn poll_next<'a>(
diff --git a/veilid-tools/src/network_interfaces/windows.rs b/veilid-tools/src/network_interfaces/windows.rs
index 7cebd2a5..35503753 100644
--- a/veilid-tools/src/network_interfaces/windows.rs
+++ b/veilid-tools/src/network_interfaces/windows.rs
@@ -293,7 +293,7 @@ pub struct WindowsInterfacesIterator<'a> {
     _phantom: std::marker::PhantomData<&'a u8>,
 }
 
-impl<'a> Iterator for WindowsInterfacesIterator<'a> {
+impl Iterator for WindowsInterfacesIterator<'_> {
     type Item = IpAdapterAddresses;
 
     #[allow(unsafe_code)]
diff --git a/veilid-tools/src/socket_tools.rs b/veilid-tools/src/socket_tools.rs
index c5571570..eb32ac0a 100644
--- a/veilid-tools/src/socket_tools.rs
+++ b/veilid-tools/src/socket_tools.rs
@@ -129,6 +129,7 @@ cfg_if! {
     }
 }
 
+#[must_use]
 pub fn async_tcp_listener_incoming(
     tcp_listener: TcpListener,
 ) -> Pin<Box<impl futures_util::stream::Stream<Item = std::io::Result<TcpStream>> + Send>> {
@@ -143,6 +144,7 @@ pub fn async_tcp_listener_incoming(
     }
 }
 
+#[must_use]
 pub fn split_async_tcp_stream(tcp_stream: TcpStream) -> (ReadHalf, WriteHalf) {
     cfg_if! {
         if #[cfg(feature="rt-async-std")] {
diff --git a/veilid-wasm/src/veilid_routing_context_js.rs b/veilid-wasm/src/veilid_routing_context_js.rs
index 484d0246..26a53a61 100644
--- a/veilid-wasm/src/veilid_routing_context_js.rs
+++ b/veilid-wasm/src/veilid_routing_context_js.rs
@@ -190,7 +190,7 @@ impl VeilidRoutingContext {
     }
 
     ///////////////////////////////////
-    /// DHT Records
+    // DHT Records
 
     /// Deterministicly builds the record key for a given schema and owner public key
     #[allow(clippy::unused_async)]