From 72cb56eff76bfcfec8b89c4be866aabfc5682a56 Mon Sep 17 00:00:00 2001 From: toninov Date: Thu, 24 Jul 2025 23:02:10 +0200 Subject: [PATCH] maybe you should init the args_base wdyt --- dm-sflc/src/legacy/target.c | 4 ++++ dm-sflc/src/lite/sflc_lite.c | 4 ++++ dm-sflc/src/lite/volume.c | 2 +- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/dm-sflc/src/legacy/target.c b/dm-sflc/src/legacy/target.c index a3dc1b3..bea773a 100644 --- a/dm-sflc/src/legacy/target.c +++ b/dm-sflc/src/legacy/target.c @@ -97,6 +97,10 @@ static struct sflc_ctor_args_base *sflegc_parse_ctor_args(int argc, char ** argv err = -EINVAL; goto bad_parse; } + /* Base args */ + err = sflc_ctor_args_base_init(&args->args_base, argc, argv); + if (err) + goto bad_parse; /* Tot slices */ if (sscanf(argv[4], "%u", &args->tot_slices) != 1) { DMERR("Could not decode tot_slices"); diff --git a/dm-sflc/src/lite/sflc_lite.c b/dm-sflc/src/lite/sflc_lite.c index 2d41a74..2464420 100644 --- a/dm-sflc/src/lite/sflc_lite.c +++ b/dm-sflc/src/lite/sflc_lite.c @@ -55,6 +55,10 @@ static struct sflc_ctor_args_base *sflite_parse_ctor_args(int argc, char ** argv err = -EINVAL; goto bad_parse; } + /* Base args */ + err = sflc_ctor_args_base_init(&args->args_base, argc, argv); + if (err) + goto bad_parse; /* Tot slices */ if (sscanf(argv[4], "%u", &args->tot_slices) != 1) { DMERR("Could not decode tot_slices"); diff --git a/dm-sflc/src/lite/volume.c b/dm-sflc/src/lite/volume.c index 17439bc..6e258b9 100644 --- a/dm-sflc/src/lite/volume.c +++ b/dm-sflc/src/lite/volume.c @@ -54,7 +54,7 @@ struct sflc_volume_base *sflite_vol_ctr(struct sflc_device_base *sd_base, err = dm_get_device(ti, sdev->sd_base.name, dm_table_get_mode(ti->table), &svol->dm_dev); if (err) { - ti->error = "Device lookup failed"; + DMERR("Could not dm_get_device %s", sdev->sd_base.name); goto bad_dm_dev; }