Git-Mirrors/qubes-mirage-firewall
1
0
Fork 0
mirror of https://github.com/mirage/qubes-mirage-firewall.git synced 2025-07-24 23:55:57 -04:00
Code Issues Projects Releases Packages Wiki Activity

minor: reword XXX to NOTE

Browse source
This commit is contained in:
Hannes Mehnert 2024-10-15 21:39:35 +02:00
parent 9156d580df
commit ceb712ec60
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
dao.ml
View file

@ -81,7 +81,7 @@ let vifs client domid =
let get_client_ip () = let get_client_ip () =
let* str = Xen_os.Xs.read handle (Fmt.str "%s/%d/ip" path device_id) in let* str = Xen_os.Xs.read handle (Fmt.str "%s/%d/ip" path device_id) in
let client_ip = List.hd (String.split_on_char ' ' str) in let client_ip = List.hd (String.split_on_char ' ' str) in
(* XXX(dinosaure): it's safe to use [List.hd] here, (* NOTE(dinosaure): it's safe to use [List.hd] here,
[String.split_on_char] can not return an empty list. *) [String.split_on_char] can not return an empty list. *)
Lwt.return_some (vif, Ipaddr.V4.of_string_exn client_ip) Lwt.return_some (vif, Ipaddr.V4.of_string_exn client_ip)
in in

2
dispatcher.ml
View file

@ -403,7 +403,7 @@ struct
(function Lwt.Canceled -> Lwt.return_unit | e -> Lwt.fail e) (function Lwt.Canceled -> Lwt.return_unit | e -> Lwt.fail e)
in in
Cleanup.on_cleanup cleanup_tasks (fun () -> Lwt.cancel listener); Cleanup.on_cleanup cleanup_tasks (fun () -> Lwt.cancel listener);
(* XXX(dinosaure): [qubes_updater] and [listener] can be forgotten, our [cleanup_task] (* NOTE(dinosaure): [qubes_updater] and [listener] can be forgotten, our [cleanup_task]
will cancel them if the client is disconnected. *) will cancel them if the client is disconnected. *)
Lwt.async (fun () -> Lwt.pick [ qubesdb_updater; listener ]); Lwt.async (fun () -> Lwt.pick [ qubesdb_updater; listener ]);
Lwt.return_unit Lwt.return_unit