From c29cf40910ff68a2c6c9585ca39d73584e48b31b Mon Sep 17 00:00:00 2001 From: Andrew David Wong Date: Thu, 8 Jul 2021 07:41:19 -0700 Subject: [PATCH] Reorganize doc guidelines into multiple pages; update style guide The existing doc guidelines page attempts to combine too many different topics at once and includes information that does not pertain directly to the documentation. This reorganization is intended to make each type of information easier to find. For example, some have found it difficult to find the documentation style guidelines (see, e.g., QubesOS/qubes-issues#6701#issuecomment-875875610). This reorganization allows us to assign more specific titles to each page. General changes: - Create new page for contribution instructions - Create new page for website style guide - Create new page for continuous integration - Rename existing "style guide" to "visual style guide" in order to avoid ambiguity with new doc and website style guides - Retain existing page solely for doc style guide - Update page names and permalinks - Update existing links - Improve language Doc style guide changes: - Add section on using sentence case in headings (see QubesOS/qubes-issues#6756 and #1173) - Improve section organization - Clarify language In order to better preserve the Git history of each file, file renames will be handled in a separate commit. --- CONTRIBUTING.md | 14 +- README.md | 4 +- developer/general/continuous-integration.md | 34 ++ developer/general/doc-guidelines.md | 531 +++++------------- .../general/how-to-edit-the-documentation.md | 190 +++++++ developer/general/style-guide.md | 6 +- developer/general/usability-ux.md | 2 +- developer/general/website-style-guide.md | 78 +++ introduction/contributing.md | 2 +- introduction/faq.md | 6 +- introduction/getting-started.md | 2 +- introduction/issue-tracking.md | 15 +- introduction/support.md | 4 +- .../installation-guide.md | 2 +- user/templates/minimal-templates.md | 2 +- 15 files changed, 481 insertions(+), 411 deletions(-) create mode 100644 developer/general/continuous-integration.md create mode 100644 developer/general/how-to-edit-the-documentation.md create mode 100644 developer/general/website-style-guide.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ede0d123..1e2bd856 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,8 +1,12 @@ # Contributing to `qubes-doc` Thank you for your interest in contributing to `qubes-doc`, the Qubes OS -Project's dedicated documentation repository! Please take a moment to read our -[Documentation Guidelines](https://www.qubes-os.org/doc/doc-guidelines/) before -you begin writing. These guidelines are important to maintaining high quality -documentation, and following them will increase the likelihood that your -contribution will be accepted. +Project's dedicated documentation repository! Please see [how to edit the +documentation](https://www.qubes-os.org/doc/how-to-edit-the-documentation/) for +detailed contribution instructions. + +In addition, please take a moment to read our [documentation style +guide](https://www.qubes-os.org/doc/documentation-style-guide/) before +contributing. These guidelines are important to maintaining high standards of +quality, and following them will increase the likelihood that your contribution +will be accepted. diff --git a/README.md b/README.md index c31a58ee..0ab67025 100644 --- a/README.md +++ b/README.md @@ -7,5 +7,5 @@ stored as plain text files in this dedicated repository. By cloning and regularly pulling from this repo, users can maintain their own up-to-date offline copy of all Qubes documentation rather than relying solely on the Web. -For more information about the documentation, including how to contribute, -please see the [Documentation Guidelines](https://www.qubes-os.org/doc/doc-guidelines/). +To contribute, please see [how to edit the +documentation](https://www.qubes-os.org/doc/how-to-edit-the-documentation/). diff --git a/developer/general/continuous-integration.md b/developer/general/continuous-integration.md new file mode 100644 index 00000000..3f2973e7 --- /dev/null +++ b/developer/general/continuous-integration.md @@ -0,0 +1,34 @@ +--- +lang: en +layout: doc +permalink: /doc/continuous-integration/ +title: Continuous Integration (CI) +--- + +This page explains the [continuous integration +(CI)](https://en.wikipedia.org/wiki/Continuous_integration) infrastructure that +the Qubes OS Project uses. + +## Website and documentation + +The following commands may be useful as a way to interact with our CI +infrastructure on website +([qubesos.github.io](https://github.com/QubesOS/qubesos.github.io)) and +documentation ([qubes-doc](https://github.com/QubesOS/qubes-doc)) pull requests +(PRs). Note that special permissions may be required to use some of these +commands. These commands are generally issued by adding a comment to a PR +containing only the command. + +- `PipelineRetry`: Attempts to run the entire build pipeline over again. This + can be useful if CI incorrectly uses a stale branch instead of testing the PR + as if it were merged into `master`. + +- `TestDeploy`: Deploys a test website, which is a live version of the Qubes + website as if this PR had been merged. This can be useful for previewing a PR + on a live public website. **Note:** You must wait for the site to finish + building before issuing this command, or else it will deploy an empty + website. To find the URL of the test website, look for text similar to "This + branch was successfully deployed" and a button named something like "View + deployment." Note that there are two different testing sites: `wwwtest` is + manually updated, whereas `wwwpreview` is managed by the `TestDeploy` + command. diff --git a/developer/general/doc-guidelines.md b/developer/general/doc-guidelines.md index 6d55644e..44f3fbb5 100644 --- a/developer/general/doc-guidelines.md +++ b/developer/general/doc-guidelines.md @@ -1,196 +1,203 @@ --- lang: en layout: doc -permalink: /doc/doc-guidelines/ +permalink: /doc/documentation-style-guide/ redirect_from: +- /doc/doc-guidelines/ - /en/doc/doc-guidelines/ - /wiki/DocStyle/ - /doc/DocStyle/ ref: 30 -title: Documentation Guidelines +title: Documentation Style Guide --- -All Qubes OS documentation pages are stored as plain text files in the -dedicated [qubes-doc](https://github.com/QubesOS/qubes-doc) repository. By -cloning and regularly pulling from this repo, users can maintain their own -up-to-date offline copy of all Qubes documentation rather than relying solely -on the web. +Qubes OS documentation pages are stored as plain text Markdown files in the +[qubes-doc](https://github.com/QubesOS/qubes-doc) repository. By cloning and +regularly pulling from this repo, users can maintain their own up-to-date +offline copy of all Qubes documentation rather than relying solely on the web. -The documentation is a community effort. Volunteers work hard trying to keep -everything accurate and comprehensive. If you notice a problem or some way it -can be improved, please [edit the documentation](#how-to-contribute)! +The documentation is a volunteer community effort. People like you are +constantly working to make it better. If you notice something that can be fixed +or improved, please [edit the +documentation](/doc/how-to-edit-the-documentation/)! -## Security +This page explains the standards we follow for writing, formatting, and +organizing the documentation. Please follow these guidelines and conventions +when editing the documentation. For the standards governing the website as a +whole, please see the [website style guide](/doc/website-style-guide). -*Also see: [Should I trust this website?](/faq/#should-i-trust-this-website)* +## Markdown conventions -All pull requests (PRs) against -[qubes-doc](https://github.com/QubesOS/qubes-doc) must pass review prior to be -merged, except in the case of [external -documentation](/doc/#external-documentation) (see -[#4693](https://github.com/QubesOS/qubes-issues/issues/4693)). This process is -designed to ensure that contributed text is accurate and non-malicious. This -process is a best effort that should provide a reasonable degree of assurance, -but it is not foolproof. For example, all text characters are checked for ANSI -escape sequences. However, binaries, such as images, are simply checked to -ensure they appear or function the way they should when the website is -rendered. They are not further analyzed in an attempt to determine whether they -are malicious. +All the documentation is written in Markdown for maximum accessibility. When +making contributions, please observe the following style conventions. If you're +not familiar with Markdown syntax, +[this](https://daringfireball.net/projects/markdown/) is a great resource. -Once a pull request passes review, the reviewer should add a signed comment -stating, "Passed review as of ``" (or similar). The -documentation maintainer then verifies that the pull request is mechanically -sound (no merge conflicts, broken links, ANSI escapes, etc.). If so, the -documentation maintainer then merges the pull request, adds a PGP-signed tag to -the latest commit (usually the merge commit), then pushes to the remote. In -cases in which another reviewer is not required, the documentation maintainer -may review the pull request (in which case no signed comment is necessary, -since it would be redundant with the signed tag). +### Relative vs. absolute links -## Questions, problems, and improvements +Always use relative rather than absolute paths for internal website links. For +example, use `/doc/documentation-style-guide/` instead of +`https://www.qubes-os.org/doc/documentation-style-guide/`. You may use absolute +URLs in the following cases: -If you have a question about something you read in the documentation, please -send it to the appropriate [mailing list](/support/). If you see that something -in the documentation should be fixed or improved, please -[contribute](#how-to-contribute) the change yourself. To report an issue with -the documentation, please follow our standard [issue reporting -guidelines](/doc/issue-tracking/). (If you report an issue with the -documentation, you will likely be asked to address it, unless there is a clear -indication in your report that you are not willing or able to do so.) +- External links +- URLs that appear inside code blocks (e.g., in comments and document + templates, and the plain text reproductions of [QSBs](/security/qsb/) and + [Canaries](/security/canary/)), since they're not hyperlinks +- Git repo files like `README.md` and `CONTRIBUTING.md`, since they're not part + of the website itself but rather of the auxiliary infrastructure supporting + the website. -## How to contribute +This rule is important because using absolute URLs for internal website links +breaks: -Editing the documentation is easy, so if you see that a change should be made, -please contribute it! +- Serving the website offline +- Website localization +- Generating offline documentation +- Automatically redirecting Tor Browser visitors to the correct page on the + onion service mirror -A few notes before we get started: +### Image linking -- Since Qubes is a security-oriented project, every documentation change will - be [reviewed](#security) before it's accepted. This allows us to maintain - quality control and protect our users. +See [how to add images](/doc/how-to-edit-the-documentation/#how-to-add-images). -- We don't want you to spend time and effort on a contribution that we can't - accept. If your contribution would take a lot of time, please [file an - issue](/doc/issue-tracking/) for it first so that we can make sure we're on - the same page before significant works begins. +Link only to images in +[qubes-attachment](https://github.com/QubesOS/qubes-attachment). Do not link to +images on other websites. -- Alternatively, you may already have written content that doesn't conform to - these guidelines, but you'd be willing to modify it so that it does. In this - case, you can still submit it by following the instructions below. Just make - a note in your pull request (PR) that you're aware of the changes that need - to be made and that you're just asking for the content to be reviewed before - you spend time making those changes. +### HTML and CSS -- Finally, if you've written something that doesn't belong in qubes-doc but that - would be beneficial to the Qubes community, please consider adding it to the - [external documentation](/doc/doc-guidelines/#core-vs-external-documentation). +Do not write HTML inside Markdown documents (except in rare, unavoidable cases, +such as alerts). In particular, never include HTML or CSS for styling, +formatting, or white space control. That belongs in the (S)CSS files instead. -As mentioned above, we keep all the documentation in a dedicated [Git -repository](https://github.com/QubesOS/qubes-doc) hosted on -[GitHub](https://github.com/). Thanks to GitHub's interface, you can edit the -documentation even if you don't know Git at all! The only thing you need is a -GitHub account, which is free. +### Headings -(**Note:** If you're already familiar with GitHub or wish to work from the -command line, you can skip the rest of this section. All you need to do to -contribute is to [fork and -clone](https://guides.github.com/activities/forking/) the -[qubes-doc](https://github.com/QubesOS/qubes-doc) repo, make your changes, then -[submit a pull -request](https://help.github.com/articles/using-pull-requests/).) +Do not use `h1` headings (single `#` or `======` underline). These are +automatically generated from the `title:` line in the YAML frontmatter. -Ok, let's start. Every documentation page has a "Page Source on GitHub" button. -Depending on the size of your screen, it may either be on the side (larger -screens) or on the bottom (smaller screens). +Use Atx-style syntax for headings: `##h 2`, `### h3`, etc. Do not use +underlining syntax (`-----`). -[![page-source-button](/attachment/doc/doc-pr_01_page-source-button.png)](/attachment/doc/doc-pr_01_page-source-button.png) +### Hyperlink syntax -When you click on it, you'll be taken to the source file --- usually a Markdown -(`.md`) file --- on GitHub. On this page, there will be a button to edit the -file. +Use non-reference-style links like `[website](https://example.com/)`. Do *not* +use reference-style links like `[website][example]`, `[website][]` or +`[website]`. This facilitates the localization process. -[![github-edit](/attachment/doc/doc-pr_02_github-edit.png)](/attachment/doc/doc-pr_02_github-edit.png) +### Indentation -You'll be prompted to sign in with your GitHub username and password -(if you aren't already logged in). You can also create a free account from here. +Use spaces instead of tabs. Use hanging indentations where appropriate. -[![github-sign-in](/attachment/doc/doc-pr_03_sign-in.png)](/attachment/doc/doc-pr_03_sign-in.png) +### Lists -If this is your first contribution to the documentation, you need to "fork" the -repository (make your own copy). It's easy --- just click the big green button -on the next page. This step is only needed the first time you make a -contribution. +If appropriate, make numerals in numbered lists match between Markdown source +and HTML output. Some users read the Markdown source directly, and this makes +numbered lists easier to follow. -[![fork](/attachment/doc/doc-pr_04_fork.png)](/attachment/doc/doc-pr_04_fork.png) +### Code blocks -Now you can make your modifications. You can also preview the changes to see -how they'll be formatted by clicking the "Preview changes" tab. If you want to -add images, please see [How to add images](#how-to-add-images). If you're -making formatting changes, please [render the site -locally](https://github.com/QubesOS/qubesos.github.io#instructions) to verify -that everything looks correct before submitting any changes. +When writing code blocks, use [syntax +highlighting](https://github.github.com/gfm/#info-string) where possible (see +[here](https://github.com/jneen/rouge/wiki/List-of-supported-languages-and-lexers) +for a list of supported languages). Use `[...]` for anything omitted. -[![edit](/attachment/doc/doc-pr_05_edit.png)](/attachment/doc/doc-pr_05_edit.png) +### Line wrapping -Once you're finished, describe your changes at the bottom and click "Propose -file change". +Hard wrap Markdown lines at 80 characters, unless the line can't be broken +(e.g., code or a URL). -[![commit](/attachment/doc/doc-pr_06_commit-msg.png)](/attachment/doc/doc-pr_06_commit-msg.png) +## Writing guidelines -After that, you'll see exactly what modifications you've made. At this stage, -those changes are still in your own copy of the documentation ("fork"). If -everything looks good, send those changes to us by pressing the "Create pull -request" button. +### Correct use of terminology -[![pull-request](/attachment/doc/doc-pr_07_review-changes.png)](/attachment/doc/doc-pr_07_review-changes.png) +Familiarize yourself with the terms defined in the [glossary](/doc/glossary/). +Use these terms consistently and accurately throughout your writing. -You will be able to adjust the pull request message and title there. In most -cases, the defaults are ok, so you can just confirm by pressing the "Create -pull request" button again. However, if you're not ready for your PR to be -reviewed or merged yet, please [make a draft PR -instead](https://github.blog/2019-02-14-introducing-draft-pull-requests/). +### Sentence case in headings -[![pull-request-confirm](/attachment/doc/doc-pr_08_create-pull-request.png)](/attachment/doc/doc-pr_08_create-pull-request.png) +Use sentence case (rather than title case) in headings for the reasons +explained +[here](https://www.sallybagshaw.com.au/articles/sentence-case-v-title-case/). +In particular, since the authorship of the Qubes documentation is decentralized +and widely distributed among users from around the world, many contributors +come from regions with different conventions for implementing title case, not +to mention that there are often differing style guide recommendations even +within a single region. It is much easier for all of us to implement sentence +case consistently across our growing body of pages, which is very important for +managing the ongoing maintenance burden and sustainability of the +documentation. -If any of your changes should be reflected in the [documentation index (a.k.a. -table of contents)](/doc/) --- for example, if you're adding a new page, -changing the title of an existing page, or removing a page --- please see [How -to edit the documentation index](#how-to-edit-the-documentation-index). +### Writing command-line examples -That's all! We will review your changes. If everything looks good, we'll pull -them into the official documentation. Otherwise, we may have some questions for -you, which we'll post in a comment on your pull request. (GitHub will -automatically notify you if we do.) If, for some reason, we can't accept your -pull request, we'll post a comment explaining why we can't. +When providing command-line examples: -[![done](/attachment/doc/doc-pr_09_done.png)](/attachment/doc/doc-pr_09_done.png) +- Tell the reader where to open a terminal (dom0 or a specific domU), and show + the command along with its output (if any) in a code block, e.g.: -### How to edit the documentation index + ~~~markdown + Open a terminal in dom0 and run: + ```shell_session + $ cd test + $ echo Hello + Hello + ``` + ~~~ -The source file for the [documentation index (a.k.a. table of contents)](/doc/) -lives here: +- Precede each command with the appropriate command prompt: At a minimum, the + prompt should contain a trailing `#` (for the user `root`) or `$` (for other + users) on Linux systems and `>` on Windows systems, respectively. - +- Don't try to add comments inside the code block. For example, *don't* do + this: -Editing this file will change what appears on the documentation index. If your -pull request (PR) adds, removes, or edits anything that should be reflected in -the documentation index, please make sure you also submit an associated pull -request against this file. + ~~~markdown + Open a terminal in dom0 and run: + ```shell_session + # Navigate to the new directory + $ cd test + # Generate a greeting + $ echo Hello + Hello + ``` + ~~~ -### How to add images + The `#` symbol preceding each comment is ambiguous with a root command + prompt. Instead, put your comments *outside* of the code block in normal + prose. -To add an image to a page, use the following syntax in the main document. This -will make the image a hyperlink to the image file, allowing the reader to click -on the image in order to view the image by itself. +### Variable names in commands -``` -[![Image Title](/attachment/doc/image.png)](/attachment/doc/image.png) -``` +Syntactically distinguish variables in commands. For example, this is +ambiguous: -Then, submit your image(s) in a separate pull request to the -[qubes-attachment](https://github.com/QubesOS/qubes-attachment) repository -using the same path and filename. This is the only permitted way to include -images. Do not link to images on other websites. + $ qvm-run --dispvm=disposable-template --service qubes.StartApp+xterm + +It should instead be: + + $ qvm-run --dispvm= --service qubes.StartApp+xterm + +Note that we syntactically distinguish variables in three ways: + +1. Surrounding them in angled brackets (`< >`) +2. Using underscores (`_`) instead of spaces between words +3. Using all capital letters + +We have observed that many novices make the mistake of typing the surrounding +angled brackets (`< >`) on the command line, even after substituting the +desired real value between them. Therefore, in documentation aimed at novices, +we also recommend clarifying that the angled brackets should not be typed. This +can be accomplished in one of several ways: + +- Explicitly say something like "without the angled brackets." +- Provide an example command using real values that excludes the angled + brackets. +- If you know that almost all users will want to use (or should use) a specific + command containing all real values and no variables, you might consider + providing exactly that command and forgoing the version with variables. + Novices may not realize which parts of the command they can substitute with + different values, but if you've correctly judged that they should use the + command you've provided as is, then this shouldn't matter. ## Organizational guidelines @@ -284,7 +291,7 @@ background information. ### Version-specific documentation -*See [#5308](https://github.com/QubesOS/qubes-issues/issues/5308) for potential +*See [#5308](https://github.com/QubesOS/qubes-issues/issues/5308) for pending changes to this policy.* We maintain only one set of documentation for Qubes OS. We do not maintain a @@ -418,245 +425,7 @@ search results wouldn't be populated with out-of-date information.) For further discussion about version-specific documentation in Qubes, see [here](https://groups.google.com/d/topic/qubes-users/H9BZX4K9Ptk/discussion). -## Style guidelines - -### Correct use of terminology - -Familiarize yourself with the terms defined in the [glossary](/doc/glossary/). -Use these terms consistently and accurately throughout your writing. - -### Variables in commands - -Syntactically distinguish variables in commands. For example, this is -ambiguous: - - $ qvm-run --dispvm=disposable-template --service qubes.StartApp+xterm - -It should instead be: - - $ qvm-run --dispvm= --service qubes.StartApp+xterm - -Note that we syntactically distinguish variables in three ways: -1. Surrounding them in angled brackets (`< >`) -2. Using underscores (`_`) instead of spaces between words -3. Using all capital letters - -We have observed that many novices make the mistake of typing the surrounding -angled brackets (`< >`) on the command line, even after substituting the -desired real value between them. Therefore, in documentation aimed at novices, -we also recommend clarifying that the angled brackets should not be typed. This -can be accomplished in one of several ways: -- Explicitly say something like "without the angled brackets." -- Provide an example command using real values that excludes the angled - brackets. -- If you know that almost all users will want to use (or should use) a specific - command containing all real values and no variables, you might consider - providing exactly that command and forgoing the version with variables. - Novices may not realize which parts of the command they can substitute with - different values, but if you've correctly judged that they should use the - command you've provided as is, then this shouldn't matter. - -## Markdown conventions - -All the documentation is written in Markdown for maximum accessibility. When -making contributions, please observe the following style conventions. If you're -not familiar with Markdown syntax, -[this](https://daringfireball.net/projects/markdown/) is a great resource. - -### Indentation - -Use spaces instead of tabs. Each indentation step should be exactly two (2) -spaces. - -### HTML and CSS - -Do not write HTML inside Markdown documents (except in rare, unavoidable cases, -such as alerts). In particular, never include HTML or CSS for styling, -formatting, or white space control. That belongs in the (S)CSS files instead. - -### Image linking - -Link only to images in -[qubes-attachment](https://github.com/QubesOS/qubes-attachment) (see -[instructions above](#how-to-add-images)). Do not link to images on other -websites. - -### Relative vs. absolute links - -Always use relative rather than absolute paths for internal website links. For -example, use `/doc/doc-guidelines/` instead of -`https://www.qubes-os.org/doc/doc-guidelines/`. Places where it's fine to use -absolute URLs: -- External links -- URLs that appear inside code blocks (e.g., in comments and document - templates, and the plain text reproductions of [QSBs](/security/qsb/) and - [Canaries](/security/canary/)), since they're not hyperlinks -- Git repo files like `README.md` and `CONTRIBUTING.md`, since they're not part - of the website itself but rather of the auxiliary infrastructure supporting - the website. - -This rule is important, because using absolute URLs for internal website links -is known to break the following: -- Serving the website offline -- Website localization -- Generating offline documentation -- Automatically redirecting Tor Browser visitors to the correct page on the - onion service mirror. - -### Source formatting and syntax - -- Do not use `h1` headings (single `#` or `======` underline). These are - automatically generated from the `title:` line in the YAML frontmatter. - -- Use Atx-style headings: , `##h 2`, `### h3`, etc. - -- Use non-reference-style links like `[website](https://example.com/)`. Do - *not* use reference links like `[website][example]`, `[website][]` or - `[website]`. - -- If appropriate, make numerals in numbered lists match between Markdown source - and HTML output. (Rationale: In the event that a user is required to read the - Markdown source directly, this will make it easier to follow, e.g., numbered - steps in a set of instructions.) - -- When writing code blocks, use [syntax - highlighting](https://github.github.com/gfm/#info-string) where - [possible](https://github.com/jneen/rouge/wiki/List-of-supported-languages-and-lexers) - and use `[...]` for anything omitted. - -- Use hanging indentations where appropriate. - -### Writing command-line examples - -When providing command line examples: -- Tell the reader where to open a terminal (dom0 or a specific domU), and show - the command along with its output (if any) in a code block, e.g.: - - ~~~markdown - Open a terminal in dom0 and run: - ```shell_session - $ cd test - $ echo Hello - Hello - ``` - ~~~ - -- Precede each command with the appropriate command prompt: At a minimum, the - prompt should contain a trailing `#` (for the user `root`) or `$` (for other - users) on Linux systems and `>` on Windows systems, respectively. - -- Don't try to add comments inside the code block. For example, *don't* do - this: - - ~~~markdown - Open a terminal in dom0 and run: - ```shell_session - # Navigate to the new directory - $ cd test - # Generate a greeting - $ echo Hello - Hello - ``` - ~~~ - - The `#` symbol preceding each comment is ambiguous with a root command - prompt. Instead, put your comments *outside* of the code block in normal - prose. - -### Line wrapping - -Hard wrap Markdown lines at 80 characters, unless the line can't be broken -(e.g., code or a URL). - -## Coding conventions - -The following conventions apply to the website as a whole, including everything -written in HTML, CSS, YAML, and Liquid. These conventions are intended to keep -the codebase consistent when multiple collaborators are working on it. They -should be understood as a practical set of rules for maintaining order in this -specific codebase rather than as a statement of what is objectively right or -good. - -### General practices - -- Use comments to indicate the purposes of different blocks of code. This makes - the file easier to understand and navigate. - -- Use descriptive variable names. Never use one or two letter variable names. - Avoid obscure abbreviations and made-up words. - -- In general, make it easy for others to read your code. Your future self will - thank you, and so will your collaborators! - -- [Don't Repeat Yourself - (DRY)!](https://en.wikipedia.org/wiki/Don%27t_repeat_yourself) Instead of - repeating the same block of code multiple times, abstract it out into a - separate file and `include` that file where you need it. - -### Whitespace - -- Always use spaces. Never use tabs. - -- Each indentation step should be exactly two (2) spaces. - -- Whenever you add an opening tag, indent the following line. (Exception: If - you open and close the tag on the same line, do not indent the following - line.) - -- Indent Liquid the same way as HTML. - -- In general, the starting columns of every adjacent pair of lines should be no - more than two spaces apart (example below). - -- No blank or empty lines. (Hint: When you feel you need one, add a comment on - that line instead.) - -#### Indentation example - -Here's an example that follows the indentation rules: - -{% raw %} -```html - - - - {% for item in secs.htmlsections[0].columns %} - - {% endfor %} - - {% for canary in site.data.sec-canary reversed %} - - - - - - {% endfor %} -
{{ item.title }}
{{ canary.date }}Qubes Canary #{{ canary.canary }}
-``` -{% endraw %} - ## Git conventions -Please try to write good commit messages, according to the [instructions in our -coding style guidelines](/doc/coding-style/#commit-message-guidelines). - -## Continuous Integration (CI) - -The following commands may be useful as a way to interact with our CI -infrastructure. Note that special permissions may be required to use some of -these commands. These commands are generally issued by adding a comment to a -pull request (PR) containing only the command. - -- `PipelineRetry`: Attempts to run the entire build pipeline over again. This - can be useful if CI incorrectly uses a stale branch instead of testing the PR - as if it were merged into `master`. - -- `TestDeploy`: Deploys a test website, which is a live version of the Qubes - website as if this PR had been merged. This can be useful for previewing a PR - on a live public website. **Note:** You must wait for the site to finish - building before issuing this command, or else it will deploy an empty - website. To find the URL of the test website, look for text similar to "This - branch was successfully deployed" and a button named something like "View - deployment." Note that there are two different testing sites: `wwwtest` is - manually updated, whereas `wwwpreview` is managed by the `TestDeploy` - command. +Please follow our [Git commit message +guidelines](/doc/coding-style/#commit-message-guidelines). diff --git a/developer/general/how-to-edit-the-documentation.md b/developer/general/how-to-edit-the-documentation.md new file mode 100644 index 00000000..f8e5cab7 --- /dev/null +++ b/developer/general/how-to-edit-the-documentation.md @@ -0,0 +1,190 @@ +--- +lang: en +layout: doc +permalink: /doc/how-to-edit-the-documentation/ +title: How to Edit the Documentation +--- + +Qubes OS documentation pages are stored as plain text Markdown files in the +[qubes-doc](https://github.com/QubesOS/qubes-doc) repository. By cloning and +regularly pulling from this repo, users can maintain their own up-to-date +offline copy of all Qubes documentation rather than relying solely on the web. + +The documentation is a volunteer community effort. People like you are +constantly working to make it better. If you notice something that can be fixed +or improved, please follow the steps below to open a pull request! + +## How to submit a pull request + +We keep all the documentation in +[qubes-doc](https://github.com/QubesOS/qubes-doc), a dedicated Git repository +hosted on [GitHub](https://github.com/). Thanks to GitHub's easy web interface, +you can edit the documentation even if you're not familiar with Git or the +command line! All you need is a free GitHub account. + +A few notes before we get started: + +- Since Qubes is a security-oriented project, every documentation change will + be [reviewed](#security) before it's accepted. This allows us to maintain + quality control and protect our users. + +- To give your contribution a better chance of being accepted, please follow + our [documentation style guide](/doc/documentation-style-guide/). + +- We don't want you to spend time and effort on a contribution that we can't + accept. If your contribution would take a lot of time, please [file an + issue](/doc/issue-tracking/) for it first so that we can make sure we're on + the same page before significant works begins. + +- Alternatively, you may already have written content that doesn't conform to + these guidelines, but you'd be willing to modify it so that it does. In this + case, you can still submit it by following the instructions below. Just make + a note in your pull request (PR) that you're aware of the changes that need + to be made and that you're just asking for the content to be reviewed before + you spend time making those changes. + +- Finally, if you've written something that doesn't belong in qubes-doc but + that would be beneficial to the Qubes community, please consider adding it to + the [external + documentation](/doc/documentation-style-guide/#core-vs-external-documentation). + +(**Advanced users:** If you're already familiar with GitHub or wish to work +from the command line, you can skip the rest of this section. All you need to +do to contribute is to [fork and +clone](https://guides.github.com/activities/forking/) the +[qubes-doc](https://github.com/QubesOS/qubes-doc) repo, make your changes, then +[submit a pull +request](https://help.github.com/articles/using-pull-requests/).) + +Ok, let's begin. Every documentation page has a "Page Source on GitHub" button. +Depending on the size of your screen, it may either be on the side (larger +screens) or on the bottom (smaller screens). + +[![page-source-button](/attachment/doc/doc-pr_01_page-source-button.png)](/attachment/doc/doc-pr_01_page-source-button.png) + +When you click on it, you'll be taken to the source file --- usually a Markdown +(`.md`) file --- on GitHub. On this page, there will be a button to edit the +file. + +[![github-edit](/attachment/doc/doc-pr_02_github-edit.png)](/attachment/doc/doc-pr_02_github-edit.png) + +You'll be prompted to sign in with your GitHub username and password +(if you aren't already logged in). You can also create a free account from here. + +[![github-sign-in](/attachment/doc/doc-pr_03_sign-in.png)](/attachment/doc/doc-pr_03_sign-in.png) + +If this is your first contribution to the documentation, you need to "fork" the +repository (make your own copy). It's easy --- just click the big green button +on the next page. This step is only needed the first time you make a +contribution. + +[![fork](/attachment/doc/doc-pr_04_fork.png)](/attachment/doc/doc-pr_04_fork.png) + +Now you can make your modifications. You can also preview the changes to see +how they'll be formatted by clicking the "Preview changes" tab. If you want to +add images, please see [How to add images](#how-to-add-images). If you're +making formatting changes, please [render the site +locally](https://github.com/QubesOS/qubesos.github.io#instructions) to verify +that everything looks correct before submitting any changes. + +[![edit](/attachment/doc/doc-pr_05_edit.png)](/attachment/doc/doc-pr_05_edit.png) + +Once you're finished, describe your changes at the bottom and click "Propose +file change". + +[![commit](/attachment/doc/doc-pr_06_commit-msg.png)](/attachment/doc/doc-pr_06_commit-msg.png) + +After that, you'll see exactly what modifications you've made. At this stage, +those changes are still in your own copy of the documentation ("fork"). If +everything looks good, send those changes to us by pressing the "Create pull +request" button. + +[![pull-request](/attachment/doc/doc-pr_07_review-changes.png)](/attachment/doc/doc-pr_07_review-changes.png) + +You will be able to adjust the pull request message and title there. In most +cases, the defaults are ok, so you can just confirm by pressing the "Create +pull request" button again. However, if you're not ready for your PR to be +reviewed or merged yet, please [make a draft PR +instead](https://github.blog/2019-02-14-introducing-draft-pull-requests/). + +[![pull-request-confirm](/attachment/doc/doc-pr_08_create-pull-request.png)](/attachment/doc/doc-pr_08_create-pull-request.png) + +If any of your changes should be reflected in the [documentation index (a.k.a. +table of contents)](/doc/) --- for example, if you're adding a new page, +changing the title of an existing page, or removing a page --- please see [How +to edit the documentation index](#how-to-edit-the-documentation-index). + +That's all! We will review your changes. If everything looks good, we'll pull +them into the official documentation. Otherwise, we may have some questions for +you, which we'll post in a comment on your pull request. (GitHub will +automatically notify you if we do.) If, for some reason, we can't accept your +pull request, we'll post a comment explaining why we can't. + +[![done](/attachment/doc/doc-pr_09_done.png)](/attachment/doc/doc-pr_09_done.png) + +## How to edit the documentation index + +The source file for the [documentation index (a.k.a. table of contents)](/doc/) +lives here: + + + +Editing this file will change what appears on the documentation index. If your +pull request (PR) adds, removes, or edits anything that should be reflected in +the documentation index, please make sure you also submit an associated pull +request against this file. + +## How to add images + +To add an image to a page, use the following syntax in the main document. This +will make the image a hyperlink to the image file, allowing the reader to click +on the image in order to view the image by itself. + +``` +[![Image Title](/attachment/doc/image.png)](/attachment/doc/image.png) +``` + +Then, submit your image(s) in a separate pull request to the +[qubes-attachment](https://github.com/QubesOS/qubes-attachment) repository +using the same path and filename. This is the only permitted way to include +images. Do not link to images on other websites. + +## Security + +*Also see: [Should I trust this website?](/faq/#should-i-trust-this-website)* + +All pull requests (PRs) against +[qubes-doc](https://github.com/QubesOS/qubes-doc) must pass review prior to be +merged, except in the case of [external +documentation](/doc/#external-documentation) (see +[#4693](https://github.com/QubesOS/qubes-issues/issues/4693)). This process is +designed to ensure that contributed text is accurate and non-malicious. This +process is a best effort that should provide a reasonable degree of assurance, +but it is not foolproof. For example, all text characters are checked for ANSI +escape sequences. However, binaries, such as images, are simply checked to +ensure they appear or function the way they should when the website is +rendered. They are not further analyzed in an attempt to determine whether they +are malicious. + +Once a pull request passes review, the reviewer should add a signed comment +stating, "Passed review as of ``" (or similar). The +documentation maintainer then verifies that the pull request is mechanically +sound (no merge conflicts, broken links, ANSI escapes, etc.). If so, the +documentation maintainer then merges the pull request, adds a PGP-signed tag to +the latest commit (usually the merge commit), then pushes to the remote. In +cases in which another reviewer is not required, the documentation maintainer +may review the pull request (in which case no signed comment is necessary, +since it would be redundant with the signed tag). + +## Questions, problems, and improvements + +If you have a question about something you read in the documentation or about +how to edit the documentation, please post it on the +[forum](https://forum.qubes-os.org/) or send it to the appropriate [mailing +list](/support/). If you see that something in the documentation should be +fixed or improved, please [contribute](#how-to-submit-a-pull-request) the +change yourself. To report an issue with the documentation, please follow our +standard [issue reporting guidelines](/doc/issue-tracking/). (If you report an +issue with the documentation, you will likely be asked to submit a pull request +for it, unless there is a clear indication in your report that you are not +willing or able to do so.) diff --git a/developer/general/style-guide.md b/developer/general/style-guide.md index ed5b0c47..8fdf3148 100644 --- a/developer/general/style-guide.md +++ b/developer/general/style-guide.md @@ -1,7 +1,9 @@ --- lang: en layout: doc -permalink: /doc/style-guide/ +permalink: /doc/visual-style-guide/ +redirect_from: +- /doc/style-guide/ ref: 27 -title: Style Guide +title: Visual Style Guide --- diff --git a/developer/general/usability-ux.md b/developer/general/usability-ux.md index 75748bcc..5e0c5359 100644 --- a/developer/general/usability-ux.md +++ b/developer/general/usability-ux.md @@ -8,7 +8,7 @@ title: Usability & UX Software that is too complicated to use, is often unused. Because we want as many people as possible to benefit from its unique security properties, the usability and user experience of Qubes OS is an utmost priority! -We ask anyone developing for Qubes OS to please read through this guide to better understand the user experience we strive to achieve. We also ask them to review [our style guide](/doc/style-guide/) for other design related information. +We ask anyone developing for Qubes OS to please read through this guide to better understand the user experience we strive to achieve. We also ask them to review [our visual style guide](/doc/visual-style-guide/) for other design related information. --- diff --git a/developer/general/website-style-guide.md b/developer/general/website-style-guide.md new file mode 100644 index 00000000..4e0ce43c --- /dev/null +++ b/developer/general/website-style-guide.md @@ -0,0 +1,78 @@ +--- +lang: en +layout: doc +permalink: /doc/website-style-guide/ +title: Website Style Guide +--- + +This page explains the standards we follow for building and maintaining the +website. Please follow these guidelines and conventions when modifying the +website. For the standards governing the documentation in particular, please +see the [documentation style guide](/doc/documentation-style-guide/). + +## Coding conventions + +The following conventions apply to the website as a whole, including everything +written in HTML, CSS, YAML, and Liquid. These conventions are intended to keep +the codebase consistent when multiple collaborators are working on it. They +should be understood as a practical set of rules for maintaining order in this +specific codebase rather than as a statement of what is objectively right or +good. + +### General practices + +- Use comments to indicate the purposes of different blocks of code. This makes + the file easier to understand and navigate. + +- Use descriptive variable names. Never use one or two letter variable names. + Avoid obscure abbreviations and made-up words. + +- In general, make it easy for others to read your code. Your future self will + thank you, and so will your collaborators! + +- [Don't Repeat Yourself + (DRY)!](https://en.wikipedia.org/wiki/Don%27t_repeat_yourself) Instead of + repeating the same block of code multiple times, abstract it out into a + separate file and `include` that file where you need it. + +### Whitespace + +- Always use spaces. Never use tabs. + +- Each indentation step should be exactly two (2) spaces. + +- Whenever you add an opening tag, indent the following line. (Exception: If + you open and close the tag on the same line, do not indent the following + line.) + +- Indent Liquid the same way as HTML. + +- In general, the starting columns of every adjacent pair of lines should be no + more than two spaces apart (example below). + +- No blank or empty lines. (Hint: When you feel you need one, add a comment on + that line instead.) + +#### Indentation example + +Here's an example that follows the indentation rules: + +{% raw %} +```html + + + + {% for item in secs.htmlsections[0].columns %} + + {% endfor %} + + {% for canary in site.data.sec-canary reversed %} + + + + + + {% endfor %} +
{{ item.title }}
{{ canary.date }}Qubes Canary #{{ canary.canary }}
+``` +{% endraw %} diff --git a/introduction/contributing.md b/introduction/contributing.md index e6eba1d9..baa2842b 100644 --- a/introduction/contributing.md +++ b/introduction/contributing.md @@ -24,7 +24,7 @@ ways in which you can help: * Record [video tours](/video-tours/) * Create [artwork](https://github.com/QubesOS/qubes-artwork) (plymouth themes, installer themes, wallpapers, etc.) -* [Write and edit the documentation](/doc/doc-guidelines) +* [Write and edit the documentation](/doc/how-to-edit-the-documentation) * [Donate](/donate/) to the project * If you represent an organization, become a [Qubes partner](/partners/) * Add a [Qubes download mirror](/downloads/mirrors/) diff --git a/introduction/faq.md b/introduction/faq.md index 373d11c5..ec9a84e2 100644 --- a/introduction/faq.md +++ b/introduction/faq.md @@ -267,7 +267,9 @@ Please see the coreboot website / their IRC channel for further information. ### How should I report documentation issues? -Please see the [documentation guidelines](/doc/doc-guidelines). +If you can fix the problem yourself, please see [how to edit the +documentation](/doc/how-to-edit-the-documentation). If not, please see [issue +tracking](/doc/issue-tracking). ### Will Qubes seek to get certified under the GNU Free System Distribution Guidelines (GNU FSDG)? @@ -279,7 +281,7 @@ This website is hosted on [GitHub Pages](https://pages.github.com/) ([why?](#why Therefore, it is largely outside of our control. We don't consider this a problem, however, since we explicitly [distrust the infrastructure](#what-does-it-mean-to-distrust-the-infrastructure). For this reason, we don't think that anyone should place undue trust in the live version of this site on the Web. -Instead, if you want to obtain your own trustworthy copy of this website in a secure way, you should clone our [website repo](https://github.com/QubesOS/qubesos.github.io), [verify the PGP signatures on the commits and/or tags](/security/verifying-signatures/#how-to-verify-qubes-repos) signed by the [doc-signing keys](https://github.com/QubesOS/qubes-secpack/tree/master/keys/doc-signing) (which indicates that the content has undergone review per our [documentation guidelines](/doc/doc-guidelines)), then either [render the site on your local machine](https://github.com/QubesOS/qubesos.github.io/blob/master/README.md#instructions) or simply read the source, the vast majority of which was [intentionally written in Markdown so as to be readable as plain text for this very reason](/doc/doc-guidelines/#markdown-conventions). +Instead, if you want to obtain your own trustworthy copy of this website in a secure way, you should clone our [website repo](https://github.com/QubesOS/qubesos.github.io), [verify the PGP signatures on the commits and/or tags](/security/verifying-signatures/#how-to-verify-qubes-repos) signed by the [doc-signing keys](https://github.com/QubesOS/qubes-secpack/tree/master/keys/doc-signing) (which indicates that the content has undergone [review](/doc/how-to-edit-the-documentation/#security)), then either [render the site on your local machine](https://github.com/QubesOS/qubesos.github.io/blob/master/README.md#instructions) or simply read the source, the vast majority of which was [intentionally written in Markdown so as to be readable as plain text for this very reason](/doc/documentation-style-guide/#markdown-conventions). We've gone to special effort to set all of this up so that no one has to trust the infrastructure and so that the contents of this website are maximally available and accessible. ### What does it mean to "distrust the infrastructure"? diff --git a/introduction/getting-started.md b/introduction/getting-started.md index 293131c0..6b932519 100644 --- a/introduction/getting-started.md +++ b/introduction/getting-started.md @@ -249,4 +249,4 @@ GitHub](https://github.com/QubesOS). ## Documentation Peruse our extensive library of [documentation](/doc/) for users and developers -of Qubes OS. You can even [help us improve it](/doc/doc-guidelines/)! +of Qubes OS. You can even [help us improve it](/doc/how-to-edit-the-documentation/)! diff --git a/introduction/issue-tracking.md b/introduction/issue-tracking.md index 91b7c737..29ed0424 100644 --- a/introduction/issue-tracking.md +++ b/introduction/issue-tracking.md @@ -34,9 +34,9 @@ Support, Mailing Lists, and Forum](/support/). ### I see something that should be changed in the documentation. -We encourage you to submit the change yourself! Please see the [Documentation -Guidelines](/doc/doc-guidelines/) for instructions on how to do so. If it's -something you can't do yourself, please proceed to open an issue. +We encourage you to submit the change yourself! Please see the [how to edit the +documentation](/doc/how-to-edit-the-documentation/) for instructions on how to +do so. If it's something you can't do yourself, please proceed to open an issue. ### I would like to report a security vulnerability. @@ -352,12 +352,3 @@ which means, "The fix has been released for the testing release but is pending backport to the stable release." Our infrastructure will attempt to apply this label automatically, when appropriate, but it is not perfect, and the developers may be need to adjust it manually. - -## See also - -- [Help, Support, Mailing Lists, and Forum](/support/) -- [Testing New Releases and Updates](/doc/testing/) -- [How to Contribute](/doc/contributing/) -- [Contributing Code](/doc/contributing/#contributing-code) -- [Package Contributions](/doc/package-contributions/) -- [Documentation Guidelines](/doc/doc-guidelines/) diff --git a/introduction/support.md b/introduction/support.md index b957d521..16fa2afe 100644 --- a/introduction/support.md +++ b/introduction/support.md @@ -124,7 +124,7 @@ contributions](/doc/code-signing/). For example, you might find it easier to trust advice from someone who has a proven track record of [contributing software packages](/doc/package-contributions/) or [contributing to the -documentation](/doc/doc-guidelines/). It's unlikely that individuals who have +documentation](/doc/how-to-edit-the-documentation/). It's unlikely that individuals who have worked hard to build good reputations for themselves through their contributions over the years would risk giving malicious advice in signed messages to public mailing lists. Since every contribution to the Qubes OS @@ -217,7 +217,7 @@ not a discussion forum](/doc/issue-tracking/#the-issue-tracker-is-not-a-discussion-forum).) Likewise, if you see that something in the documentation should be changed, don't simply point it out in a discussion venue. Instead, [submit the -change](/doc/doc-guidelines/). +change](/doc/how-to-edit-the-documentation/). ### Moderation diff --git a/user/downloading-installing-upgrading/installation-guide.md b/user/downloading-installing-upgrading/installation-guide.md index 55d7e2cc..384fd21a 100644 --- a/user/downloading-installing-upgrading/installation-guide.md +++ b/user/downloading-installing-upgrading/installation-guide.md @@ -462,7 +462,7 @@ the other [How-To Guides](/doc/#how-to-guides), and learn about useful and user friendly. We urge you to read it! It may very well contain the answers to your questions. (Since the documentation is a community effort, we'd also greatly appreciate your help in - [improving](/doc/doc-guidelines/) it!) + [improving](/doc/how-to-edit-the-documentation/) it!) * If issues arise during installation, see the [Installation Troubleshooting](/doc/installation-troubleshooting) guide. diff --git a/user/templates/minimal-templates.md b/user/templates/minimal-templates.md index ac545690..907a3926 100644 --- a/user/templates/minimal-templates.md +++ b/user/templates/minimal-templates.md @@ -34,7 +34,7 @@ templates, along with some examples of common use cases. bug report. Instead, please see [Help, Support, Mailing Lists, and Forum](/support/) for the appropriate place to ask for help. Once you have learned how to solve your problem, please [contribute what you learned to - the documentation](/doc/doc-guidelines/). + the documentation](/doc/how-to-edit-the-documentation/). 3. The minimal templates are intentionally *minimal*. [Do not ask for your favorite package to be added to the minimal template by