From 8ea5ffc99a1a410042ffeda132339d7c21f73a9a Mon Sep 17 00:00:00 2001 From: Nicco Kunzmann Date: Tue, 26 Jun 2018 09:39:02 +0200 Subject: [PATCH] add success message --- basics_dev/code-signing.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/basics_dev/code-signing.md b/basics_dev/code-signing.md index 8bded0cf..64d31a3b 100644 --- a/basics_dev/code-signing.md +++ b/basics_dev/code-signing.md @@ -134,7 +134,7 @@ The [signature-checker] checks if code contributions are signed. Although GitHub adds a little green `Verified` button next to the commit, the [signature-checker] uses another algorithm. You may see this message: -> Unable to verify (no valid key found) - [signature-checker/check-git-signature line 392](https://github.com/marmarek/signature-checker/blob/d143b8f2b4da828a9a93b91eb972dddb7e28b4f0/check-git-signature#L392) +> policy/qubesos/code-signing — Unable to verify (no valid key found) - [signature-checker/check-git-signature line 392](https://github.com/marmarek/signature-checker/blob/d143b8f2b4da828a9a93b91eb972dddb7e28b4f0/check-git-signature#L392) Which means that the following correct flow was not done in order or is missing steps: @@ -156,7 +156,9 @@ Which means that the following correct flow was not done in order or is missing git push origin branch-name ``` This triggers the check if the commit is signed in the pull request. - Then, the tag is already existent and the [signature-checker] can find it. +5. Then, the tag is already existent and the [signature-checker] can find it. + You can see a message like this: + > policy/qubesos/code-signing — Signed with 9BBAB2DEB1488C99 ### Error Handling