portapack-mayhem/firmware/application/ui/ui_transmitter.hpp
Richard bd781ce37b
Fix for #2538 (#2635)
* Fix for #2538

Fix for #2538
Added on_bandwidth_changed Callback to ui_transmitter.hpp
Modified the field_bw.on_change lambda in the TransmitterView constructor to trigger the on_bandwidth_changed callback
Connected the Callback in ui_siggen.cpp

I am not a C++ programmer so this change was proposed by Gemini AI.

I have built and tested the App and it works as expected and I don't think the change will have any unexpected side effects.

* Fix clang issues

Fix clang issues

* Update ui_transmitter.cpp

typo

* Revised change

The proposed change mirrors the way a change to the frequency (on_edit_frequency) is triggered in ui_siggen by the tx_view.
The bw parameter is not passed because it is stored in _setting in the tx_view and will be read by update_config.
A change to the bw is not checked against auto_update to keep its behaviour consistent with a change to the gain, amplitude or frequency.

* Make changes to the channel_bandwidth dynamic whist playing

Behaviour of channel bandwidth is now consistent with frequency, amp and gain.

* comment edit

* revert hackrf submodule checkpoint to the repo

* comment

---------

Co-authored-by: zxkmm <zxkmm@hotmail.com>
2025-05-02 04:19:41 +00:00

163 lines
No EOL
4.3 KiB
C++

/*
* Copyright (C) 2014 Jared Boone, ShareBrained Technology, Inc.
* Copyright (C) 2016 Furrtek
*
* This file is part of PortaPack.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2, or (at your option)
* any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; see the file COPYING. If not, write to
* the Free Software Foundation, Inc., 51 Franklin Street,
* Boston, MA 02110-1301, USA.
*/
#ifndef __UI_TRANSMITTER_H__
#define __UI_TRANSMITTER_H__
#include "ui.hpp"
#include "ui_navigation.hpp"
#include "ui_painter.hpp"
#include "ui_receiver.hpp"
#include "ui_widget.hpp"
#include "rf_path.hpp"
#include <cstddef>
#include <cstdint>
#include <algorithm>
#include <functional>
namespace ui {
class TXGainField : public NumberField {
public:
std::function<void(void)> on_show_options{};
TXGainField(Point parent_pos);
};
class TransmitterView : public View {
public:
std::function<void(void)> on_edit_frequency{};
std::function<void(void)> on_start{};
std::function<void(void)> on_stop{};
std::function<void(void)> on_bandwidth_changed{};
// TODO: this is a workaround because in the message system,
// we change bw by different message for different m4 bb, so have to callback
// and change in the instance(for instance SigGen app) with calling the instance's bb opration func
TransmitterView(const Coord y, const uint64_t frequency_step, const uint32_t channel_bandwidth, const bool lock);
TransmitterView(
const Coord y,
const uint32_t frequency_step,
const uint32_t channel_bandwidth)
: TransmitterView{y, frequency_step, channel_bandwidth, false} {
}
~TransmitterView();
void on_show() override;
void paint(Painter& painter) override;
void focus() override;
void set_transmitting(const bool transmitting);
private:
const Style& style_start = *Theme::getInstance()->fg_green;
const Style& style_stop = *Theme::getInstance()->fg_red;
const Style& style_locked = *Theme::getInstance()->fg_dark;
bool lock_{false};
bool transmitting_{false};
FrequencyField field_frequency{
{0, 1 * 8}};
Text text_gain{
{0, 3 * 8, 5 * 8, 1 * 16},
"Gain:"};
NumberField field_gain{
{5 * 8, 3 * 8},
2,
{max2837::tx::gain_db_range.minimum, max2837::tx::gain_db_range.maximum},
max2837::tx::gain_db_step,
' '};
Text text_bw{
{18 * 8, 1 * 8, 3 * 8, 1 * 16},
"kHz"};
NumberField field_bw{
{15 * 8, 1 * 8},
3,
{1, 150},
1,
' '};
Text text_amp{
{11 * 8, 3 * 8, 5 * 8, 1 * 16},
"Amp:"};
NumberField field_amp{
{16 * 8, 3 * 8},
2,
{0, 14},
14,
' '};
Button button_start{
{21 * 8, 1 * 8, 9 * 8, 32},
"START"};
FrequencyStepView field_frequency_step{
{10 * 8 - 4, 1 * 8},
};
void on_target_frequency_changed(rf::Frequency f);
void on_channel_bandwidth_changed(uint32_t channel_bandwidth);
void on_tx_gain_changed(int32_t tx_gain);
void on_tx_amp_changed(bool rf_amp);
void update_gainlevel_styles(void);
};
/* Simpler transmitter view that only renders TX Gain and Amp.
* When short_UI is set it abbreviates control labels. */
class TransmitterView2 : public View {
public:
TransmitterView2(Point pos, bool short_ui);
private:
Text text_labels{
{}, // Set in ctor.
{}};
NumberField field_gain{
{}, // Set in ctor.
2,
{max2837::tx::gain_db_range.minimum, max2837::tx::gain_db_range.maximum},
max2837::tx::gain_db_step,
' '};
NumberField field_amp{
{}, // Set in ctor.
2,
{0, 14},
14,
' '};
void update_gainlevel_styles();
};
} /* namespace ui */
#endif /*__UI_TRANSMITTER_H__*/