Git-Mirrors/portapack-mayhem
1
0
Fork 0
mirror of https://github.com/eried/portapack-mayhem.git synced 2025-08-13 08:55:39 -04:00
Code Issues Projects Releases Packages Wiki Activity

Faster app_settings save (#1145)

Browse source 
* No-allocation settings save

* remove fixed TODO

---------

Co-authored-by: kallanreed <kallanreed@outlook.com>
This commit is contained in:
Kyle Reed 2023-06-11 13:35:45 -07:00 • committed by GitHub
parent 8bd3d6249d
commit fff78ce00f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 30 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

11
firmware/application/app_settings.cpp
View file

@ -66,7 +66,15 @@ static void read_setting(
template <typename T>
static void write_setting(File& file, std::string_view setting_name, const T& value) {
file.write_line(std::string{setting_name} + to_string_dec_uint(value));
// NB: Not using file.write_line speed this up. This happens on every
// app exit when enabled so should be fast to keep the UX responsive.
StringFormatBuffer buffer;
size_t length = 0;
auto value_str = to_string_dec_uint(value, buffer, length);
file.write(setting_name.data(), setting_name.length());
file.write(value_str, length);
file.write("\r\n", 2);
}
static fs::path get_settings_path(const std::string& app_name) {
@ -101,7 +109,6 @@ constexpr std::string_view volume = "volume="sv;
// be declaratively bound to a setting and persistence will be magic.
// TODO: radio settings should be pushed and popped to prevent cross-app
// radio bugs caused by sharing a global model.
// TODO: save is slow because of all of the allocations for File.write_line.
ResultCode load_settings(const std::string& app_name, AppSettings& settings) {
if (!portapack::persistent_memory::load_app_settings())