Git-Mirrors/portapack-mayhem
1
0
Fork 0
mirror of https://github.com/eried/portapack-mayhem.git synced 2024-09-20 16:15:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rect: Comment about a bad API method.

Browse Source 
In retrospect, I don't like Rect + Rect = union -- it doesn't make as much sense and isn't as readable as Rect.union(Rect).
This commit is contained in:
Jared Boone 2016-09-07 22:19:30 -07:00
parent f722497b01
commit df0fc30fda
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
firmware/common/ui.cpp
View File

@ -42,6 +42,8 @@ Rect Rect::intersect(const Rect& o) const {
} }
} }
// TODO: This violates the principle of least surprise!
// This does a union, but that might not be obvious from "+=" syntax.
Rect& Rect::operator+=(const Rect& p) { Rect& Rect::operator+=(const Rect& p) {
if( is_empty() ) { if( is_empty() ) {
*this = p; *this = p;