Git-Mirrors/portapack-mayhem
1
0
Fork 0
mirror of https://github.com/eried/portapack-mayhem.git synced 2024-09-20 08:05:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check queue empty only once when reading messages.

Browse Source 
There was a second is_empty() call hidden in the pop() call, so the while(condition) was redundant.
This commit is contained in:
Jared Boone 2015-08-27 14:27:29 -07:00
parent 5d9079f87f
commit d8b3b4cb6b
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
firmware/application/main.cpp
View File

@ -123,12 +123,14 @@ private:
}
void handle_application_queue() {
while( !shared_memory.application_queue.is_empty() ) {
while(true) {
std::array<uint8_t, Message::MAX_SIZE> message_buffer;
const Message* const message = reinterpret_cast<Message*>(message_buffer.data());
const auto message_size = shared_memory.application_queue.pop(message_buffer.data(), message_buffer.size());
if( message_size ) {
context.message_map.send(message);
} else {
break;
}
}
}

4
firmware/baseband/main.cpp
View File

@ -242,12 +242,14 @@ private:
}
void handle_baseband_queue() {
while( !shared_memory.baseband_queue.is_empty() ) {
while(true) {
std::array<uint8_t, Message::MAX_SIZE> message_buffer;
const Message* const message = reinterpret_cast<Message*>(message_buffer.data());
const auto message_size = shared_memory.baseband_queue.pop(message_buffer.data(), message_buffer.size());
if( message_size ) {
message_map.send(message);
} else {
break;
}
}
}