Use CaptureConfig to share state between cores.

Remove awful FIFO_HACK.
TODO: Lots of repeated code...
TODO: Capture thread is signalled too frequently.

firmware/application/capture_thread.hpp

@@ -37,21 +37,28 @@ using namespace hackrf::one;
 
 class StreamOutput {
 public:
-	StreamOutput(
+	StreamOutput() {
-	) : fifo { reinterpret_cast<FIFO<uint8_t>*>(shared_memory.FIFO_HACK) }
+		shared_memory.baseband_queue.push_and_wait(
-	{
+			CaptureConfigMessage { &config }
+		);
+	}
+
+	~StreamOutput() {
+		shared_memory.baseband_queue.push_and_wait(
+			CaptureConfigMessage { nullptr }
+		);
 	}
 
 	size_t available() {
-		return fifo->len();
+		return config.fifo->len();
 	}
 
 	size_t read(void* const data, const size_t length) {
-		return fifo->out(reinterpret_cast<uint8_t*>(data), length);
+		return config.fifo->out(reinterpret_cast<uint8_t*>(data), length);
 	}
 
 private:
-	FIFO<uint8_t>* const fifo;
+	CaptureConfig config;
 };
 
 class CaptureThread {
@@ -66,21 +73,25 @@ public:
 	}
 
 	~CaptureThread() {
-		chThdTerminate(thread);
+		const auto thread_tmp = thread;
-		chEvtSignal(thread, EVT_FIFO_HIGHWATER);
-		const auto success = chThdWait(thread);
 
-		if( !success ) {
+		if( thread_tmp ) {
-			led_tx.on();
+			thread = nullptr;
+			chThdTerminate(thread_tmp);
+			chEvtSignal(thread_tmp, EVT_FIFO_HIGHWATER);
+			const auto success = chThdWait(thread_tmp);
+
+			if( !success ) {
+				led_tx.on();
+			}
 		}
 	}
 
 	static void check_fifo_isr() {
-		if( (shared_memory.FIFO_HACK != nullptr) && (thread != nullptr) ) {
+		// TODO: Prevent over-signalling by transmitting a set of 
-			auto fifo = reinterpret_cast<FIFO<uint8_t>*>(shared_memory.FIFO_HACK);
+		// flags from the baseband core.
-			if( fifo->len() >= write_size ) {
+		if( thread ) {
-				chEvtSignalI(thread, EVT_FIFO_HIGHWATER);
+			chEvtSignalI(thread, EVT_FIFO_HIGHWATER);
-			}
 		}
 	}
 

firmware/application/event_m0.cpp

@@ -255,6 +255,4 @@ void EventDispatcher::init_message_queues() {
 	new (&shared_memory.application_queue) MessageQueue(
 		shared_memory.application_queue_data, SharedMemory::application_queue_k
 	);
-
-	shared_memory.FIFO_HACK = nullptr;
 }

firmware/baseband/proc_am_audio.cpp

@@ -63,6 +63,10 @@ void NarrowbandAMAudio::on_message(const Message* const message) {
 		configure(*reinterpret_cast<const AMConfigureMessage*>(message));
 		break;
 
+	case Message::ID::CaptureConfig:
+		capture_config(*reinterpret_cast<const CaptureConfigMessage*>(message));
+		break;
+		
 	default:
 		break;
 	}
@@ -93,3 +97,11 @@ void NarrowbandAMAudio::configure(const AMConfigureMessage& message) {
 
 	configured = true;
 }
+
+void NarrowbandAMAudio::capture_config(const CaptureConfigMessage& message) {
+	if( message.config ) {
+		audio_output.set_stream(std::make_unique<StreamInput>(14, *message.config));
+	} else {
+		audio_output.set_stream(nullptr);
+	}
+}

firmware/baseband/proc_am_audio.hpp

@@ -72,6 +72,7 @@ private:
 
 	bool configured { false };
 	void configure(const AMConfigureMessage& message);
+	void capture_config(const CaptureConfigMessage& message);
 
 	buffer_f32_t demodulate(const buffer_c16_t& channel);
 };

firmware/baseband/proc_capture.cpp

@@ -44,8 +44,6 @@ CaptureProcessor::CaptureProcessor() {
 	spectrum_samples = 0;
 
 	channel_spectrum.set_decimation_factor(1);
-
-	stream = std::make_unique<StreamInput>(15);
 }
 
 void CaptureProcessor::execute(const buffer_c8_t& buffer) {
@@ -76,7 +74,19 @@ void CaptureProcessor::on_message(const Message* const message) {
 		channel_spectrum.on_message(message);
 		break;
 
+	case Message::ID::CaptureConfig:
+		capture_config(*reinterpret_cast<const CaptureConfigMessage*>(message));
+		break;
+
 	default:
 		break;
 	}
 }
+
+void CaptureProcessor::capture_config(const CaptureConfigMessage& message) {
+	if( message.config ) {
+		stream = std::make_unique<StreamInput>(15, *message.config);
+	} else {
+		stream.reset();
+	}
+}

firmware/baseband/proc_capture.hpp

@@ -61,6 +61,8 @@ private:
 	SpectrumCollector channel_spectrum;
 	size_t spectrum_interval_samples = 0;
 	size_t spectrum_samples = 0;
+
+	void capture_config(const CaptureConfigMessage& message);
 };
 
 #endif/*__PROC_CAPTURE_HPP__*/

firmware/baseband/proc_nfm_audio.cpp

@@ -53,6 +53,10 @@ void NarrowbandFMAudio::on_message(const Message* const message) {
 		configure(*reinterpret_cast<const NBFMConfigureMessage*>(message));
 		break;
 
+	case Message::ID::CaptureConfig:
+		capture_config(*reinterpret_cast<const CaptureConfigMessage*>(message));
+		break;
+		
 	default:
 		break;
 	}
@@ -81,3 +85,11 @@ void NarrowbandFMAudio::configure(const NBFMConfigureMessage& message) {
 
 	configured = true;
 }
+
+void NarrowbandFMAudio::capture_config(const CaptureConfigMessage& message) {
+	if( message.config ) {
+		audio_output.set_stream(std::make_unique<StreamInput>(14, *message.config));
+	} else {
+		audio_output.set_stream(nullptr);
+	}
+}

firmware/baseband/proc_nfm_audio.hpp

@@ -66,6 +66,7 @@ private:
 
 	bool configured { false };
 	void configure(const NBFMConfigureMessage& message);
+	void capture_config(const CaptureConfigMessage& message);
 };
 
 #endif/*__PROC_NFM_AUDIO_H__*/

firmware/baseband/proc_wfm_audio.cpp

@@ -81,6 +81,10 @@ void WidebandFMAudio::on_message(const Message* const message) {
 		configure(*reinterpret_cast<const WFMConfigureMessage*>(message));
 		break;
 
+	case Message::ID::CaptureConfig:
+		capture_config(*reinterpret_cast<const CaptureConfigMessage*>(message));
+		break;
+		
 	default:
 		break;
 	}
@@ -110,3 +114,11 @@ void WidebandFMAudio::configure(const WFMConfigureMessage& message) {
 
 	configured = true;
 }
+
+void WidebandFMAudio::capture_config(const CaptureConfigMessage& message) {
+	if( message.config ) {
+		audio_output.set_stream(std::make_unique<StreamInput>(15, *message.config));
+	} else {
+		audio_output.set_stream(nullptr);
+	}
+}

firmware/baseband/proc_wfm_audio.hpp

@@ -68,6 +68,7 @@ private:
 
 	bool configured { false };
 	void configure(const WFMConfigureMessage& message);
+	void capture_config(const CaptureConfigMessage& message);
 };
 
 #endif/*__PROC_WFM_AUDIO_H__*/

firmware/baseband/stream_input.hpp

@@ -32,18 +32,12 @@
 
 class StreamInput {
 public:
-	StreamInput(const size_t K) :
+	StreamInput(const size_t K, CaptureConfig& config) :
 		K { K },
 		data { std::make_unique<uint8_t[]>(1UL << K) },
 		fifo { data.get(), K }
 	{
-		// TODO: Send stream creation message.
+		config.fifo = &fifo;
-		shared_memory.FIFO_HACK = &fifo;
-	}
-
-	~StreamInput() {
-		// TODO: Send stream distruction message.
-		shared_memory.FIFO_HACK = nullptr;
 	}
 
 	size_t write(const void* const data, const size_t length) {

firmware/common/portapack_shared_memory.hpp

@@ -40,7 +40,6 @@ struct SharedMemory {
 	uint8_t baseband_queue_data[1 << baseband_queue_k];
 	MessageQueue application_queue;
 	uint8_t application_queue_data[1 << application_queue_k];
-	void* FIFO_HACK;
 
 	// TODO: M0 should directly configure and control DMA channel that is
 	// acquiring ADC samples.