From 4b87a8a7dd7b9ad8d6815135be813d1bf50ec1d0 Mon Sep 17 00:00:00 2001 From: GullCode Date: Mon, 18 Apr 2022 22:38:29 +0200 Subject: [PATCH 1/2] Fixed warning: comparison of integer expressions of different signedness --- firmware/common/acars_packet.cpp | 2 +- firmware/common/ais_packet.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/firmware/common/acars_packet.cpp b/firmware/common/acars_packet.cpp index 2cf0366e4..4a0e46bd9 100644 --- a/firmware/common/acars_packet.cpp +++ b/firmware/common/acars_packet.cpp @@ -84,7 +84,7 @@ bool Packet::crc_ok() const { acars_fcs.process_byte(field_crc.read(i, 8)); } - return (acars_fcs.checksum() == field_crc.read(data_length(), fcs_length)); + return (acars_fcs.checksum() == (unsigned)field_crc.read(data_length(), fcs_length)); } size_t Packet::data_and_fcs_length() const { diff --git a/firmware/common/ais_packet.cpp b/firmware/common/ais_packet.cpp index 61fabd89b..c6e7561f5 100644 --- a/firmware/common/ais_packet.cpp +++ b/firmware/common/ais_packet.cpp @@ -191,7 +191,7 @@ bool Packet::crc_ok() const { ais_fcs.process_byte(field_crc.read(i, 8)); } - return (ais_fcs.checksum() == field_crc.read(data_length(), fcs_length)); + return (ais_fcs.checksum() == (unsigned)field_crc.read(data_length(), fcs_length)); } size_t Packet::data_and_fcs_length() const { From 048b2543545bb68b140ea85dddc95dd2134d3f81 Mon Sep 17 00:00:00 2001 From: GullCode Date: Mon, 18 Apr 2022 22:45:16 +0200 Subject: [PATCH 2/2] Fixed uninitialized class members --- firmware/baseband/dsp_hilbert.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/firmware/baseband/dsp_hilbert.hpp b/firmware/baseband/dsp_hilbert.hpp index a4b56cd5d..7687ccb31 100644 --- a/firmware/baseband/dsp_hilbert.hpp +++ b/firmware/baseband/dsp_hilbert.hpp @@ -35,8 +35,8 @@ public: private: uint8_t n = 0; - SOSFilter<5> sos_i; - SOSFilter<5> sos_q; + SOSFilter<5> sos_i = {}; + SOSFilter<5> sos_q = {}; }; } /* namespace dsp */