Git-Mirrors/portapack-mayhem
1
0
Fork 0
mirror of https://github.com/eried/portapack-mayhem.git synced 2025-08-09 07:02:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix for #2538 (#2635)

Browse source 
* Fix for #2538

Fix for #2538
Added on_bandwidth_changed Callback to ui_transmitter.hpp
Modified the field_bw.on_change lambda in the TransmitterView constructor to trigger the on_bandwidth_changed callback
Connected the Callback in ui_siggen.cpp

I am not a C++ programmer so this change was proposed by Gemini AI.

I have built and tested the App and it works as expected and I don't think the change will have any unexpected side effects.

* Fix clang issues

Fix clang issues

* Update ui_transmitter.cpp

typo

* Revised change

The proposed change mirrors the way a change to the frequency (on_edit_frequency) is triggered in ui_siggen by the tx_view.
The bw parameter is not passed because it is stored in _setting in the tx_view and will be read by update_config.
A change to the bw is not checked against auto_update to keep its behaviour consistent with a change to the gain, amplitude or frequency.

* Make changes to the channel_bandwidth dynamic whist playing

Behaviour of channel bandwidth is now consistent with frequency, amp and gain.

* comment edit

* revert hackrf submodule checkpoint to the repo

* comment

---------

Co-authored-by: zxkmm <zxkmm@hotmail.com>
This commit is contained in:
Richard 2025-05-02 05:19:41 +01:00 • committed by GitHub
parent c2e05dea48
commit bd781ce37b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 44 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

6
firmware/application/ui/ui_transmitter.hpp
View file

@ -50,6 +50,10 @@ class TransmitterView : public View {
std::function<void(void)> on_edit_frequency{};
std::function<void(void)> on_start{};
std::function<void(void)> on_stop{};
std::function<void(void)> on_bandwidth_changed{};
// TODO: this is a workaround because in the message system,
// we change bw by different message for different m4 bb, so have to callback
// and change in the instance(for instance SigGen app) with calling the instance's bb opration func
TransmitterView(const Coord y, const uint64_t frequency_step, const uint32_t channel_bandwidth, const bool lock);
TransmitterView(
@ -156,4 +160,4 @@ class TransmitterView2 : public View {
} /* namespace ui */
#endif /*__UI_TRANSMITTER_H__*/
#endif /*__UI_TRANSMITTER_H__*/