From b13081696dcf0f435af53e51f19ed34bdfd998bc Mon Sep 17 00:00:00 2001
From: Jared Boone <jboone@earfeast.com>
Date: Thu, 27 Aug 2015 14:35:17 -0700
Subject: [PATCH] Simplify MessageQueue pop() usage.

---
 firmware/application/main.cpp     | 12 +++---------
 firmware/baseband/main.cpp        | 12 +++---------
 firmware/common/message_queue.hpp |  5 +++--
 3 files changed, 9 insertions(+), 20 deletions(-)

diff --git a/firmware/application/main.cpp b/firmware/application/main.cpp
index a0c9f3c5..64eb515f 100755
--- a/firmware/application/main.cpp
+++ b/firmware/application/main.cpp
@@ -123,15 +123,9 @@ private:
 	}
 
 	void handle_application_queue() {
-		while(true) {
-			std::array<uint8_t, Message::MAX_SIZE> message_buffer;
-			const Message* const message = reinterpret_cast<Message*>(message_buffer.data());
-			const auto message_size = shared_memory.application_queue.pop(message_buffer.data(), message_buffer.size());
-			if( message_size ) {
-				context.message_map.send(message);
-			} else {
-				break;
-			}
+		std::array<uint8_t, Message::MAX_SIZE> message_buffer;
+		while(const Message* const message = shared_memory.application_queue.pop(message_buffer)) {
+			context.message_map.send(message);
 		}
 	}
 
diff --git a/firmware/baseband/main.cpp b/firmware/baseband/main.cpp
index 37455507..82a27049 100755
--- a/firmware/baseband/main.cpp
+++ b/firmware/baseband/main.cpp
@@ -242,15 +242,9 @@ private:
 	}
 
 	void handle_baseband_queue() {
-		while(true) {
-			std::array<uint8_t, Message::MAX_SIZE> message_buffer;
-			const Message* const message = reinterpret_cast<Message*>(message_buffer.data());
-			const auto message_size = shared_memory.baseband_queue.pop(message_buffer.data(), message_buffer.size());
-			if( message_size ) {
-				message_map.send(message);
-			} else {
-				break;
-			}
+		std::array<uint8_t, Message::MAX_SIZE> message_buffer;
+		while(const Message* const message = shared_memory.baseband_queue.pop(message_buffer)) {
+			message_map.send(message);
 		}
 	}
 
diff --git a/firmware/common/message_queue.hpp b/firmware/common/message_queue.hpp
index 0d023f92..dd6ff72b 100644
--- a/firmware/common/message_queue.hpp
+++ b/firmware/common/message_queue.hpp
@@ -47,8 +47,9 @@ public:
 		return push(&message, sizeof(message));
 	}
 
-	size_t pop(void* const buf, const size_t len) {
-		return fifo.out_r(buf, len);
+	const Message* pop(std::array<uint8_t, Message::MAX_SIZE>& buf) {
+		const Message* const p = reinterpret_cast<Message*>(buf.data());
+		return fifo.out_r(buf.data(), buf.size()) ? p : nullptr;
 	}
 
 	size_t len() const {