Git-Mirrors/portapack-mayhem
1
0
Fork 0
mirror of https://github.com/eried/portapack-mayhem.git synced 2025-07-24 07:21:18 -04:00
Code Issues Projects Releases Packages Wiki Activity

Improved Debounce for Encoders (#1837)

Browse source 
* Fix variable type declaration

* Fix typo

* Two-bit encoder debouncing

* Slight optimization

* Comment change
This commit is contained in:
Mark Thompson 2024-01-31 14:13:21 -06:00 • committed by GitHub
parent f59f5dfaa3
commit a2a5fb166e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 41 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

23
firmware/application/hw/debounce.cpp
View file

@ -25,7 +25,7 @@
#include "utility.hpp"
uint8_t Debounce::state() {
bool v = state_to_report_;
uint8_t v = state_to_report_;
simulated_pulse_ = false;
return v;
}
@ -149,3 +149,24 @@ bool Debounce::feed(const uint8_t bit) {
return false;
}
uint8_t EncoderDebounce::state() {
return state_;
}
// Returns TRUE if encoder position phase bits changed (after debouncing)
bool EncoderDebounce::feed(const uint8_t phase_bits) {
history_ = (history_ << 2) | phase_bits;
// Has input been constant for 4 ticks? (phase_bits * 01010101b should be 0x00, 0x55, 0xAA, or 0xFF)
if (history_ == (phase_bits * 0x55)) {
// Has the debounced input value changed?
if (state_ != phase_bits) {
state_ = phase_bits;
return true;
}
}
// Unstable input, or no change
return false;
}