From 7598c25fc84e60a2443e060011f9237c2c4aecb2 Mon Sep 17 00:00:00 2001 From: Brumi-2021 <86470699+Brumi-2021@users.noreply.github.com> Date: Sun, 11 Feb 2024 23:16:29 +0100 Subject: [PATCH] Solves random USB/LSB mode in SSB Mic App (H1R1). (#1882) * Solves random USB/LSB mode in SSB Mic App (H1R1). * format --- firmware/application/radio.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/firmware/application/radio.cpp b/firmware/application/radio.cpp index 5ef06b22..23b5fa44 100644 --- a/firmware/application/radio.cpp +++ b/firmware/application/radio.cpp @@ -116,8 +116,9 @@ void set_direction(const rf::Direction new_direction) { /* TODO: Refactor all the various "Direction" enumerations into one. */ /* TODO: Only make changes if direction changes, but beware of clock enabling. */ - // Prevents ghosting when switching back to RX from TX mode. - hackrf::cpld::load_sram_no_verify(); + // That below code line , was used to prevent RX interf ghosting when switching back to RX from any TX mode, but in recent code. it seems not necessary. + // Deleting that load_sram_no_verify() (or the original , load_sram() ), solves random TX swap I/Q problem in H1R1 , others OK- (and no side effects to all). + // hackrf::cpld::load_sram_no_verify(); // After commit "removed the use of the hackrf cpld eeprom #1732", in a H1R1, Mic App wrong SSB TX with random USB/LSB change. direction = new_direction;