Git-Mirrors/portapack-mayhem
1
0
Fork 0
mirror of https://github.com/eried/portapack-mayhem.git synced 2025-05-12 11:42:13 -04:00
Code Issues Projects Releases Packages Wiki Activity

Improve File error handling. Massive effects...

Browse source 
API is somewhat stolen from Rust std::fs::File. Static factories didn't work out so well, though. Move semantics made my head explode.
TODO: Still a lot of places where errors aren't handled, but it's an improvement...
This commit is contained in:
Jared Boone 2016-05-16 14:01:44 -07:00
parent d905c446bf
commit 682a1706a3
18 changed files with 328 additions and 235 deletions
Download patch file Download diff file Expand all files Collapse all files

18
firmware/application/capture_thread.cpp
View file

@ -98,13 +98,8 @@ CaptureThread::~CaptureThread() {
}
}
Optional<std::string> CaptureThread::error() const {
const auto error = writer->error();
if( error.is_valid() ) {
return { error.value().what() };
} else {
return { };
}
const Optional<File::Error>& CaptureThread::error() const {
return last_error;
}
void CaptureThread::check_fifo_isr() {
@ -118,14 +113,15 @@ void CaptureThread::check_fifo_isr() {
}
}
msg_t CaptureThread::run() {
Optional<File::Error> CaptureThread::run() {
StreamOutput stream { &config };
while( !chThdShouldTerminate() ) {
if( stream.available() ) {
auto buffer = stream.get_buffer();
if( !writer->write(buffer->data(), buffer->size()) ) {
return false;
auto write_result = writer->write(buffer->data(), buffer->size());
if( write_result.is_error() ) {
return write_result.error();
}
stream.release_buffer(buffer);
} else {
@ -133,5 +129,5 @@ msg_t CaptureThread::run() {
}
}
return true;
return { };
}