move Temprature debug app into external (#2411)

* remove commented out code

firmware/application/external/mcu_temperature/main.cpp

@@ -0,0 +1,83 @@
+/*
+ * Copyright (C) 2024 Bernd Herzog
+ *
+ * This file is part of PortaPack.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2, or (at your option)
+ * any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; see the file COPYING.  If not, write to
+ * the Free Software Foundation, Inc., 51 Franklin Street,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#include "ui.hpp"
+#include "mcu_temperature.hpp"
+#include "ui_navigation.hpp"
+#include "external_app.hpp"
+
+namespace ui::external_app::mcu_temperature {
+void initialize_app(ui::NavigationView& nav) {
+    nav.push<McuTemperatureView>();
+}
+}  // namespace ui::external_app::mcu_temperature
+
+extern "C" {
+
+__attribute__((section(".external_app.app_mcu_temperature.application_information"), used)) application_information_t _application_information_mcu_temperature = {
+    /*.memory_location = */ (uint8_t*)0x00000000,
+    /*.externalAppEntry = */ ui::external_app::mcu_temperature::initialize_app,
+    /*.header_version = */ CURRENT_HEADER_VERSION,
+    /*.app_version = */ VERSION_MD5,
+
+    /*.app_name = */ "Temperature",
+    /*.bitmap_data = */ {
+        0x00,
+        0x00,
+        0x20,
+        0x00,
+        0x70,
+        0x3E,
+        0x88,
+        0x00,
+        0x88,
+        0x00,
+        0x88,
+        0x3E,
+        0x88,
+        0x00,
+        0x88,
+        0x00,
+        0x88,
+        0x3E,
+        0x88,
+        0x00,
+        0x04,
+        0x01,
+        0x74,
+        0x01,
+        0x04,
+        0x01,
+        0x88,
+        0x00,
+        0x70,
+        0x00,
+        0x00,
+        0x00,
+    },
+    /*.icon_color = */ ui::Color::cyan().v,
+    /*.menu_location = */ app_location_t::DEBUG,
+    /*.desired_menu_position = */ -1,
+
+    /*.m4_app_tag = portapack::spi_flash::image_tag_none */ {0, 0, 0, 0},
+    /*.m4_app_offset = */ 0x00000000,  // will be filled at compile time
+};
+}

firmware/application/external/mcu_temperature/mcu_temperature.cpp

@@ -0,0 +1,91 @@
+#include "mcu_temperature.hpp"
+
+#include "ui_painter.hpp"
+
+#include "portapack.hpp"
+
+using namespace portapack;
+namespace ui::external_app::mcu_temperature {
+
+void McuTemperatureWidget::paint(Painter& painter) {
+    const auto logger = portapack::temperature_logger;
+
+    const auto rect = screen_rect();
+    const Color color_background{0, 0, 64};
+    const Color color_foreground = Theme::getInstance()->fg_green->foreground;
+    const Color color_reticle{128, 128, 128};
+
+    const auto graph_width = static_cast<int>(logger.capacity()) * bar_width;
+    const Rect graph_rect{
+        rect.left() + (rect.width() - graph_width) / 2, rect.top() + 8,
+        graph_width, rect.height()};
+    const Rect frame_rect{
+        graph_rect.left() - 1, graph_rect.top() - 1,
+        graph_rect.width() + 2, graph_rect.height() + 2};
+    painter.draw_rectangle(frame_rect, color_reticle);
+    painter.fill_rectangle(graph_rect, color_background);
+
+    const auto history = logger.history();
+    for (size_t i = 0; i < history.size(); i++) {
+        const Coord x = graph_rect.right() - (history.size() - i) * bar_width;
+        const auto sample = history[i];
+        const auto temp = temperature(sample);
+        const auto y = screen_y(temp, graph_rect);
+        const Dim bar_height = graph_rect.bottom() - y;
+        painter.fill_rectangle({x, y, bar_width, bar_height}, color_foreground);
+    }
+
+    if (!history.empty()) {
+        const auto sample = history.back();
+        const auto temp = temperature(sample);
+        const auto last_y = screen_y(temp, graph_rect);
+        const Coord x = graph_rect.right() + 8;
+        const Coord y = last_y - 8;
+
+        painter.draw_string({x, y}, style(), temperature_str(temp));
+    }
+
+    const auto display_temp_max = display_temp_min + (graph_rect.height() / display_temp_scale);
+    for (auto temp = display_temp_min; temp <= display_temp_max; temp += 10) {
+        const int32_t tick_length = 6;
+        const auto tick_x = graph_rect.left() - tick_length;
+        const auto tick_y = screen_y(temp, graph_rect);
+        painter.fill_rectangle({tick_x, tick_y, tick_length, 1}, color_reticle);
+        const auto text_x = graph_rect.left() - temp_len * 8 - 8;
+        const auto text_y = tick_y - 8;
+        painter.draw_string({text_x, text_y}, style(), temperature_str(temp));
+    }
+}
+
+McuTemperatureWidget::temperature_t McuTemperatureWidget::temperature(const sample_t sensor_value) const {
+    // Scaling is different for MAX2837 vs MAX2839 so it's now done in the respective chip-specific module
+    return sensor_value;
+}
+
+std::string McuTemperatureWidget::temperature_str(const temperature_t temperature) const {
+    return to_string_dec_int(temperature, temp_len - 2) + STR_DEGREES_C;
+}
+
+Coord McuTemperatureWidget::screen_y(
+    const temperature_t temperature,
+    const Rect& rect) const {
+    int y_raw = rect.bottom() - ((temperature - display_temp_min) * display_temp_scale);
+    const auto y_limit = std::min(rect.bottom(), std::max(rect.top(), y_raw));
+    return y_limit;
+}
+
+McuTemperatureView::McuTemperatureView(NavigationView& nav) {
+    add_children({
+        &text_title,
+        &temperature_widget,
+        &button_done,
+    });
+
+    button_done.on_select = [&nav](Button&) { nav.pop(); };
+}
+
+void McuTemperatureView::focus() {
+    button_done.focus();
+}
+
+}  // namespace ui::external_app::mcu_temperature

firmware/application/external/mcu_temperature/mcu_temperature.hpp

@@ -0,0 +1,90 @@
+/*
+ * Copyright (C) 2015 Jared Boone, ShareBrained Technology, Inc.
+ *
+ * This file is part of PortaPack.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2, or (at your option)
+ * any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; see the file COPYING.  If not, write to
+ * the Free Software Foundation, Inc., 51 Franklin Street,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#ifndef __MCU_TEMPERATURE_H__
+#define __MCU_TEMPERATURE_H__
+
+#include "ui.hpp"
+#include "ui_widget.hpp"
+#include "ui_painter.hpp"
+#include "ui_menu.hpp"
+#include "ui_navigation.hpp"
+
+#include "rffc507x.hpp"
+#include "portapack.hpp"
+#include "memory_map.hpp"
+#include "irq_controls.hpp"
+
+#include <functional>
+#include <utility>
+
+namespace ui::external_app::mcu_temperature {
+
+class McuTemperatureWidget : public Widget {
+   public:
+    explicit McuTemperatureWidget(
+        Rect parent_rect)
+        : Widget{parent_rect} {
+    }
+
+    void paint(Painter& painter) override;
+
+   private:
+    using sample_t = uint32_t;
+    using temperature_t = int32_t;
+
+    temperature_t temperature(const sample_t sensor_value) const;
+    Coord screen_y(const temperature_t temperature, const Rect& screen_rect) const;
+
+    std::string temperature_str(const temperature_t temperature) const;
+
+    static constexpr temperature_t display_temp_min = -10;  // Accomodate negative values, present in cold startup cases
+    static constexpr temperature_t display_temp_scale = 3;
+    static constexpr int bar_width = 1;
+    static constexpr int temp_len = 5;  // Now scale shows up to 5 chars ("-10ºC")
+};
+
+class McuTemperatureView : public View {
+   public:
+    explicit McuTemperatureView(NavigationView& nav);
+
+    void focus() override;
+
+    std::string title() const override { return "Temperature"; };
+
+   private:
+    Text text_title{
+        {76, 16, 240, 16},
+        "Temperature",
+    };
+
+    McuTemperatureWidget temperature_widget{
+        {0, 40, 240, 180},
+    };
+
+    Button button_done{
+        {72, 264, 96, 24},
+        "Done"};
+};
+
+}  // namespace ui::external_app::mcu_temperature
+
+#endif /*__MCU_TEMPERATURE_H__*/