Git-Mirrors/portapack-mayhem
1
0
Fork 0
mirror of https://github.com/eried/portapack-mayhem.git synced 2025-02-10 03:38:50 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixed debounce code to handle noisy switch transitions #989 (#1030)

Browse Source 
* Fix debounce to handle noisy switch transitions

* Fix debounce to handle noisy switch transitions

* Fix debounce to handle noisy switch transitions

* Removed inline comment to see if Clang checker will be happy

* Test fix for supposed Clang formatting issue
This commit is contained in:
Mark Thompson 2023-05-21 19:06:37 -05:00 committed by GitHub
parent be1b2716d6
commit 4d1269051b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
firmware/application/hw/debounce.cpp
View File

@ -23,17 +23,24 @@
#include "utility.hpp" #include "utility.hpp"
// Returns TRUE if button state changed (after debouncing)
bool Debounce::feed(const uint8_t bit) { bool Debounce::feed(const uint8_t bit) {
history_ = (history_ << 1) | (bit & 1); history_ = (history_ << 1) | (bit & 1);
if (history_ == 0b00001111) { if (state_ == 0) {
// Previous button state was 0 (released);
// Has button been held for DEBOUNCE_COUNT ticks?
if ((history_ & DEBOUNCE_MASK) == DEBOUNCE_MASK) {
state_ = 1; state_ = 1;
return true; return true;
} }
if (history_ == 0b11110000) { } else {
// Previous button state was 1 (pressed);
// Has button been released for DEBOUNCE_COUNT ticks?
if ((history_ & DEBOUNCE_MASK) == 0) {
state_ = 0; state_ = 0;
return true; return true;
} }
}
return false; return false;
} }

4
firmware/application/hw/debounce.hpp
View File

@ -24,6 +24,10 @@
#include <cstdint> #include <cstdint>
// consecutive # of times button input must be same (<=8)
#define DEBOUNCE_COUNT 4
#define DEBOUNCE_MASK ((1 << DEBOUNCE_COUNT) - 1)
class Debounce { class Debounce {
public: public:
bool feed(const uint8_t bit); bool feed(const uint8_t bit);