Git-Mirrors/portapack-mayhem
1
0
Fork 0
mirror of https://github.com/eried/portapack-mayhem.git synced 2025-06-25 15:20:31 -04:00
Code Issues Projects Releases Packages Wiki Activity

Remove a lot of static_cast<>s involving UI structs.

Browse source 
Also starting to get religion on using unsigned integers only when I want their wrapping/modulus behavior.
This commit is contained in:
Jared Boone 2016-11-29 10:13:56 -08:00
parent 4c8550bb7d
commit 3f94591083
11 changed files with 28 additions and 76 deletions
Download patch file Download diff file Expand all files Collapse all files

8
firmware/common/ui_widget.hpp
View file

@ -273,7 +273,7 @@ public:
std::function<void(size_t, value_t)> on_change { };
std::function<void(void)> on_show_options { };
OptionsField(Point parent_pos, size_t length, options_t options);
OptionsField(Point parent_pos, int length, options_t options);
size_t selected_index() const;
void set_selected_index(const size_t new_index);
@ -287,7 +287,7 @@ public:
bool on_touch(const TouchEvent event) override;
private:
const size_t length_;
const int length_;
options_t options;
size_t selected_index_ { 0 };
};
@ -298,7 +298,7 @@ public:
using range_t = std::pair<int32_t, int32_t>;
NumberField(Point parent_pos, size_t length, range_t range, int32_t step, char fill_char);
NumberField(Point parent_pos, int length, range_t range, int32_t step, char fill_char);
NumberField(const NumberField&) = delete;
NumberField(NumberField&&) = delete;
@ -314,7 +314,7 @@ public:
private:
const range_t range;
const int32_t step;
const size_t length_;
const int length_;
const char fill_char;
int32_t value_ { 0 };