From 2c64454172edf574e964705246dac18a5b888ecc Mon Sep 17 00:00:00 2001 From: Jared Boone Date: Wed, 11 Nov 2015 09:35:28 -0800 Subject: [PATCH] More constructor style clean-up. --- firmware/baseband/main.cpp | 6 ++---- firmware/common/message.hpp | 8 ++++++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/firmware/baseband/main.cpp b/firmware/baseband/main.cpp index fa938665..7368fa40 100755 --- a/firmware/baseband/main.cpp +++ b/firmware/baseband/main.cpp @@ -113,8 +113,7 @@ static __attribute__((noreturn)) msg_t baseband_fn(void *arg) { stats.process(buffer, [](const BasebandStatistics statistics) { - BasebandStatisticsMessage message; - message.statistics = statistics; + const BasebandStatisticsMessage message { statistics }; shared_memory.application_queue.push(message); } ); @@ -138,8 +137,7 @@ static __attribute__((noreturn)) msg_t rssi_fn(void *arg) { stats.process( buffer, [](const RSSIStatistics statistics) { - RSSIStatisticsMessage message; - message.statistics = statistics; + const RSSIStatisticsMessage message { statistics }; shared_memory.application_queue.push(message); } ); diff --git a/firmware/common/message.hpp b/firmware/common/message.hpp index 4a53bde9..2ae0c55f 100644 --- a/firmware/common/message.hpp +++ b/firmware/common/message.hpp @@ -69,7 +69,9 @@ struct RSSIStatistics { class RSSIStatisticsMessage : public Message { public: constexpr RSSIStatisticsMessage( - ) : Message { ID::RSSIStatistics } + const RSSIStatistics& statistics + ) : Message { ID::RSSIStatistics }, + statistics { statistics } { } @@ -87,7 +89,9 @@ struct BasebandStatistics { class BasebandStatisticsMessage : public Message { public: constexpr BasebandStatisticsMessage( - ) : Message { ID::BasebandStatistics } + const BasebandStatistics& statistics + ) : Message { ID::BasebandStatistics }, + statistics { statistics } { }