From 00c9c6b40e300b032fdaee94cbf3338c8c4c62a3 Mon Sep 17 00:00:00 2001 From: Totoo Date: Fri, 31 Oct 2025 18:25:23 +0100 Subject: [PATCH] Fix shift key position (#2850) --- firmware/application/ui/ui_alphanum.hpp | 2 +- firmware/application/ui_navigation.cpp | 7 +++---- firmware/application/ui_navigation.hpp | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/firmware/application/ui/ui_alphanum.hpp b/firmware/application/ui/ui_alphanum.hpp index 654ed57e1..29211c3b4 100644 --- a/firmware/application/ui/ui_alphanum.hpp +++ b/firmware/application/ui/ui_alphanum.hpp @@ -81,7 +81,7 @@ class AlphanumView : public TextEntryView { std::array buttons{}; NewButton button_shift{ - {192, 214, screen_width / 5, 38}, + {screen_width - screen_width / 5, 214, screen_width / 5, 38}, {}, &bitmap_icon_shift, Theme::getInstance()->bg_dark->background, diff --git a/firmware/application/ui_navigation.cpp b/firmware/application/ui_navigation.cpp index a7e67fb69..a88506a1a 100644 --- a/firmware/application/ui_navigation.cpp +++ b/firmware/application/ui_navigation.cpp @@ -769,9 +769,9 @@ void add_apps(NavigationView& nav, BtnGridView& grid, app_location_t loc) { } // clang-format off -void add_external_items(NavigationView& nav, app_location_t location, BtnGridView& grid, uint8_t error_tile_pos) { +void add_external_items(NavigationView& nav, app_location_t location, BtnGridView& grid, uint8_t error_tile_pos, bool show_error_tile ) { auto externalItems = ExternalItemsMenuLoader::load_external_items(location, nav); - if (externalItems.empty()) { + if (externalItems.empty() && show_error_tile) { grid.insert_item({"ExtAppErr", Theme::getInstance()->error_dark->foreground, nullptr, @@ -848,8 +848,7 @@ void TranceiversMenuView::on_populate() { add_items({{"..", Theme::getInstance()->fg_light->foreground, &bitmap_icon_previous, [this]() { nav_.pop(); }}}); } add_apps(nav_, *this, TRX); - // add_external_items(nav_, app_location_t::TRX, *this, return_icon ? 1 : 0); - // this folder doesn't have external apps, comment to prevent pop the err msg. + add_external_items(nav_, app_location_t::TRX, *this, return_icon ? 1 : 0, false); // this folder doesn't have external apps, so don't show error for it. // NB: when has external app someday, uncomment this. } diff --git a/firmware/application/ui_navigation.hpp b/firmware/application/ui_navigation.hpp index 21154bdac..33d0e6358 100644 --- a/firmware/application/ui_navigation.hpp +++ b/firmware/application/ui_navigation.hpp @@ -61,7 +61,7 @@ using namespace sd_card; namespace ui { void add_apps(NavigationView& nav, BtnGridView& grid, app_location_t loc); -void add_external_items(NavigationView& nav, app_location_t location, BtnGridView& grid, uint8_t error_tile_pos); +void add_external_items(NavigationView& nav, app_location_t location, BtnGridView& grid, uint8_t error_tile_pos, bool show_error_tile = true); bool verify_sdcard_format(); enum modal_t {