Micah Lee
74c5722b09
Merge branch 'hmac_compare_digest' of https://github.com/delirious-lettuce/onionshare into delirious-lettuce-hmac_compare_digest
2017-05-30 14:50:19 -07:00
Micah Lee
294f093f9b
Merge branch 'format_seconds' of https://github.com/delirious-lettuce/onionshare into delirious-lettuce-format_seconds
2017-05-30 11:44:44 -07:00
Delirious Lettuce
a50d1207c3
Remove constant_time_compare
to use hmac.compare_digest
2017-05-28 13:38:33 -06:00
Delirious Lettuce
20f1f352a0
Fix issue mentioned by @mig5
2017-05-26 10:12:11 -06:00
Delirious Lettuce
882ac942fe
Use divmod
to simplify the calculations, seconds==0 -> '0s'
2017-05-24 22:20:50 -06:00
Delirious Lettuce
9f35ebc287
* Use context manager inside of get_available_port
...
* Rearrange imports, one per line
* Reuse original `import random` for `random.SystemRandom` (instead of a separate `from random import SystemRandom`)
* Two blank lines above each function definition
2017-05-24 21:20:07 -06:00
Micah Lee
bfd7352781
Merge branch 'build_slug' of https://github.com/delirious-lettuce/onionshare into delirious-lettuce-build_slug
2017-05-24 14:04:06 -07:00
Micah Lee
47a53f2d36
Merge branch 'fix_shutdown_from_gui' of https://github.com/mig5/onionshare into mig5-fix_shutdown_from_gui
2017-05-24 14:00:50 -07:00
Delirious Lettuce
7df189dd24
Removing '\n' arg negates the need for wordlist.remove()
, renamed unused variable 'x' to '_'
2017-05-24 13:22:41 -06:00
Micah Lee
36a27b3b7d
Fix indenting
2017-05-23 15:16:27 -07:00
Miguel Jacq
b97db1339d
open files via the 'with' statement, to avoid ResourceWarnings on unclosed files
2017-05-23 21:22:14 +10:00
Micah Lee
d1512dcd9c
Merge branch '285_systray_notifications' of https://github.com/mig5/onionshare into mig5-285_systray_notifications
2017-05-22 16:15:06 -07:00
Micah Lee
e5e7add40f
Don't load strings directly in the web module. It isn't needed anymore, and it's preventing tests from passing in travis-ci
2017-05-22 15:02:22 -07:00
Micah Lee
91bb0eefa5
Remove version string from http response headers, to avoid any information disclosure about the sender's server
2017-05-22 14:58:23 -07:00
Micah Lee
36d3fac5c9
Merge branch '253-security-headers' of https://github.com/mig5/onionshare into mig5-253-security-headers
2017-05-22 14:56:32 -07:00
Miguel Jacq
5a166e9fc1
Add desktop notification messages on download events (via systray)
2017-05-22 16:47:23 +10:00
Miguel Jacq
8539adb343
use the actual OnionShare version as the Server header string
2017-05-21 10:30:37 +10:00
Miguel Jacq
fdf6b46e58
Remove duplication of security headers
2017-05-21 10:03:18 +10:00
Miguel Jacq
eeb463b0c8
Reinstate the alternative method of shutting down the web server - necessary for clicking 'Stop sharing' from GUI
2017-05-20 17:37:12 +10:00
Miguel Jacq
33c690b22c
Harden some response headers
2017-05-20 12:34:00 +10:00
Miguel Jacq
90d6919cc9
Remove onionshare-gui symlink pointing to itself
2017-05-19 14:15:54 +10:00
Micah Lee
8ef6d3d076
In bundled Tor mode, wait 2 full seconds before connecting to the Tor controller
2017-05-18 17:34:36 -07:00
Miguel Jacq
ec82f06394
Wait a bit longer before attempting to connect to the Tor controller
2017-05-19 09:45:54 +10:00
Micah Lee
6b41441706
Update get-tor-osx.py to grab the Tor binary from Tor Browser 6.5.2 instead of 6.5.1, and make it retain the same directory structure in OnionShare as it uses in Tor Browser, including copying libevent-2.0.5.dylib, which was missing before ( #385 )
2017-05-18 11:22:50 -07:00
Miguel Jacq
5f92e3d606
#345 - validate the readability of files before adding them
2017-05-18 18:09:49 +10:00
Micah Lee
62b5d64bc7
Catch errors that occur when connection_type is bundled_tor, but the tor process closes before it can connect
2017-05-17 12:00:42 -07:00
Micah Lee
41f4b666e7
When saving settings, if Tor settings changed or if Tor isn't connected, reboot the Onion object, so that it's always connected to Tor when using the app
2017-05-16 16:50:33 -07:00
Micah Lee
b7a9574490
Fixed signal/slot/thread issue in TorConnectionDialog and TorConnectionThread, and updated the language of bundled Tor error messages
2017-05-16 13:09:27 -07:00
Micah Lee
cabb2701f2
Made Settings debug log less verbose
2017-05-16 13:01:57 -07:00
Micah Lee
dec9b9ec68
Make the Onion object poll the tor controller less frequently, now that the connection happens in a separate thread
2017-05-16 11:47:18 -07:00
Micah Lee
226b608cff
Move connecting to Tor into its own separate thread
2017-05-16 11:44:34 -07:00
Micah Lee
3c88bc828b
Add debug logging to Onion, OnionShare, and Settings objects
2017-05-16 11:23:18 -07:00
Micah Lee
410a71b702
Add log() method to onionshare.common, which logs to stdout if in debug mode
2017-05-16 11:12:55 -07:00
Micah Lee
6b35a44d41
Renamed onionshare.helpers module to onionshare.common
2017-05-16 11:05:48 -07:00
Micah Lee
72e862124d
Pass debug into the Onion and OnionShareGUI objects
2017-05-16 10:57:59 -07:00
Micah Lee
f48e160816
Move owernship of the TorConnetionDialog objection from __init__.py into the OnionShareGUI class, and make it so when the Tor connection gets canceled, OnionShare quits
2017-05-14 18:30:45 -07:00
Micah Lee
8f0af317b5
Fixed various issues introduced by creating an singleton Onion object and passing it into the OnionShare object
2017-05-14 17:21:13 -07:00
Micah Lee
a15cae72de
Merge branch 'master' into tor-bundle-autoupdate
2017-04-18 16:07:46 -07:00
Micah Lee
24c5d83a48
Merge branch 'tor-bundle' into autoupdate
2017-04-18 16:00:24 -07:00
Micah Lee
c36b79e1d8
Added support for bundled Tor in macOS
2017-04-18 15:12:24 -07:00
Micah Lee
e54af350a1
Onion calls tor_status_update_func much more frequently, which makes the GUI more responsive
2017-04-17 20:54:55 -07:00
Micah Lee
d7c181e0b4
Add an Onion exception for canceling connecting Tor
2017-04-17 20:49:06 -07:00
Micah Lee
915d548399
Began making a TorConnectionDialog, which handles connecting to the Tor network
2017-04-17 20:26:35 -07:00
Micah Lee
1b240fb9c0
Move OnionShare object into its own file, so __init__ is just CLI logic
2017-04-17 19:28:51 -07:00
Micah Lee
89b1cc444c
Make it so ctrl-c actually quits the CLI version
2017-04-17 19:22:40 -07:00
Micah Lee
46d25552e0
Added helper function get_available_port(), and use it to avoid code duplication. Removed unused is_root() helper function. Refactored Onion object to not try to connect in the constructor.
2017-04-17 19:13:53 -07:00
Micah Lee
b94253e6ea
Removed transparent_torification from the full app, and refactored OnionShare class to get passed in an Onion, and doesn't get passed in stealth.
2017-04-17 19:12:02 -07:00
Micah Lee
baa7c4bdd1
Added Tor SOCKS address and port settings
2017-04-15 16:33:41 -07:00
Micah Lee
9fcb6f0c93
Added autoupdate settings to Settings, and also to the settings dialog
2017-04-15 15:24:08 -07:00
Micah Lee
be2b086cc4
Make sure tor process is killed in a more robust manner, and also increase tor connection timeout to 45 seconds
2017-04-15 11:43:19 -07:00