Fix syntax for opening explorer and selecting the filename. Fix a bug in the downloads_dir for Windows (need to use a backslash)

This commit is contained in:
Miguel Jacq 2018-09-19 12:12:18 +10:00
parent 388f968556
commit f45eae5768
No known key found for this signature in database
GPG Key ID: EEA4341C6D97A0B6
2 changed files with 8 additions and 4 deletions

View File

@ -105,9 +105,13 @@ class Settings(object):
""" """
Returns the path of the default Downloads directory for receive mode. Returns the path of the default Downloads directory for receive mode.
""" """
# TODO: Test in Windows, though it looks like it should work # On Windows, os.path.expanduser() needs to use backslash, or else it
# https://docs.python.org/3/library/os.path.html#os.path.expanduser # retains the forward slash, which breaks opening the folder in explorer.
return os.path.expanduser('~/OnionShare') p = platform.system()
if p == 'Windows':
return os.path.expanduser('~\OnionShare')
else:
return os.path.expanduser('~/OnionShare')
def load(self): def load(self):
""" """

View File

@ -96,7 +96,7 @@ class File(QtWidgets.QWidget):
# Windows # Windows
elif self.common.platform == 'Windows': elif self.common.platform == 'Windows':
subprocess.Popen(['explorer', '/select', abs_filename]) subprocess.Popen(['explorer', '/select,{}'.format(abs_filename)])
class Upload(QtWidgets.QWidget): class Upload(QtWidgets.QWidget):