diff --git a/apparmor/abstractions/onionshare b/apparmor/abstractions/onionshare index d5c7c184..fa94e68d 100644 --- a/apparmor/abstractions/onionshare +++ b/apparmor/abstractions/onionshare @@ -1,5 +1,6 @@ #include #include +#include #include # Why are these not in abstractions/python? @@ -16,16 +17,13 @@ /sbin/ldconfig rix, /sbin/ldconfig.real rix, /bin/uname rix, -/{,lib/live/mount/rootfs/filesystem.squashfs/}etc/mime.types r, -/{,lib/live/mount/rootfs/filesystem.squashfs/}usr/share/onionshare/ r, -/{,lib/live/mount/rootfs/filesystem.squashfs/}usr/share/onionshare/** r, +/etc/mime.types r, +/usr/share/onionshare/ r, +/usr/share/onionshare/** r, /tmp/ rw, /tmp/** rw, -# Allow all user data except .gnupg, .ssh and other potential -# places for critically sensitive application data. -audit deny @{HOME}/.* mrwkl, -audit deny @{HOME}/.*/ mrwkl, -audit deny @{HOME}/.*/** mrwkl, -owner @{HOME}/ r, -owner @{HOME}/** r, +# Allow read on almost anything in @{HOME}. Lenient, but +# private-files-strict is in effect. +owner @{HOME}/ r, +owner @{HOME}/[^.]** r, diff --git a/apparmor/usr.bin.onionshare b/apparmor/usr.bin.onionshare index 225e5458..1c14ccc1 100644 --- a/apparmor/usr.bin.onionshare +++ b/apparmor/usr.bin.onionshare @@ -1,6 +1,6 @@ #include -/usr/bin/onionshare flags=(complain) { +/usr/bin/onionshare { #include /usr/bin/ r, diff --git a/apparmor/usr.bin.onionshare-gui b/apparmor/usr.bin.onionshare-gui index ed69e832..746dadc1 100644 --- a/apparmor/usr.bin.onionshare-gui +++ b/apparmor/usr.bin.onionshare-gui @@ -1,6 +1,6 @@ #include -/usr/bin/onionshare-gui flags=(complain) { +/usr/bin/onionshare-gui { #include #include #include @@ -8,14 +8,16 @@ /usr/bin/ r, /usr/bin/onionshare-gui r, /proc/*/cmdline r, - /usr/share/icons/Adwaita/index.theme r, + + # The freedesktop.org abstraction doesn't allow `k` + /usr/share/icons/*/index.theme k, # Why do these still emit audit journal entries? owner @{HOME}/.config/ibus/bus/ rw, owner @{HOME}/.config/ibus/bus/* rw, deny @{HOME}/.ICEauthority r, - deny /{,lib/live/mount/rootfs/filesystem.squashfs/}etc/machine-id r, + deny /etc/machine-id r, deny /var/lib/dbus/machine-id.* rw, # Accessibility support