From d88005d550ab65024e298f05e0c269eccf98f9e3 Mon Sep 17 00:00:00 2001
From: Micah Lee <micah@micahflee.com>
Date: Tue, 9 Nov 2021 18:57:07 -0800
Subject: [PATCH] When Tor is disconnected, hide the Check for Updates button
 in the Settings tab

---
 desktop/src/onionshare/settings_tab.py | 11 ++++++++++
 desktop/src/onionshare/tab_widget.py   | 28 +++++++++++++-------------
 2 files changed, 25 insertions(+), 14 deletions(-)

diff --git a/desktop/src/onionshare/settings_tab.py b/desktop/src/onionshare/settings_tab.py
index 75b7a326..cfa3261e 100644
--- a/desktop/src/onionshare/settings_tab.py
+++ b/desktop/src/onionshare/settings_tab.py
@@ -154,6 +154,11 @@ class SettingsTab(QtWidgets.QWidget):
 
         self.reload_settings()
 
+        if self.common.gui.onion.connected_to_tor:
+            self.tor_is_connected()
+        else:
+            self.tor_is_disconnected()
+
     def reload_settings(self):
         # Load settings, and fill them in
         self.old_settings = Settings(self.common)
@@ -341,3 +346,9 @@ class SettingsTab(QtWidgets.QWidget):
         else:
             self.check_for_updates_button.setEnabled(True)
         self.save_button.setEnabled(True)
+
+    def tor_is_connected(self):
+        self.check_for_updates_button.show()
+
+    def tor_is_disconnected(self):
+        self.check_for_updates_button.hide()
diff --git a/desktop/src/onionshare/tab_widget.py b/desktop/src/onionshare/tab_widget.py
index 7f42632d..7162fcc4 100644
--- a/desktop/src/onionshare/tab_widget.py
+++ b/desktop/src/onionshare/tab_widget.py
@@ -378,23 +378,23 @@ class TabWidget(QtWidgets.QTabWidget):
 
     def tor_is_connected(self):
         for tab_id in self.tabs:
-            if not (
-                type(self.tabs[tab_id]) is SettingsTab
-                or type(self.tabs[tab_id]) is TorSettingsTab
-            ):
-                mode = self.tabs[tab_id].get_mode()
-                if mode:
-                    mode.tor_connection_started()
+            if type(self.tabs[tab_id]) is SettingsTab:
+                self.tabs[tab_id].tor_is_connected()
+            else:
+                if not type(self.tabs[tab_id]) is TorSettingsTab:
+                    mode = self.tabs[tab_id].get_mode()
+                    if mode:
+                        mode.tor_connection_started()
 
     def tor_is_disconnected(self):
         for tab_id in self.tabs:
-            if not (
-                type(self.tabs[tab_id]) is SettingsTab
-                or type(self.tabs[tab_id]) is TorSettingsTab
-            ):
-                mode = self.tabs[tab_id].get_mode()
-                if mode:
-                    mode.tor_connection_stopped()
+            if type(self.tabs[tab_id]) is SettingsTab:
+                self.tabs[tab_id].tor_is_disconnected()
+            else:
+                if not type(self.tabs[tab_id]) is TorSettingsTab:
+                    mode = self.tabs[tab_id].get_mode()
+                    if mode:
+                        mode.tor_connection_stopped()
 
 
 class TabBar(QtWidgets.QTabBar):