From d421bfa14baf97073d1c5d3d0781c294b171cbb5 Mon Sep 17 00:00:00 2001 From: Saptak S Date: Fri, 7 May 2021 01:23:11 +0530 Subject: [PATCH] Pins flask-socketio to 5.0.1 in pyproject.toml Also updates the RELEASE.md to document the need to update the socket.io.min.js file whenever we want to update flask-socketio to ensure that they are compatible with each other, failing which, the chat stops works. --- RELEASE.md | 2 ++ cli/pyproject.toml | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/RELEASE.md b/RELEASE.md index 5d28a40f..e69a8184 100644 --- a/RELEASE.md +++ b/RELEASE.md @@ -14,6 +14,8 @@ Before making a release, you must update the version in these places: - [ ] `docs/source/conf.py` (`version` at the top, and the `versions` list too) - [ ] `snap/snapcraft.yaml` +If you update flask-socketio, ensure that you also update the [socket.io.min.js](https://github.com/micahflee/onionshare/blob/develop/cli/onionshare_cli/resources/static/js/socket.io.min.js) file to a version that is [supported](https://flask-socketio.readthedocs.io/en/latest/#version-compatibility) by the updated version of flask-socketio. + Use tor binaries from the latest Tor Browser: - [ ] `desktop/scripts/get-tor-osx.py` diff --git a/cli/pyproject.toml b/cli/pyproject.toml index 6457a781..958d3434 100644 --- a/cli/pyproject.toml +++ b/cli/pyproject.toml @@ -20,7 +20,7 @@ python = "^3.6" click = "*" flask = "*" flask-httpauth = "*" -flask-socketio = "*" +flask-socketio = "5.0.1" psutil = "*" pycryptodome = "*" pysocks = "*"