From cdb7a4df718af24dddc9e0115fd4cce8d7f2c6cb Mon Sep 17 00:00:00 2001 From: Miguel Jacq Date: Thu, 4 Jan 2018 08:43:43 +1100 Subject: [PATCH] Don't re-enable the Check for Updates button after testing Tor connection, if the main Tor connection is still not active --- onionshare_gui/settings_dialog.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/onionshare_gui/settings_dialog.py b/onionshare_gui/settings_dialog.py index 105b1e3d..38cf36d3 100644 --- a/onionshare_gui/settings_dialog.py +++ b/onionshare_gui/settings_dialog.py @@ -596,8 +596,11 @@ class SettingsDialog(QtWidgets.QDialog): def _enable_buttons(self): common.log('SettingsDialog', '_enable_buttons') - - self.check_for_updates_button.setEnabled(True) + # We can't check for updates if we're still not connected to Tor + if not self.onion.connected_to_tor: + self.check_for_updates_button.setEnabled(False) + else: + self.check_for_updates_button.setEnabled(True) self.connection_type_test_button.setEnabled(True) self.save_button.setEnabled(True) self.cancel_button.setEnabled(True)