Install new dependencies so CircleCI tests run, and fix a pytest warning

This commit is contained in:
Micah Lee 2020-11-01 11:50:11 -08:00
parent 790fe245e3
commit a801f0a628
No known key found for this signature in database
GPG Key ID: 403C2657CD994F73
3 changed files with 12 additions and 6 deletions

View File

@ -49,17 +49,18 @@ jobs:
name: Install dependencies
command: |
sudo apt-get update
sudo apt-get install -y xvfb tor obfs4proxy gcc python3-dev
sudo apt-get install -y tor obfs4proxy gcc python3-dev python3-pyside2.qtcore python3-pyside2.qtwidgets python3-pyside2.qtgui
sudo apt-get install -y xvfb x11-utils libxkbcommon-x11-0 libxcb-randr0-dev libxcb-xtest0-dev libxcb-xinerama0-dev libxcb-shape0-dev libxcb-xkb-dev libxcb-render-util0 libxcb-icccm4 libxcb-keysyms1 libxcb-image0
cd ~/repo/cli
poetry install
poetry build
cp dist/onionshare_cli-*.whl ~/repo/desktop
cd ~/repo/desktop
pip install briefcase pytest pytest-briefcase pytest-faulthandler pytest-qt
pip install briefcase pytest pytest-briefcase pytest-faulthandler pytest-qt pytest-xvfb
pip install $(python -c 'import toml; print(" ".join(toml.loads(open("pyproject.toml").read())["tool"]["briefcase"]["app"]["onionshare"]["requires"]))')
- run:
name: Run tests
command: |
cd ~/repo/desktop
xvfb-run ./tests/run.sh
./tests/run.sh

View File

@ -102,7 +102,7 @@ class ModeSettings:
elif self.common.platform == "Windows":
# On Windows, os.path.expanduser() needs to use backslash, or else it
# retains the forward slash, which breaks opening the folder in explorer.
return os.path.expanduser("~\OnionShare")
return os.path.expanduser("~\\OnionShare")
else:
# All other OSes
return os.path.expanduser("~/OnionShare")

View File

@ -665,9 +665,14 @@ class SettingsDialog(QtWidgets.QDialog):
else:
tor_status_update_func = None
onion = Onion(self.common, use_tmp_dir=True, get_tor_paths=self.common.gui.get_tor_paths)
onion = Onion(
self.common,
use_tmp_dir=True,
get_tor_paths=self.common.gui.get_tor_paths,
)
onion.connect(
custom_settings=settings, tor_status_update_func=tor_status_update_func,
custom_settings=settings,
tor_status_update_func=tor_status_update_func,
)
# If an exception hasn't been raised yet, the Tor settings work