Git-Mirrors/onionshare
1
0
Fork 0
mirror of https://github.com/onionshare/onionshare.git synced 2025-05-04 23:45:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

add missing 'toggled' connect for obfs4 radio. Remove the enabling/disabling of radios for bridges, it obstructs normal UX

Browse source
This commit is contained in:
Miguel Jacq 2018-01-15 11:25:08 +11:00
parent 55c390eb7f
commit 82b1860dac
No known key found for this signature in database
GPG key ID: 5418373DFF79BA19
1 changed files with 1 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
onionshare_gui/settings_dialog.py
View file

@ -129,6 +129,7 @@ class SettingsDialog(QtWidgets.QDialog):
# OBFS4 option radio # OBFS4 option radio
self.tor_bridges_use_obfs4_radio = QtWidgets.QRadioButton(strings._('gui_settings_tor_bridges_obfs4_radio_option', True)) self.tor_bridges_use_obfs4_radio = QtWidgets.QRadioButton(strings._('gui_settings_tor_bridges_obfs4_radio_option', True))
self.tor_bridges_use_obfs4_radio.toggled.connect(self.tor_bridges_use_obfs4_radio_toggled)
# Custom bridges radio and textbox # Custom bridges radio and textbox
self.tor_bridges_use_custom_radio = QtWidgets.QRadioButton(strings._('gui_settings_tor_bridges_custom_radio_option', True)) self.tor_bridges_use_custom_radio = QtWidgets.QRadioButton(strings._('gui_settings_tor_bridges_custom_radio_option', True))
@ -397,8 +398,6 @@ class SettingsDialog(QtWidgets.QDialog):
'No bridges' option was toggled. If checked, enable other bridge options. 'No bridges' option was toggled. If checked, enable other bridge options.
""" """
if checked: if checked:
self.tor_bridges_use_obfs4_radio.setEnabled(True)
self.tor_bridges_use_custom_radio.setEnabled(True)
self.tor_bridges_use_custom_textbox_options.hide() self.tor_bridges_use_custom_textbox_options.hide()
def tor_bridges_use_obfs4_radio_toggled(self, checked): def tor_bridges_use_obfs4_radio_toggled(self, checked):
@ -406,7 +405,6 @@ class SettingsDialog(QtWidgets.QDialog):
obfs4 bridges option was toggled. If checked, disable custom bridge options. obfs4 bridges option was toggled. If checked, disable custom bridge options.
""" """
if checked: if checked:
self.tor_bridges_use_custom_radio.setEnabled(False)
self.tor_bridges_use_custom_textbox_options.hide() self.tor_bridges_use_custom_textbox_options.hide()
def tor_bridges_use_custom_radio_toggled(self, checked): def tor_bridges_use_custom_radio_toggled(self, checked):
@ -414,7 +412,6 @@ class SettingsDialog(QtWidgets.QDialog):
Custom bridges option was toggled. If checked, show custom bridge options. Custom bridges option was toggled. If checked, show custom bridge options.
""" """
if checked: if checked:
self.tor_bridges_use_obfs4_radio.setEnabled(False)
self.tor_bridges_use_custom_textbox_options.show() self.tor_bridges_use_custom_textbox_options.show()
def connection_type_automatic_toggled(self, checked): def connection_type_automatic_toggled(self, checked):