From 790d07a4e7112991a80d3100d25b076b9d6059be Mon Sep 17 00:00:00 2001 From: Micah Lee Date: Wed, 17 Jan 2018 14:26:15 -0800 Subject: [PATCH] Fix issue with Windows codesigning --- BUILD.md | 2 +- install/build_exe.bat | 4 ++-- install/onionshare.nsi | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/BUILD.md b/BUILD.md index 588685d0..31c88c4f 100644 --- a/BUILD.md +++ b/BUILD.md @@ -98,7 +98,7 @@ Download and install the 32-bit [Visual C++ Redistributable for Visual Studio 20 Download and install the standalone [Windows 10 SDK](https://dev.windows.com/en-us/downloads/windows-10-sdk). Note that you may not need this if you already have Visual Studio. Add the following directories to the path: -* `C:\Program Files (x86)\Windows Kits\10\bin\x86` +* `C:\Program Files (x86)\Windows Kits\10\bin\10.0.16299.0\x86` * `C:\Program Files (x86)\Windows Kits\10\Redist\ucrt\DLLs\x86` * `C:\Users\user\AppData\Local\Programs\Python\Python36-32\Lib\site-packages\PyQt5\Qt\bin` diff --git a/install/build_exe.bat b/install/build_exe.bat index fe15c8f2..6c49c7d8 100644 --- a/install/build_exe.bat +++ b/install/build_exe.bat @@ -8,10 +8,10 @@ REM download tor python install\get-tor-windows.py REM sign onionshare-gui.exe -signtool.exe sign /v /d "OnionShare" /a /tr http://timestamp.globalsign.com/scripts/timstamp.dll /fd sha256 dist\onionshare\onionshare-gui.exe +signtool.exe sign /v /d "OnionShare" /a /tr http://time.certum.pl/ /fd sha256 dist\onionshare\onionshare-gui.exe REM build an installer, dist\onionshare-setup.exe makensis.exe install\onionshare.nsi REM sign onionshare-setup.exe -signtool.exe sign /v /d "OnionShare" /a /tr http://timestamp.globalsign.com/scripts/timstamp.dll /fd sha256 dist\onionshare-setup.exe +signtool.exe sign /v /d "OnionShare" /a /tr http://time.certum.pl/ /fd sha256 dist\onionshare-setup.exe diff --git a/install/onionshare.nsi b/install/onionshare.nsi index f12c6190..03830909 100644 --- a/install/onionshare.nsi +++ b/install/onionshare.nsi @@ -39,7 +39,7 @@ ${EndIf} !echo "Creating normal installer" !system "makensis.exe /DINNER onionshare.nsi" = 0 !system "$%TEMP%\tempinstaller.exe" = 2 - !system "signtool.exe sign /v /d $\"Uninstall OnionShare$\" /a /tr http://timestamp.globalsign.com/scripts/timstamp.dll /fd sha256 $%TEMP%\uninstall.exe" = 0 + !system "signtool.exe sign /v /d $\"Uninstall OnionShare$\" /a /tr http://time.certum.pl/ /fd sha256 $%TEMP%\uninstall.exe" = 0 # all done, now we can build the real installer OutFile "..\dist\onionshare-setup.exe"