Properly handle errors for using stealth onion services in the GUI, instead of crashing in the background (#144)

onionshare/onionshare.py

@@ -50,7 +50,12 @@ class OnionShare(object):
         self.transparent_torification = transparent_torification
 
         # use stealth onion service
+        self.set_stealth(stealth)
+
+    def set_stealth(self, stealth):
         self.stealth = stealth
+        if self.onion:
+            self.onion.stealth = stealth
 
     def choose_port(self):
         """

onionshare_gui/onionshare_gui.py

@@ -176,6 +176,10 @@ class OnionShareGui(QtWidgets.QMainWindow):
                 self.starting_server_error.emit(e.args[0])
                 return
 
+            except onionshare.onion.TorTooOld as e:
+                self.starting_server_error.emit(e.args[0])
+                return
+
         t = threading.Thread(target=start_onion_service, kwargs={'self': self})
         t.daemon = True
         t.start()

onionshare_gui/options.py

@@ -66,9 +66,9 @@ class Options(QtWidgets.QVBoxLayout):
         When the 'stealth' checkbox is toggled, let the onionshare app know.
         """
         if state == 2:
-            self.app.stealth = True
+            self.app.set_stealth(True)
         else:
-            self.app.stealth = False
+            self.app.set_stealth(False)
 
     def set_stealth_enabled(self, enabled):
         """