From 57e7bae86c528f2219594d6d79cd0b42a27cd7c4 Mon Sep 17 00:00:00 2001 From: Miguel Jacq Date: Tue, 23 May 2017 08:30:24 +1000 Subject: [PATCH] Refactor help button to use QDesktopServices.openUrl() --- onionshare_gui/settings_dialog.py | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/onionshare_gui/settings_dialog.py b/onionshare_gui/settings_dialog.py index 5086477f..b1967247 100644 --- a/onionshare_gui/settings_dialog.py +++ b/onionshare_gui/settings_dialog.py @@ -18,7 +18,7 @@ You should have received a copy of the GNU General Public License along with this program. If not, see . """ from PyQt5 import QtCore, QtWidgets, QtGui -import os, sys, platform, datetime, webbrowser +import sys, platform, datetime from onionshare import strings, common from onionshare.settings import Settings @@ -499,13 +499,7 @@ class SettingsDialog(QtWidgets.QDialog): """ common.log('SettingsDialog', 'help_clicked') help_site = 'https://github.com/micahflee/onionshare/wiki' - system = platform.system() - if system == 'Darwin': - # Work around bug in webbrowser on OS X - # see http://bugs.python.org/issue30392 - os.system('open {}'.format(help_site)) - else: - webbrowser.open(help_site) + QtGui.QDesktopServices.openUrl(QtCore.QUrl(help_site)) def settings_from_fields(self): """