From 5178f4971817af9d98ace402d25666f8b8ac7d51 Mon Sep 17 00:00:00 2001 From: Micah Lee Date: Sun, 20 May 2018 11:04:45 -0700 Subject: [PATCH] Only show other_page_loaded message on actual 404s --- onionshare_gui/onionshare_gui.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/onionshare_gui/onionshare_gui.py b/onionshare_gui/onionshare_gui.py index c2bfa749..80e5fba9 100644 --- a/onionshare_gui/onionshare_gui.py +++ b/onionshare_gui/onionshare_gui.py @@ -402,8 +402,9 @@ class OnionShareGui(QtWidgets.QMainWindow): if event["type"] == Web.REQUEST_ERROR_DOWNLOADS_DIR_NOT_WRITABLE: Alert(self.common, strings._('error_downloads_dir_not_writable').format(self.common.settings.get('downloads_dir'))) - elif event["path"] != '/favicon.ico': - self.status_bar.showMessage('[#{0:d}] {1:s}: {2:s}'.format(mode.web.error404_count, strings._('other_page_loaded', True), event["path"])) + if event["type"] == Web.REQUEST_OTHER: + if event["path"] != '/favicon.ico': + self.status_bar.showMessage('[#{0:d}] {1:s}: {2:s}'.format(mode.web.error404_count, strings._('other_page_loaded', True), event["path"])) mode.timer_callback()